From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3954B386C15 for ; Sat, 23 May 2026 09:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779529436; cv=none; b=nW3wQwbMt7ArC9tuPTL4LXjLHx5senNX7Z1n8mdpe/EVEj1PIPplOhZ84yqnboDnraLJynbE7aqwbPQpsfBXs0BtFFmbkUrsAaoMVZD4OWWWvGww+zx6TaNQRSFszosQHM700Wp9oVsEL+/P3unCFZ5Pn1/XwE1S+hbNzKKPI9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779529436; c=relaxed/simple; bh=cA6OvtiMYiH8fWm6hs/pB2NqRBhSnJLhmhXOqE10cNA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rfUsQfYNx1A/F8a+qH6109BNU22QG8ZTVMtzI1vzgnXQRwVAODZ0cH2NwVEzTExG4YxjBlXyeVJOGv5meREYmy+NVmTr1kbY8PASJst4WgYqDk9pOddCbSfqNOEhndrBtVwMY9d7ksnQFohYeJxEfnWaUK9m0rpeoita1G89Xrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qpi7iN2b; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qpi7iN2b" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2ef2a1cc06dso12795989eec.0 for ; Sat, 23 May 2026 02:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779529433; x=1780134233; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=veSAHzzDLBJHWUT6ObwVQlgXBETLjKgsofHDN9ZwSyE=; b=qpi7iN2bE/i6DxBZNgs/At8dl3Zlt7X3cG6DGwIuObIOOkB/3ylh3b4H9/mYgjGlwZ PB84zWS1Ks3dR4epH0IyrWIPBgc15oDctMAisY1VEBOMJTM05+cvhOwGbKKUB2yeWV8E bKJt/TxZaNvaxzUn7qoWia6Nj+SC3OucyDs+QPw//R+4EGNRkm2zMIXZyZGq/en8Tfk8 /ThPXghF2P6nMNiIc16oeQwhDFxOJxQGnE4mGvTxUKkqqs5KPmY/R46tFdm+EErU1ZSG CQjSM4Pgduwnn7uPwYOck/EhGWXuejDdJ4XzYpvUoktDlFBIUTKUFMFNda4QxcgR/y4M 3ixw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779529433; x=1780134233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=veSAHzzDLBJHWUT6ObwVQlgXBETLjKgsofHDN9ZwSyE=; b=Fdiy01upQv6FPtcV6puEesU45hF4vJj+z0fmyYAbOetoDsaaZHS3/mCDwBQ36ZY1ZA 9GjrKB35PGPr2DtNfcJUfRC/FDFOpKispTJ0FlvMaOy7A+dequgGmsm6dCYnlNNPjlFb H4QhJIt5dMGYEkKyPW4Tr8sf1FY3mXNZgOUDjr8MoGQhO4n3kCWMIPkFjO/Cu8PVjGok EGNBms0ReSwaubmZLwlE94JhSKBMCJDRoUaPGg4CnZIXM3+xCqpknNTbR6Bt8qXiwSmI YHkeQ0vf8kilnuDmtq65CpX6gTkpkVdbL0MknHz9j9jxwc/JSXRG4x0CX8trOnJXFf0i zF+A== X-Forwarded-Encrypted: i=1; AFNElJ+7FUqy3TJWAQr/Ln0uNLRVuuuaigIVjcV+BT1K8ek4oSlWfw94JJBEmhDWfLJeEU/+rqE+WTKZRYTMtaY=@vger.kernel.org X-Gm-Message-State: AOJu0YxoJN3YAZiEvOarof65T4ZaVcWL767cSUJ4E+pK6xLeV+wljktp fI0ve9gVFbzkprsTIMM7HomwHcbiQtZxfsWkNOUgRdMh36E+AAX2ylbM X-Gm-Gg: Acq92OGMohJJVoHFbI5HGQg12ZMZ5nOnhKdkQK/bYhxnuFLJePFgqEBx7Thub5n/acd K82MRQIQBiOpXHvL7SRHaGhTVDDTu0L3Q0ry1usxGFuwRs1lSXTXSVy3sz6TLpMwtvLJgymO6eH 6cTVJlYySirR2v8ImdHiupvGk5xkUz1qESNU0ykXpaaWMvL/FNgRmqaekmBkOYR/+8xzaAX+7hJ XqwLjW47mnvPQALh6hneqpP2Cxk8MYDZtRvszv/eUs1lp+om1EDUo5XyAlV7HJ279OGSvwfcBHn To41iNPTfEVLgMIoO3ipvIMT4qqlCcxOmnIlH944Gh6bar3wdcodJvDePbyHuM+n4yNH7h3URWc TSRbfoqyjpKQne/ZHrYte/hEYu811Vh0lc6qkPwEgqgiZosmN1Aa/L1g0Y1VWo1F8acq7Xlg5aa ms4njVqxux47xH1qBM2TNrTmaPqx1apvKnaVlLu3+rHu6vT/LChh0LCBc5rJS1pbi0sriguAbSv l+wByViaftSp3fMNg== X-Received: by 2002:a05:7022:1e11:b0:130:6c8f:5a87 with SMTP id a92af1059eb24-1365f81e50amr3002026c88.13.1779529433221; Sat, 23 May 2026 02:43:53 -0700 (PDT) Received: from AnisaLaptop.localdomain (c-73-170-217-179.hsd1.ca.comcast.net. [73.170.217.179]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1366a40305csm2376358c88.7.2026.05.23.02.43.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 02:43:52 -0700 (PDT) From: Anisa Su X-Google-Original-From: Anisa Su To: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org Cc: nvdimm@lists.linux.dev, Dan Williams , Jonathan Cameron , Davidlohr Bueso , Dave Jiang , Vishal Verma , Ira Weiny , Alison Schofield , John Groves , Gregory Price , Ira Weiny , Jonathan Cameron , Fan Ni , Li Ming , Dan Williams Subject: [PATCH v10 09/31] cxl/pci: Factor out interrupt policy check Date: Sat, 23 May 2026 02:43:03 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Ira Weiny Dynamic Capacity Devices (DCD) require event interrupts to process memory addition or removal. BIOS may have control over non-DCD event processing. DCD interrupt configuration needs to be separate from memory event interrupt configuration. Factor out event interrupt setting validation. Reviewed-by: Dave Jiang Reviewed-by: Jonathan Cameron Reviewed-by: Fan Ni Reviewed-by: Li Ming Link: https://lore.kernel.org/all/663922b475e50_d54d72945b@dwillia2-xfh.jf.intel.com.notmuch/ [1] Suggested-by: Dan Williams Signed-off-by: Ira Weiny --- Changes: [anisa: rebase] --- drivers/cxl/pci.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c index 35942b2ace53..8d12c684d670 100644 --- a/drivers/cxl/pci.c +++ b/drivers/cxl/pci.c @@ -639,6 +639,21 @@ static bool cxl_event_int_is_fw(u8 setting) return mode == CXL_INT_FW; } +static bool cxl_event_validate_mem_policy(struct cxl_memdev_state *mds, + struct cxl_event_interrupt_policy *policy) +{ + if (cxl_event_int_is_fw(policy->info_settings) || + cxl_event_int_is_fw(policy->warn_settings) || + cxl_event_int_is_fw(policy->failure_settings) || + cxl_event_int_is_fw(policy->fatal_settings)) { + dev_err(mds->cxlds.dev, + "FW still in control of Event Logs despite _OSC settings\n"); + return false; + } + + return true; +} + static int cxl_event_config(struct pci_host_bridge *host_bridge, struct cxl_memdev_state *mds, bool irq_avail) { @@ -661,14 +676,8 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge, if (rc) return rc; - if (cxl_event_int_is_fw(policy.info_settings) || - cxl_event_int_is_fw(policy.warn_settings) || - cxl_event_int_is_fw(policy.failure_settings) || - cxl_event_int_is_fw(policy.fatal_settings)) { - dev_err(mds->cxlds.dev, - "FW still in control of Event Logs despite _OSC settings\n"); + if (!cxl_event_validate_mem_policy(mds, &policy)) return -EBUSY; - } rc = cxl_event_config_msgnums(mds, &policy); if (rc) -- 2.43.0