From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C746F1E47B1 for ; Tue, 3 Dec 2024 13:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733233838; cv=none; b=Mp8BL+0RLK25OS/eAr6HNajJ32GKF/YTpDGvVp/UdmEaYoGmNL3uFQNRa6hdWnR0VRlFDfg3DXqFNRkakF6JAxi2Db8urvIBRiv2nn/d1+2ZkarYSo5yArFHnV4si33izgujx6MLZ23Ldg1zQ+I3E1BJ/YjEurnCTCiOEt9RjtQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733233838; c=relaxed/simple; bh=bZyUqYcg3v5s0JBNpXcGl0Kr41t5wBvVh6TYlFZoBiM=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=hDiduYlWDv/ELuD+/WV4zDjr178FNVL5QW1eED8NMvVfHXRsvMRxWSv1kAChXgjWfeMJJhU37CUSxR4orEbgj188Flo+X3ej+imhitU1TepgA75vCAs1JefxPgOmsF6bZr1gJqPiGTcpIX6YHZb4U0tU9hh2VUIKWfMhUAQyRsw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HnSmirQ1; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HnSmirQ1" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-385e96a285eso1607965f8f.3 for ; Tue, 03 Dec 2024 05:50:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733233835; x=1733838635; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=hBcwo9eIpFhlU/J4DHTZIeUqEYh0WviOXbdmOon8iiA=; b=HnSmirQ1Z6ljQcEiF7FMv+TQlXjyg/CM2ja4izsEXOzr9MQYOc7ejrN2ArFjzpGdCp cY7GqnSV7YYFggwNk7ze3VMx1TDeDa/kfLr3bXTvuse7mMIozmKgjiDrDOp8kv+mmwDD f4CrX5nZd4p0Rse6UB9WEW/QR4ciEvLYq6XtjNWMdNtiFTajk1u86EgWYkG5JJjr2Yki Kw01O+tYiyk6xYOyih+aGItIsRwxH2Q3Kwe2Iwb4xE9gsYm8l3uuiVJ02O66ksQ3vSUI IDJTq0Ht74vPCVsqmmnGDMXtks5S5g7qhP8UpBIy8igaAfMAFMDdP0DoXf0MD9DpsPkA 2sFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733233835; x=1733838635; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=hBcwo9eIpFhlU/J4DHTZIeUqEYh0WviOXbdmOon8iiA=; b=UgW3MLJc4qZ1JU3blu+OD0f8O4p315abHorapa33QLcPnfGrOADOGPXKHKuhoDe2nX u+JaVwJkrUvk3W0u0X8TK7XfSTnvgI/iDgCJ4sgyALxcPdhAbuByJk81SxMTRe1MThEK cx3Bvu+gYtYqpqPw1NrLMkSjYIIXxFlZ+0Gva3HHjhJ6HZjhrO8A8Tb5JWqcvnmdcmku DXzJUzhObqYFCRjuQw/+CR6KWNwEHNVBPgjTieEncSs126QpgqvF6LRZd1TrPC0v7rNM JuVIpbA4NgGenuPcHPTeu077g+nwAnT7bHkpDtvzND4Fs7kLcKRVMxw4ycCfK6jHyEWr wblg== X-Forwarded-Encrypted: i=1; AJvYcCVaHmnl7IybbhrTftirtVN2yVR98E/b+F5xdzc+GSKufNu1nYY3yr1/c9/S4PiIgu8v7mKcnW5vDxUbW0I=@vger.kernel.org X-Gm-Message-State: AOJu0YxkN1MGVUrkS+1LbB+jBq6UndGUR7LLz0rRHrsDmI066lOa8P2a vF53kMv8fZvFbhDdIxI95fsfw+6GstpQ194CNswX8yJIdCNYQ/gXhoyW6xyXPWQ= X-Gm-Gg: ASbGnctIovdK85fTTcT6ygnuCQFH4ec1mDvdG+welOZy1yBQODOwuyOK9tBqqQEaLH6 Kshlpg5NRNDKxELvFi8NlVuClVteyhCjHqN+FKbjiot4QyUahOpugo/WldxJwpDwcYNSZEhyXAc O8Yeb4FVmkhj/FzVBJCekJ81d2tZzqiF9DRPCCQbyDyL+8Pu+0N5n3VbFFv81doiN4UAdrOAovA CYq06oAHhklYWh8N1q46HK8M0gjC/1HJxTIiYkj6BDnazi7I3jIZ1db1aPO0BBvNiY0lP0O/XkK oisv5ocbLrgy/iC+beiXWXPR X-Google-Smtp-Source: AGHT+IEi93wdfnyxOOsXD1iaOm0aYo0vmjHZ2S8lJrh1fgGf6vIMZGQiHeweFABcyUVMhTNIfdCzPQ== X-Received: by 2002:a5d:5985:0:b0:385:e3c5:61ae with SMTP id ffacd0b85a97d-38607ae39fbmr265368f8f.31.1733233835095; Tue, 03 Dec 2024 05:50:35 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:b668:b88:4ecf:c065? ([2a01:e0a:982:cbb0:b668:b88:4ecf:c065]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385df63255bsm12765093f8f.86.2024.12.03.05.50.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2024 05:50:34 -0800 (PST) Message-ID: Date: Tue, 3 Dec 2024 14:50:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 6/9] crypto: qce - make qce_register_algs() a managed interface To: Bartosz Golaszewski , Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20241203-crypto-qce-refactor-v1-0-c5901d2dd45c@linaro.org> <20241203-crypto-qce-refactor-v1-6-c5901d2dd45c@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241203-crypto-qce-refactor-v1-6-c5901d2dd45c@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/12/2024 10:19, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Make qce_register_algs() a managed interface. This allows us to further > simplify the remove() callback. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/crypto/qce/core.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > index e2cda24960f63..5e21754c7f822 100644 > --- a/drivers/crypto/qce/core.c > +++ b/drivers/crypto/qce/core.c > @@ -4,6 +4,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -37,9 +38,10 @@ static const struct qce_algo_ops *qce_ops[] = { > #endif > }; > > -static void qce_unregister_algs(struct qce_device *qce) > +static void qce_unregister_algs(void *data) > { > const struct qce_algo_ops *ops; > + struct qce_device *qce = data; > int i; > > for (i = 0; i < ARRAY_SIZE(qce_ops); i++) { > @@ -48,7 +50,7 @@ static void qce_unregister_algs(struct qce_device *qce) > } > } > > -static int qce_register_algs(struct qce_device *qce) > +static int devm_qce_register_algs(struct qce_device *qce) > { > const struct qce_algo_ops *ops; > int i, j, ret = -ENODEV; > @@ -63,7 +65,7 @@ static int qce_register_algs(struct qce_device *qce) > } > } > > - return 0; > + return devm_add_action_or_reset(qce->dev, qce_unregister_algs, qce); > } > > static int qce_handle_request(struct crypto_async_request *async_req) > @@ -248,7 +250,7 @@ static int qce_crypto_probe(struct platform_device *pdev) > qce->async_req_enqueue = qce_async_request_enqueue; > qce->async_req_done = qce_async_request_done; > > - return qce_register_algs(qce); > + return devm_qce_register_algs(qce); > } > > static void qce_crypto_remove(struct platform_device *pdev) > @@ -256,7 +258,6 @@ static void qce_crypto_remove(struct platform_device *pdev) > struct qce_device *qce = platform_get_drvdata(pdev); > > tasklet_kill(&qce->done_tasklet); > - qce_unregister_algs(qce); > } > > static const struct of_device_id qce_crypto_of_match[] = { > Reviewed-by: Neil Armstrong