mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ruinskiy, Dima" <dima.ruinskiy@intel.com>
To: "Daniel Viaño" <danividanivi@gmail.com>,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Cc: <anthony.l.nguyen@intel.com>, <przemyslaw.kitszel@intel.com>,
	<bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
	<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
	<edumazet@kernel.org>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH iwl-net v2 2/2] igc: treat I226-LMvP as an I226 device
Date: Wed, 18 Nov 2026 09:09:09 +0200	[thread overview]
Message-ID: <a2284c4d-8c30-4d98-8886-9d9f90bb9b97@intel.com> (raw)
In-Reply-To: <20261111093035.513635-3-danividanivi@gmail.com>

On 11/11/2026 11:30, Daniel Viaño wrote:
> The I226-LMvP device ID (0x5503) was added by commit 8f20571db527
> ("igc: Add new device ID"), but when commit b8897dc54e3b ("igc: remove
> I226 Qbv BaseTime restriction") introduced igc_is_device_id_i226(), it
> was left out. As a result I226-LMvP is currently treated as neither an
> I225 nor an I226 part.
> 
> Add IGC_DEV_ID_I226_LMVP to igc_is_device_id_i226(). This changes the
> behaviour for I226-LMvP in the following places, all of which now
> match the other I226 parts:
> 
>   - igc_probe() and igc_io_slot_reset() disable ASPM L1.2, as done for
>     I226 since commit 0325143b59c6 ("igc: disable L1.2 PCI-E link
>     substate to avoid performance issue").
>   - igc_tsn_enable_offload() and igc_tsn_disable_offload() set and
>     restore the I226-specific RETX (Qbv full) thresholds.
>   - igc_tsn_enable_offload() handles the FutScdDis bit and the base
>     time as on I226.
> 
> Intel confirmed that the I226 TSN functionality introduced by commit
> b8897dc54e3b also applies to I226-LMvP.
> 
> Fixes: b8897dc54e3b ("igc: remove I226 Qbv BaseTime restriction")
> Link: https://lore.kernel.org/all/5d45a583-198c-467d-afbe-8f19398e82f3@intel.com/
> Signed-off-by: Daniel Viaño <danividanivi@gmail.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_base.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_base.c b/drivers/net/ethernet/intel/igc/igc_base.c
> index ab9120a31..6865fef40 100644
> --- a/drivers/net/ethernet/intel/igc/igc_base.c
> +++ b/drivers/net/ethernet/intel/igc/igc_base.c
> @@ -447,6 +447,7 @@ bool igc_is_device_id_i226(struct igc_hw *hw)
>   	case IGC_DEV_ID_I226_V:
>   	case IGC_DEV_ID_I226_K:
>   	case IGC_DEV_ID_I226_IT:
> +	case IGC_DEV_ID_I226_LMVP:
>   		return true;
>   	default:
>   		return false;

Reviewed-by: Dima Ruinskiy <dima.ruinskiy@intel.com>

      reply	other threads:[~2026-11-18  7:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  9:30 [PATCH iwl-net v2 0/2] igc: fix L1.2 disable on resume, add I226-LMvP to I226 helper Daniel Viaño
2026-11-11  9:30 ` [PATCH iwl-net v2 1/2] igc: don't disable ASPM L1.2 from __igc_resume() Daniel Viaño
2026-11-18  7:08   ` Ruinskiy, Dima
2026-11-11  9:30 ` [PATCH iwl-net v2 2/2] igc: treat I226-LMvP as an I226 device Daniel Viaño
2026-11-18  7:09   ` Ruinskiy, Dima [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2284c4d-8c30-4d98-8886-9d9f90bb9b97@intel.com \
    --to=dima.ruinskiy@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=bhelgaas@google.com \
    --cc=danividanivi@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®