From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933134AbdCKSgn (ORCPT ); Sat, 11 Mar 2017 13:36:43 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:37060 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754391AbdCKSgf (ORCPT ); Sat, 11 Mar 2017 13:36:35 -0500 Subject: Re: [PATCH v1 01/10] staging: iio: ad7192: Remove exceptional & on function name To: simran singhal , lars@metafoo.de References: <1489242404-12352-1-git-send-email-singhalsimran0@gmail.com> <1489242404-12352-2-git-send-email-singhalsimran0@gmail.com> Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com From: Jonathan Cameron Message-ID: Date: Sat, 11 Mar 2017 18:36:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1489242404-12352-2-git-send-email-singhalsimran0@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03/17 14:26, simran singhal wrote: > Remove & from function pointers to conform to the style found elsewhere > in the file. Done using the following semantic patch > > // > @r@ > identifier f; > @@ > > f(...) { ... } > @@ > identifier r.f; > @@ > > - &f > + f > // > > Signed-off-by: simran singhal Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7192.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c > index 4fc8588..d11c6de 100644 > --- a/drivers/staging/iio/adc/ad7192.c > +++ b/drivers/staging/iio/adc/ad7192.c > @@ -564,18 +564,18 @@ static int ad7192_write_raw_get_fmt(struct iio_dev *indio_dev, > } > > static const struct iio_info ad7192_info = { > - .read_raw = &ad7192_read_raw, > - .write_raw = &ad7192_write_raw, > - .write_raw_get_fmt = &ad7192_write_raw_get_fmt, > + .read_raw = ad7192_read_raw, > + .write_raw = ad7192_write_raw, > + .write_raw_get_fmt = ad7192_write_raw_get_fmt, > .attrs = &ad7192_attribute_group, > .validate_trigger = ad_sd_validate_trigger, > .driver_module = THIS_MODULE, > }; > > static const struct iio_info ad7195_info = { > - .read_raw = &ad7192_read_raw, > - .write_raw = &ad7192_write_raw, > - .write_raw_get_fmt = &ad7192_write_raw_get_fmt, > + .read_raw = ad7192_read_raw, > + .write_raw = ad7192_write_raw, > + .write_raw_get_fmt = ad7192_write_raw_get_fmt, > .attrs = &ad7195_attribute_group, > .validate_trigger = ad_sd_validate_trigger, > .driver_module = THIS_MODULE, >