From: John Garry <john.garry@huawei.com>
To: "Paul A. Clarke" <pc@us.ibm.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>,
Andi Kleen <ak@linux.intel.com>, Kajol Jain <kjain@linux.ibm.com>,
Stephane Eranian <eranian@google.com>,
Ian Rogers <irogers@google.com>
Subject: Re: [PATCHv4 00/19] perf metric: Add support to reuse metric
Date: Tue, 23 Mar 2021 15:15:16 +0000 [thread overview]
Message-ID: <a233702a-89b7-ae47-d47a-a7b4539c191e@huawei.com> (raw)
In-Reply-To: <20210323150604.GB8931@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com>
On 23/03/2021 15:06, Paul A. Clarke wrote:
> On Mon, Mar 22, 2021 at 11:36:23AM +0000, John Garry wrote:
>> On 01/08/2020 12:40, Paul A. Clarke wrote:
>>>> v4 changes:
>>>> - removed acks from patch because it changed a bit
>>>> with the last fixes:
>>>> perf metric: Collect referenced metrics in struct metric_ref_node
>>>> - fixed runtime metrics [Kajol Jain]
>>>> - increased recursion depth [Paul A. Clarke]
>>>> - changed patches due to dependencies:
>>>> perf metric: Collect referenced metrics in struct metric_ref_node
>>>> perf metric: Add recursion check when processing nested metrics
>>>> perf metric: Rename struct egroup to metric
>>>> perf metric: Rename group_list to metric_list
>>>>
>>>> Also available in here:
>>>> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>>>> perf/metric
>>> I built and ran from the above git branch, and things seem to work.
>>> Indeed, I was able to apply my changes to exploit the new capabilities
>>> via modifications to tools/perf/pmu-events/arch/powerpc/power9/metrics.json,
>>> as I posted earlier (and will submit once this set gets merged).
>> I was just wondering: Does perf subtest 10.3 work ok for you with the metric
>> reuse?
>>
>> That's "Parsing of PMU event table metrics" subtest.
> I confess I'm not sure what you are asking. Using the latest mainline
> (84196390620ac0e5070ae36af84c137c6216a7dc), perf subtest 10.3 does
> pass for me:
> --
> $ ./perf test 10
> 10: PMU events :
> 10.1: PMU event table sanity : Ok
> 10.2: PMU event map aliases : Ok
> 10.3: Parsing of PMU event table metrics : Ok
> 10.4: Parsing of PMU event table metrics with fake PMUs : Ok
> --
Since commit 8989f5f07605 ("perf stat: Update POWER9 metrics to utilize
other metrics"), power9 has reused metrics.
And I am finding that subtest 10.3 caused problems when I tried to
introduce metric reuse on arm64, so I was just asking you to check.
Now I am a bit confused...
Thanks for checking,
john
next prev parent reply other threads:[~2021-03-23 15:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 9:18 Jiri Olsa
2020-07-29 9:18 ` [PATCH 01/19] perf metric: Fix memory leak in expr__add_id function Jiri Olsa
2020-07-29 9:18 ` [PATCH 02/19] perf metric: Add " Jiri Olsa
2020-07-29 9:18 ` [PATCH 03/19] perf metric: Change expr__get_id to return struct expr_id_data Jiri Olsa
2020-07-29 9:18 ` [PATCH 04/19] perf metric: Add expr__del_id function Jiri Olsa
2020-07-29 9:18 ` [PATCH 05/19] perf metric: Add macros for iterating map events Jiri Olsa
2020-07-29 9:18 ` [PATCH 06/19] perf metric: Add add_metric function Jiri Olsa
2020-07-29 9:18 ` [PATCH 07/19] perf metric: Rename __metricgroup__add_metric to __add_metric Jiri Olsa
2020-07-29 9:18 ` [PATCH 08/19] perf metric: Collect referenced metrics in struct metric_ref_node Jiri Olsa
2020-07-29 9:18 ` [PATCH 09/19] perf metric: Collect referenced metrics in struct metric_expr Jiri Olsa
2020-07-29 9:18 ` [PATCH 10/19] perf metric: Add referenced metrics to hash data Jiri Olsa
2020-07-29 9:19 ` [PATCH 11/19] perf metric: Compute referenced metrics Jiri Olsa
2020-07-29 9:19 ` [PATCH 12/19] perf metric: Add events for the current list Jiri Olsa
2020-07-29 9:19 ` [PATCH 13/19] perf metric: Add cache_miss_cycles to metric parse test Jiri Olsa
2020-07-29 9:19 ` [PATCH 14/19] perf metric: Add DCache_L2 " Jiri Olsa
2020-07-29 9:19 ` [PATCH 15/19] perf metric: Add recursion check when processing nested metrics Jiri Olsa
2020-07-29 9:19 ` [PATCH 16/19] perf metric: Make compute_single function more precise Jiri Olsa
2020-07-29 9:19 ` [PATCH 17/19] perf metric: Add metric group test Jiri Olsa
2020-07-29 9:19 ` [PATCH 18/19] perf metric: Rename struct egroup to metric Jiri Olsa
2020-07-29 9:19 ` [PATCH 19/19] perf metric: Rename group_list to metric_list Jiri Olsa
2020-08-01 11:40 ` [PATCHv4 00/19] perf metric: Add support to reuse metric Paul A. Clarke
2020-08-03 15:54 ` Ian Rogers
2020-08-03 16:26 ` Jiri Olsa
2020-08-03 16:49 ` Arnaldo Carvalho de Melo
2021-03-22 11:36 ` John Garry
2021-03-23 15:06 ` Paul A. Clarke
2021-03-23 15:15 ` John Garry [this message]
2021-03-24 1:54 ` Paul A. Clarke
2021-03-24 9:13 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a233702a-89b7-ae47-d47a-a7b4539c191e@huawei.com \
--to=john.garry@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®