From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F0AD1F4727 for ; Tue, 21 Jan 2025 16:28:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737476923; cv=none; b=O2Nfic6tl0i+DviCZGd9VeVl+vnhPldOjhcUb6W0MOEINIXic0avbvNYyHNkUFh8an2gxsvo0Pr/P3IxU7Bgy8K+yOaLdXR868VVrJw2nCTfgsUtbWChkmtFGuJzeSYPMiO2NInLtuiY5A4DxsiXLvfHn61Leu3+V9IdGYYgzz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737476923; c=relaxed/simple; bh=xm7P2Xj9F0lX1TUn6zaultfqdKWfNMJP3gmWrDgoe7c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uMjvDeTC+vYVTfnIT8lcJa7okV/obEkSCR+xV5I0uVWmT56nsd2xIKVr6bZIB1HT9fRqg5C2Ab5uiDJST6vpHCfsqN86l2a8Ft3/NOX8uBDU2h+RdDTVaGSNvbuEsph1pbI+NdyjF3vTIOZkEZcDTt6YLoXqlS1UoKqcYwZEXHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=So6dK0HQ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="So6dK0HQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737476918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=18AfannScfIY8EriR2EO/tvHIiDq19oOA7Fl7JCU7uk=; b=So6dK0HQTFNZCjCdFB2LkeUeaxqXofMQ3kpC6NVD22VWgU+UjHbF4l0P3N0RHwlAflMngW ZvWQs8jraOz44c5PH1vhvzG/oaTe6WJ7UB7ijwGaC+IgNMZMxlHyApLuoHVg65hzgsJGWe CQq2724+akwQuQkyZdmOgcEYPbm20YY= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-IQuIwr27MLO1cRve9rvzNA-1; Tue, 21 Jan 2025 11:28:37 -0500 X-MC-Unique: IQuIwr27MLO1cRve9rvzNA-1 X-Mimecast-MFC-AGG-ID: IQuIwr27MLO1cRve9rvzNA Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-5d3f4cbbbbcso6322118a12.1 for ; Tue, 21 Jan 2025 08:28:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737476916; x=1738081716; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=18AfannScfIY8EriR2EO/tvHIiDq19oOA7Fl7JCU7uk=; b=WTZtYeu18yjqu/0zixEdYtN6BTJDJIdIWOPRC0uyW9F+6zyTuXNu0w9w7bzbcreLNF GpO5G6y1Wi5EgS6LoXYKil0i7n7Dhw3plZJk3T7PT0odriSwmw/uFaRiwUW1kMidhY5+ ytLBTja5L+TFMPYxhszAqAcRrm3H8xJi888MtJ5fgc+QT5sDCzsXeVXAOKfXWj8Qfb/X GkenuWgruqQZw2T3Eo44Gucn8C8cBEKnx3pWGsYeoTNj/c3uKyX2Mtdv95yEo9NVuP6F ep257TH4JOsntR5LO2TYz1a4MIQJKs9jH8++yoV/mFQ4Qnu5XGnmXwuv/8I4gI13b8LB d0gA== X-Forwarded-Encrypted: i=1; AJvYcCUxkjDBbKIUgNt5TxGrZkPTOmL40LJACrGtdC6DN4M9TQiaWppTpAM051FTIyZz22VC8+iWNTt+dugS/ig=@vger.kernel.org X-Gm-Message-State: AOJu0YzzHFyyzmwtr2W2LNcS12B/oNPS8L9ZEaffrkhJ43n9bn1XMoX7 MgMA34Uv83R8aN23lUSAlM686P6ckZDNgzdYpXnHl+7IBpye+Zyyllka+4Hew2w05m5tiYRu06P ncMzl4RSHftiOtu4llgLjAMDqnk5DtzEcTBYjp2QP0pyirC/PjL84JtJnbfTqN9t3AZSyNxul X-Gm-Gg: ASbGnctHe1tzgEDGrVuZ9BTTrXHhY6deX/JzCMBu+elfiY5wn6o3zm8Fy9e9rJXSx1a eNx7ug+YWd3BNNyhdWkrZ5CcGTcen7OzhR9sIWPZFCjb7ONdyZ2SvxLShbNZT+KVRHpC5dOuhPN 1z9b5D48UhA70eRijZbODqq3dLDgPeC6UVUwYTkn6z/QnvyTmJooEhD+6ccqyZU2oRtMz8/Tfev 4XRfpBroyqZQeGvcj2cBhH/Xc25aMYVZ8ruXfPhu+JVyF88oPir5GWFCAR2ImMUU9sWFlZnch0b jyw94ba9ZKXw+nnSkMXCMFqqFANiYpKPZbzTs7xN02+enmhel35JMqLWk7IEFFJMqnx/ueU2BWy qf6oSnaW38JTyCVmsJv2beY5oChoMHce+XoJVsCWY6RSO X-Received: by 2002:a17:907:7b9d:b0:aa6:8bb4:503b with SMTP id a640c23a62f3a-ab38b4c9a56mr1380321366b.55.1737476915846; Tue, 21 Jan 2025 08:28:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGjbp0Ky/GAOO7K7OUz99Kavj698xWxLY2zZiStonj4KktjESdUbpCmo1dejqrT0OSxw61NA== X-Received: by 2002:a17:907:7b9d:b0:aa6:8bb4:503b with SMTP id a640c23a62f3a-ab38b4c9a56mr1380319566b.55.1737476915450; Tue, 21 Jan 2025 08:28:35 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384f87d86sm772274066b.146.2025.01.21.08.28.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2025 08:28:34 -0800 (PST) Message-ID: Date: Tue, 21 Jan 2025 17:28:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] vboxsf: fix building with GCC 15 To: Brahmajit Das , viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250121162648.1408743-1-brahmajit.xyz@gmail.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20250121162648.1408743-1-brahmajit.xyz@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, On 21-Jan-25 5:26 PM, Brahmajit Das wrote: > Building with GCC 15 results in build error > fs/vboxsf/super.c:24:54: error: initializer-string for array of ‘unsigned char’ is too long [-Werror=unterminated-string-initialization] > 24 | static const unsigned char VBSF_MOUNT_SIGNATURE[4] = "\000\377\376\375"; > | ^~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Due to GCC having enabled -Werror=unterminated-string-initialization[0] > by default. Separately initializing each array element of > VBSF_MOUNT_SIGNATURE to ensure NUL termination, thus satisfying GCC 15 > and fixing the build error. > > [0]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wno-unterminated-string-initialization > > Signed-off-by: Brahmajit Das Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > fs/vboxsf/super.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c > index e95b8a48d8a0..1d94bb784108 100644 > --- a/fs/vboxsf/super.c > +++ b/fs/vboxsf/super.c > @@ -21,7 +21,8 @@ > > #define VBOXSF_SUPER_MAGIC 0x786f4256 /* 'VBox' little endian */ > > -static const unsigned char VBSF_MOUNT_SIGNATURE[4] = "\000\377\376\375"; > +static const unsigned char VBSF_MOUNT_SIGNATURE[4] = { '\000', '\377', '\376', > + '\375' }; > > static int follow_symlinks; > module_param(follow_symlinks, int, 0444);