From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 950AD2EEE84 for ; Sun, 23 Aug 2026 21:06:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787519211; cv=none; b=fhEiSged4gqLEUKWQmVL5DcuIHHi+O+gEaG3Y039wp02cI1QwJuc4m+Nsz9l9hlJusw3qBqxra6Cw9cyycoD366z5P1DrogpMrakb0tQNB6Ya/NLsIAlGM4XxOY422vKCRkr+osFqyCCNx2g9gYcQOQWjgM1TdjEf1wMcJGzfC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787519211; c=relaxed/simple; bh=H344s9DzWvS8P/u3edvqZ9ZTPPMEr6x9o6nLDo/TLWU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zg1GDzX/lqzmMOwjhVCGRQqaS5LjREzU1YLUe9+nNS34T+ZUuPag73pezoY48Ws4FzGhkoDqc9Ka0Ix0Dszl69wHi0LNVSDHiGhmlre7hDEDeFBuGpeOoOlUB7urUJlm0ETmyki2jSgMRO4DgIogywBtxH8GA9oUE75IxIPi+KA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aeo0vpHn; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aeo0vpHn" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-6a3ec9ef8d4so556873a12.1 for ; Sun, 23 Aug 2026 14:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787519208; x=1788124008; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NXEuJBGfzMeA2VoyieQfWVfmlZbv0eldSLa+1qSHcFI=; b=aeo0vpHnZ7VmbAJ3IazpZVCLQ3JKsug3XFue3s9x9htZIlTnz3guQdCZrAkIgnLdj5 oVAtPbmu1mKKctxxkV89MITfHzIQzaPQL2FCow+SSjWu11s2D+RXD1je3MZgcLCUxr5M YGraYjr1jkbk8n/ZtGVcF7W3CApSPsm8ZfQEw13FbJBrOmvQuXZy28em66rHBiXZBpl6 tgv4bj483NJY/qfH/EBCdqnYbaY1Y7CUEBKdeO6HstRJs64MjPcHza4ZPW8p9sBpFRJw WaIcBJbGM6qDIF/F+TvFMJrCTPe3AscnNmVjBq2/QKk41ouqI3ePr15ucY6fQTpDqzWe y52Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787519208; x=1788124008; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NXEuJBGfzMeA2VoyieQfWVfmlZbv0eldSLa+1qSHcFI=; b=caZ1wFgrdh541A+Yk/q4Z5oBY5VO1mZpMXISOZo3IubSIbamV7rJZLP5Y3jP7vS/Uq QTkJRjrHtUv3TCv3zygPrf/d/4XhPFVVDHYJHBGfeVeFx8kBdTlRufe2rf3ep10opqaD huIom4eZ5ez+5MDN1LwYdKlbVE9A+hcmTcGGuaWrwXHG3DOvhFC5L8U/30lqZil99via SM8a1++Ze93f3aSpyMSBLjf2y3l8hLwKP+Q/ggfstWMNY/RMxDW+i4mvioPtcLXHW9Vc eMwjByRtXXotD7XCImAGRes43IoXGVp+tbL3Wuhujvzqysqolnbb+7HA6iqToyB/fJLZ 5Kuw== X-Forwarded-Encrypted: i=1; AHgh+RqnxV+O9ixXHRHOCiyZigjO7GUBBnpDPqKn7VibgxBtLUuvIjTS4aqVa6qeV/Qkd9sf7obhN832iyhRlDY=@vger.kernel.org X-Gm-Message-State: AFuF++lYz+bVrBQLeEJ7Q9fINDAnsqAeWuj5gPAVON4BJdMVFzyCdIGM gOiUgaLLYOsVoNRZ3Zd6HLeBqEkmx1odWoHvleUgSjjluzJeDN+slKeF X-Gm-Gg: AR+sD11vspzEk13NTP8sXsdR2qlhdUNdyFVWEx4BDj4AXiPMAaeO2x8Z3bVzu3LjT7B Y6pG5bGE6sG5H/iJ02obvxC2Y6QbU+50UITZjJ4g9dU82z1oi+FIZKRTI9MIZjkOwAlXHQq43kw GM+nM1Chy83UpzDGzLKypDRDlh1CGTc580+EYMbQ50OzzItuYrMzPfPyXCMdWoAQk+bRnj44tqc N6Y4wCyJeFRasr+IXuxDa/HM3i+1GTdx81rJywMFARNOMscdg7jpDOP1huYU7ufXH4rgWbFyIeI mCMfwLroXO9fNQfpnREb2+dJDMagem1ODahcHtWmlOFnnJ7ds/k4p4KlwosY7j9GvdSH7wQFT/0 RM8lWz81oe+vhrlNX3BA0rcMS9VSc0kBv8q0wMNQytWAeMwuSJ4hKLrdMhX4ZohHnjoKxsld0Vf 3yWDw00nOMNMeogeyRGFFGQ9zugLYCTtepkRYE0yJGtS9DkbrV6Cs89X3CY12Eoyo6SChX5KPQr KwEHeo7ssK+7kyvDLpwAV+Oys4= X-Received: by 2002:a05:6402:d0e:b0:6a3:fee5:adc8 with SMTP id 4fb4d7f45d1cf-6a42eeb84dcmr12976866a12.0.1787519207688; Sun, 23 Aug 2026 14:06:47 -0700 (PDT) Received: from ?IPV6:2a02:a449:4071:0:32d0:42ff:fe10:6983? ([2a02:a449:4071:0:32d0:42ff:fe10:6983]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59e1ccf69sm5175122a12.25.2026.08.23.14.06.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Aug 2026 14:06:46 -0700 (PDT) Message-ID: Date: Sun, 23 Aug 2026 23:06:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1] drm: rockchip: add drm_plane_create_blend_mode_property To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , andy.yan@rock-chips.com Cc: hjc@rock-chips.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1ab6fb88-3b84-49b5-aa05-202a84edbd3d@gmail.com> <25031028.6Emhk5qWAg@diego> Content-Language: en-US, ar-EG From: Johan Jonker In-Reply-To: <25031028.6Emhk5qWAg@diego> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 8/23/26 21:19, Heiko Stübner wrote: > Hi Johan, > > Am Sonntag, 23. August 2026, 14:29:09 Mitteleuropäische Sommerzeit schrieb Johan Jonker: >> A validate_blend_mode_for_alpha_formats() function was added that >> fills the kernel log with warnings for Rockchip VOP version 1 SoCs. >> Add a drm_plane_create_blend_mode_property() function as fix. > > This is missing explanation on why PIXEL_NONE is the correct value. > > VOP2 seems to support all 3 blend modes? So a sentece explaining > the pixel_none value would be helpful. > > Hi, In the vop_plane_atomic_update() function there's a comment with win0 blend broken: /* * Blending win0 with the background color doesn't seem to work * correctly. We only get the background color, no matter the contents * of the win0 framebuffer. However, blending pre-multiplied color * with the default opaque black default background color is a no-op, * so we can just disable blending to get the correct result. */ In the function vop2_plane_init() there are these blends: unsigned int blend_caps = BIT(DRM_MODE_BLEND_PIXEL_NONE) | BIT(DRM_MODE_BLEND_PREMULTI) | BIT(DRM_MODE_BLEND_COVERAGE); My question: Could someone with more know-how tell us what VOP version 1 is capable of? Is there anything that needs to be set like in other drivers? For example: switch (pixel_blend_mode) { case DRM_MODE_BLEND_PREMULTI: break; case DRM_MODE_BLEND_COVERAGE: break; case DRM_MODE_BLEND_PIXEL_NONE: default: break; } If someone comes up with another solution/patch that's also fine, as long the kernel warnings are gone. Thanks! Johan > Heiko > >> Signed-off-by: Johan Jonker >> --- >> >> https://lore.kernel.org/all/20260526181700.25310-3-leandro.ribeiro@collabora.com/ >> --- >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> index 0090d8ff0c79..0bc5b606f021 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> @@ -1850,6 +1850,8 @@ static void vop_plane_add_properties(struct drm_plane *plane, >> if (flags) >> drm_plane_create_rotation_property(plane, DRM_MODE_ROTATE_0, >> DRM_MODE_ROTATE_0 | flags); >> + drm_plane_create_blend_mode_property(plane, >> + BIT(DRM_MODE_BLEND_PIXEL_NONE)); >> } >> >> static int vop_create_crtc(struct vop *vop) >> > > > >