From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C739377AB7 for ; Wed, 19 Aug 2026 05:15:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787116547; cv=none; b=DWCSJIJzqNcZUp2Y7376Yk2poZiBCbH1+H9ATU3US6mBFJVcTJOyp5jaYibjhJF3cOLDiMLnPk4OAn48xm7dop/12FN4ML8BRumc9Puc3/KJHmXwrkiy30v7TZJJI4WJ+VdJiXOtoghFZxvZ23lDLzT0sPHRpUVhgg6hKDbFUpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787116547; c=relaxed/simple; bh=UnkQv4kM8XuF78pBN3xPMkNYBRkSeUVmasVSJMrCfG0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hWODlzv1RA7Y0RoTio9S5Xz/VEPUzWy9/bzoONx7Lf4QNafRwUF2L1C0TQ7RZl552P/27V6Dpl/9bkslyCjl4+jjNZlW1frBzlagFcHjKTcbULlRamuoj17/4fRZpQJDBgA+OAgabb2nXVT0wgL/ndFHX98sH4cPvvwXa8DK894= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EIc0Nxig; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EIc0Nxig" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5b2a4359d16so674295e87.3 for ; Tue, 18 Aug 2026 22:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787116542; x=1787721342; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ynNMYlH2iVBR0QbDnzi1NN26jmaCTIwuPqyidD2cakg=; b=EIc0NxigAM02ibD75En1iIiNf/FzO+ek9XWYQrLu3J/MVi7fyJUos1jAcJ5yTqnTT8 dZjE3K3io4L+dqjNa/GqJOpCA/1ILme3Z1GUEBoikfEXCPFZz/4skKR8wPITSqb8QqoL qS7fmvjrl98pQczmY0mMdn9SonU+WRvEhQQZ7RB8V7NCEwDqk0Fbc3FOAq2ONsVMEv6p HhPHiMGvTTl//vRttrlTf1xVlsv6N/c1rNFO0Xy5Gt349HvwElGOIlUFsmSMG0WKYF80 gh/GbjGpzrqnFCHTf0eqWG4nMYRbxmbKSQNNR76J1YeK2TmUoUkXwUvK8faYvh/hG/rL MxXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787116542; x=1787721342; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ynNMYlH2iVBR0QbDnzi1NN26jmaCTIwuPqyidD2cakg=; b=ND25uxYOfHarmaQRzSeFq/RKX/ceumVgSn+K06r7b7gq2zMe4CL0r3yaXw4Q1/pKJZ a90g8mpdcYyOMGHD7ylyzdXdwo94eiYDnnDOgcDLDzXBknRLgDTj5O9hSWgct9txtAOg B0tQZ3bBDRlgnDzMy9BdNHPZBZ5qlHFxUdIhQQ5tV8Gu67/Jy/6ETRCnPcXQQr8nVeX9 WGXtUjn+MuWPx5kq4hwDmGDHlg+xNo+TA5gokoB3umEQAYu2iEdi3iycgHrCepl/53ii Y6+2zFyvkHby1V6UOAygOfDZxHMFNWt52huRmeYFxm3xYO46bF0fnlCwcgq74vbEmF1T GjOQ== X-Forwarded-Encrypted: i=1; AHgh+RqbNlDM8GgQegAoseRZxZJ3r1+xSP+qnmuEh+tXrpqBcbypUh5NafjQQjLK+ax0ciXuzt8WP3bVYIZmfmc=@vger.kernel.org X-Gm-Message-State: AOJu0YybFMnmYNZgqqzx0gnte1VyFDAyMXZLg8D/03C7KhyRv7DrgTtx FzkM4GMglhJcRnqlcl1PC2miiSwRCCApUgw8EGjUPKrIzv1317TcHSC3 X-Gm-Gg: AR+sD100dWQSa7NjU48l8BDaDbbtKnEBTIcBBkG0jBbFioQDDO7ITZM4pRco/KWvnjX DiFBMD7cGJi2af99Ioot6uAhzEI/l2UuEMr2C9yEM4s+0Z0vWaIsf+1RlTd9og9SHbdaDdpkclN yC0QXgXTG0ZMzz1q5MhjU8Ud0sjmg9mcbDifBuEBDiHaSwfjBt6ww6f3ocN9qPDWDU9S8NGQNTZ OBst1kmyG29c5uSyNUDYHtDo6noi8H58Mho/S1bbCCWM2J/qsGEEven1o+rar2ByydQV4G+Sar5 S6vmev3X18Szt+vrJw9CSlBXvl8UcZmkucgi+AiyS2d295tgIDhl+hrvlfUZHSwIItQmSU0lyW9 qgCX4mOFuf9hGrAeYEGomkRHujhWhzsNiw8U7S1wUc5mpGj6I27IPE9aw1vQNA00HeJrQhM9SCX Agjh8PJQT6G7cSeQBhj4Yp9egkRPZtCyCAFvr1gfbBY42rX3hGbWOFXorQKRAbcOvG1iF8WKKjX yZh/jonnPqhToFEbI55e1v2KqoTT3vObwNR4RoOgrR2aSaU/x+MtvE= X-Received: by 2002:a05:6512:3b1f:b0:5b2:f426:9c67 with SMTP id 2adb3069b0e04-5b478bd8b93mr488499e87.19.1787116541862; Tue, 18 Aug 2026 22:15:41 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a18a8e8579sm1510551fa.0.2026.08.18.22.15.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 22:15:40 -0700 (PDT) Message-ID: Date: Wed, 19 Aug 2026 08:15:40 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] iio: accel: kionix-kx022a: unify staging buffer and convert to iio_push_to_buffers_with_ts() To: Jonathan Cameron , Gabriel Rondon Cc: David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260818215122.52715-1-grondon@gmail.com> <20260819010900.7728cff8@jic23-huawei> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <20260819010900.7728cff8@jic23-huawei> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/08/2026 03:09, Jonathan Cameron wrote: > On Tue, 18 Aug 2026 22:51:20 +0100 > Gabriel Rondon wrote: > >> v1 was a single patch converting the two push sites to >> iio_push_to_buffers_with_ts(). Reviewing it, Jonathan pointed out that >> the driver carries two separate staging areas holding the same thing >> (buffer[8] and the scan struct), and asked to fold the cleanup into this >> set. >> >> So v2 is a two-patch series: patch 1 drops the redundant buffer and >> routes the one-shot read and the triggered handler through scan, and >> patch 2 does the deprecated-API conversion, now with a single buffer to >> push at both sites. >> >> Changes in v2: >> - New patch 1: drop buffer[8], use scan for the one-shot read and the >> triggered handler, move IIO_DMA_MINALIGN onto scan (Jonathan) >> - Patch 2 now pushes data->scan at both sites instead of data->buffer >> > Nice. All looks good to me, so I'll queue it up. > > Applied to the testing branch of iio.git which will be rebased on rc1 once > available. > > Note that there is plenty of time for additional feedback, tags or indeed > me to drop it again if someone spots something I missed. Ah, Jonathan was quick and efficient :) I'll drop my comments to 'nits' in order to not generate more work for Jonathan. Hence, acting on my comments is not required. -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~