mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	soc@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 1/4] gpio: sa1100: register software node for GPIO controller
Date: Thu, 29 Oct 2026 12:06:50 -0700	[thread overview]
Message-ID: <a23c924469bdccf3417141c904713a6a@gmail.com> (raw)
In-Reply-To: <8bc1c573-bd4f-4dfe-9d7b-8b17d386ada7@app.fastmail.com>

Hi Arnd, Guenter,

On Thu, Oct 29, 2026 at 10:26:05AM +0100, Arnd Bergmann wrote:
> On Thu, Oct 29, 2026, at 05:23, Guenter Roeck wrote:
> > With this patch in the tree, the qemu "collie" emulation no longer works.
> > There is no console output.
...
> Hopefully Dmitry can spot an obvious fix for the regression, otherwise
> a revert is probably best so we can leave collie working in the LTS
> kernel and not spend much work on that.

sa1100_init_gpio() runs during init_IRQ(), before driver_init() sets up
swnode_kset, so software_node_register() crashed dereferencing a NULL
kset pointer before the console came up.

Only the GPIO IRQ setup needs to happen in init_IRQ(), so I posted a fix
deferring the software node and gpiochip registration to
postcore_initcall (verified with qemu collie):

https://lore.kernel.org/r/20261029-sa1100-swnode-fix-v1-1-112f4d83d191@gmail.com

Thanks.

-- 
Dmitry

  reply	other threads:[~2026-10-29 19:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07  3:13 [PATCH 0/4] ARM: sa1100: convert gpio-keys to software nodes Dmitry Torokhov
2026-07-07  3:14 ` [PATCH 1/4] gpio: sa1100: register software node for GPIO controller Dmitry Torokhov
2026-10-29  4:23   ` Guenter Roeck
2026-10-29  9:26     ` Arnd Bergmann
2026-10-29 19:06       ` Dmitry Torokhov [this message]
2026-07-07  3:14 ` [PATCH 2/4] ARM: sa1100: assabet: convert gpio-keys to use software nodes Dmitry Torokhov
2026-07-07  3:14 ` [PATCH 3/4] ARM: sa1100: collie: " Dmitry Torokhov
2026-07-07  3:14 ` [PATCH 4/4] ARM: sa1100: h3xxx: " Dmitry Torokhov
2026-07-07  8:08 ` [PATCH 0/4] ARM: sa1100: convert gpio-keys to " Bartosz Golaszewski
2026-07-07  8:14   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a23c924469bdccf3417141c904713a6a@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=arnd@arndb.de \
    --cc=brgl@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linux@roeck-us.net \
    --cc=soc@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®