From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D98FEC433FE for ; Mon, 28 Mar 2022 13:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243189AbiC1N4j (ORCPT ); Mon, 28 Mar 2022 09:56:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233194AbiC1N4h (ORCPT ); Mon, 28 Mar 2022 09:56:37 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5263D3ED34; Mon, 28 Mar 2022 06:54:56 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 856811F42AAD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1648475695; bh=93dA8FqYNp/Lt0Zjhk8lbR0S/JZ+vwD2obtfNGwvT9k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KQMS29eMxg8jrJxNMnr1l3jR2gpWeys+qwiBVvwG9sKokh3/MdoMaow+vqOBWlLNl B8gaYSG5RrP3uRI6NW/7fOSDseJNzgYymCvrythI8PxI6Sh91JEnzBOhWDLtzgSUZc 9SJyLPFYulCwU+4cxVWr/j1zo+pWB61LilNV31K2ydtfj7rUZD/lc8mjWFYrbhDTl/ rqWkXmci9gLpTG9e5ZcUUD4EI7jCMoz58/U1Moho+yuqdrecQDZSfeLrRI67cGW99c S2SawVjwMzea5rQeLqt8PQdO4jkfqy/zo3koFbfRyO9hDVbzTovLwfUEOMIYsSsF6Z EiDKJPsG0ibbA== Message-ID: Date: Mon, 28 Mar 2022 15:54:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] PCI: mediatek: Update entries to distinguish MediaTek PCIe controller Content-Language: en-US To: Jianjun Wang , Lorenzo Pieralisi , Rob Herring , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas Cc: Ryder Lee , Matthias Brugger , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20220326032708.3626-1-jianjun.wang@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220326032708.3626-1-jianjun.wang@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 26/03/22 04:27, Jianjun Wang ha scritto: > Add model numbers in Kconfig and update driver name in > pcie-mediatek-gen3.c to distinguish the MediaTek PCIe controllers. > > Signed-off-by: Jianjun Wang > --- > drivers/pci/controller/Kconfig | 11 +++++++---- > drivers/pci/controller/pcie-mediatek-gen3.c | 12 ++++++------ > 2 files changed, 13 insertions(+), 10 deletions(-) > > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > index 601f2531ee91..dd7a2caf8da9 100644 > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -237,8 +237,11 @@ config PCIE_MEDIATEK > depends on OF > depends on PCI_MSI_IRQ_DOMAIN > help > - Say Y here if you want to enable PCIe controller support on > - MediaTek SoCs. > + Adds support for PCIe MAC controller for MediaTek SoCs. > + > + The following SoCs are supported for this PCIe controller: > + MT2701 and MT7623 with no MSI supported. > + MT2712, MT7622 and MT7629 support up to 32 MSI interrupt numbers. > > config PCIE_MEDIATEK_GEN3 > tristate "MediaTek Gen3 PCIe controller" > @@ -250,8 +253,8 @@ config PCIE_MEDIATEK_GEN3 > and support up to 256 MSI interrupt numbers for > multi-function devices. > > - Say Y here if you want to enable Gen3 PCIe controller support on > - MediaTek SoCs. > + The following SoCs are supported for this PCIe controller: > + MT8192 and MT8195. I agree with the pcie-mediatek-gen3 naming change, it's good to differentiate, but I don't think that updating the Kconfig description is a good idea. Everyone can get the list of supported SoCs by reading the dt-bindings for these drivers, so it's unnecessary to make a list of SoCs in Kconfig... this is also to avoid updating these entries everytime support for a new chip is added to the gen3 (or the other) driver. If nobody opposes to my proposal - please drop that description change. Regards, Angelo