From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BBD236AB54 for ; Tue, 24 Feb 2026 09:21:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771924889; cv=none; b=pZ5jsHCsJGTgIrAIZlvWoJymOuWgTpTGYvGUctGLRbbgIGR7s5cI/DBsisDYGPrEiPNacTXqzKFMKjZ6szfZZ/j/HM5abTvnkqkqssyDzO55hU20qCt1L34xfOAA88ZFEnNNjj1ZpvzrVvfvGnV6REcTWx/DPLGWzLSYPHdDzeU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771924889; c=relaxed/simple; bh=jXwh8WXoeDjlbdPz4Rcm22BPEMckOBRdrPA9rQpQSb8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YJPM0PT8BLPwVGcU0bV4SPO/9UAFRdbt8xq9OnHEsNOx2HaV4m9TKvFEFZTU95+2yUrRMJvVf57r74DpyJSFkk5MpEoar/RkIsnNTdTTl9AMI4ISXt7EGjRwweFzunY5ngJsy7muWFa0rnnI+PSSekyuMEEnPOyPPPAb6TQh21g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=X0UanHE2; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="X0UanHE2" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4837584120eso37036365e9.1 for ; Tue, 24 Feb 2026 01:21:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1771924886; x=1772529686; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=38Okx8vRRandsJJtqeebMqZpts+3JOrgQSEOj+ehCaw=; b=X0UanHE28iX8JxPSr0eENStreTFX8afs8PG5adlMZlmucIkaBSlEt5cuTRE62UnIQG wpATO2ni8+gVUKLn4EgUvSVicTkekJMf17WxwZP+qLmGxizrfderM8oYQPLEVvfJCmSU Jv0840d81WTCCUQVCkKknhRPS4G30Yhe9vX/J79jvQbnhw0UHo335aZ/PEPhpaTVB5d7 a0povbAN5COegsPaKJCuQx8JntlRolfAGqZkgpRpHuSfY4tzpYux6Xa19H3/SvkwOm10 Dvi6j6uX+PcJ+Z67K54sn1uzAZyaqLCsCMq0HYbHHMXS21v4n/LVngbhRUCjN61q8s2g 7Pjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771924886; x=1772529686; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=38Okx8vRRandsJJtqeebMqZpts+3JOrgQSEOj+ehCaw=; b=bTc4/oDUinXNGAlqVu0i53nEpZ73FlE64URQ9c/2zWu40gu/2TlLbe7XwJKJ8YogbZ ISvOf5ZOZ0PGbikQWu4RdsaK0mVmZW9RQZJuD1CdCCNihgt7Sa3L8mXpkPA7B/nDkxoT 68Y1ma7Lazbm56GJ09u8AGdmHYzJPm253Aqdkq8r4QMphSm+Ee6ATdaQPM9aaygbvbjQ QYZn/tZy+QT62v9jzcga9hJQqHOhe+32Fb+2mqgbQhk/Avnk7H8W6XX5UWCbyxbj4jkJ TEQgMio/rBJzk0LamBVY3b9es8Qj1DDYk9vhkKF6JaBwDnvGxBBNkvphNaiOCM4s2Z4J hyYw== X-Forwarded-Encrypted: i=1; AJvYcCXsp6orm1BfDDFvfdb7GdoF/F04HXxWLEefzITydQByn6mMkJhGIv4C9iEVnbaeDqyTCptjz04806tfOxg=@vger.kernel.org X-Gm-Message-State: AOJu0YzJLQ3+3UakMPy4HJ3mkoRxAB9OAYk0ZTfSlvItijzSdFbEq0ss C1IPGvv1NFwGOVNJyW5pXp61aRT3+KdFy80csib84sTJpgqq+lP0vpb2ijti4Vkviw== X-Gm-Gg: AZuq6aIFHreIT+fUjLT0mOD7xZNY9hATMX6362PamjU1v4wIzavpL/YQpy+dwZixoDH nBicm4dsQbSmPXMySmJJ7FUKNgLN8ENoGcX5NhuPs1GAd6USdYo2/AoXyiU9LcMnOZ96K82fod0 fdcp/lsRavLlKCKTvG55N//0tA0JWfqZoN78n3b02DehFCLEYt5AW28AFkX3cNdpw+blJMVqHn+ 4zCks1p79EZ+R8TdYNEaNCT3NH37aCSbZhTHD/L4PVx10LE6P03LChF26RVFO1iYstF2Rz42uTj WTX3lZBiH6IQHN+hplJq/GUOZVVYD9O1GqU2qf6d6BJbxoM8s1mQ3b5WzuThvzoaxGMXD+1YqH2 nmADmRusrWcvpgMd1CfECwmX0r2RbfbuYC3XqUTDdJ+SNpuD2Z7Eoyt3Squ54HjrXIlsT1qlxe4 bxnTHHPM2agyzGTlhpnURimtIcYG9RYI7M8eTJwulToCqvY8cRNJB/2Qkq/YWPt3kCpzIAnsv6q KZcOAprmbmeOWoZOBzZQbYHCQ== X-Received: by 2002:a05:600c:628d:b0:483:5a29:9678 with SMTP id 5b1f17b1804b1-483a95bd8a7mr203823555e9.2.1771924885711; Tue, 24 Feb 2026 01:21:25 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483b8195f50sm22777295e9.0.2026.02.24.01.21.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Feb 2026 01:21:25 -0800 (PST) Message-ID: Date: Tue, 24 Feb 2026 10:21:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/acpi-processor: fix _CST detection using undersized evaluation buffer To: "David Thomson (dt@linux.com)" Cc: boris.ostrovsky@oracle.com, sstabellini@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, jgross@suse.com References: <20260223195602.17122-1-dt@linux-mail.net> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24.02.2026 10:10, David Thomson (dt@linux.com) wrote: >> I understand you reflect original behavior in this regard, but why involve any >> ACPI function here at all when pblk is non-zero? I.e. why not swap the operands >> of && ? Object evaluation could have wanted side effects (in which case, >> however, some different change would be needed here), but checking for method >> presence surely hasn't. >> > You're right on both counts. The original evaluate_object() call at least had the appearance of wanting the result (even though buf was undersized and the result was never used). A pure presence check has no such pretense. Swapping the operands is the obvious improvement. I think dropping the _CST check entirely is also defensible since C-state support is confirmed when pblk is set. But I'm not certain there's no edge case where pblk is non-zero and _CST is also not present, so I'd defer to your judgement. > > Would you prefer: > a) if (pblk && acpi_has_method(handle, "_CST")) > b) just if (pblk) I don't think b) is correct, so a) please (albeit suitably adjusted to really only flip the operands from what your original patch had). Jan