mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denys Vlasenko <dvlasenk@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
	Brian Gerst <brgerst@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86, msr: Document AMD "tweak MSRs", use MSR_FnnH_NAME scheme for them
Date: Tue, 25 Apr 2017 18:48:47 +0200	[thread overview]
Message-ID: <a247e792-f7fc-84d6-bd5c-66116ee55d88@redhat.com> (raw)
In-Reply-To: <20170425162317.pfy6amlgnj2a6xgd@pd.tnic>

On 04/25/2017 06:23 PM, Borislav Petkov wrote:
> On Tue, Apr 25, 2017 at 06:15:23PM +0200, Denys Vlasenko wrote:
>> On 04/25/2017 06:06 PM, Borislav Petkov wrote:
>>> Pls no. Not every MSR for every family. Only the 4 which are actually
>>> being used. We can't hold in here the full 32-bit MSR space.
>>
>> The replacement of four define names is not the purpose
>> of the proposed patch.
>>
>> The patch was prompted by the realization that these particular MSRs
>> are so badly and inconsistently documented that it takes many hours
>> of work and requires reading of literally a dozen PDFs to figure out
>> what are their names, which CPUs have them, and what bits are known.
>
> They're all documented in the respective BKDGs or revision guides.

Yes. For some definition of "documented".

Let's say you are looking at all available documentation for Fam10h CPUs -
BKDG, Revision Guide, five volumes of APM, software optimization guide.
Eight documents.

If you read all of them, you can find exactly one mention that
MSR 0xC0011029 exists. It is mentioned by number.

As a reader of this documentation, can you find out what is it?
Does it have a name, at least?

You are right that kernel is not exactly the best place to store more info
about such things, but AMD probably won't accept my edits to their
documentation.

      reply	other threads:[~2017-04-25 16:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 15:27 Denys Vlasenko
2017-04-25 16:06 ` Borislav Petkov
2017-04-25 16:15   ` Denys Vlasenko
2017-04-25 16:23     ` Borislav Petkov
2017-04-25 16:48       ` Denys Vlasenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a247e792-f7fc-84d6-bd5c-66116ee55d88@redhat.com \
    --to=dvlasenk@redhat.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®