From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D85C285CBA for ; Sat, 14 Mar 2026 14:39:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773499148; cv=none; b=M8SawGKkFWVHvTEIpFNnrqxaGEGHtVuGuEgg2KtQG6tGQA2iZgYsqgu0pGuB5WpoIUIhMxZKGTAgnks8a9dfSCBgHePp4FU0o0t2jPDHVCr5K+gyaCoh8yTfO/eas0Mugs406dpwb9eQDBdzWMDUXDO2OdTXDxekcBVNWSbU9xo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773499148; c=relaxed/simple; bh=5M+8FF18btNiR/OXWuCMOHZwYvMZZMCmX9jXGsGAsUM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=awDbvJaL33tOcQfTX7KjBwGdmQpNW781mGRqMOxkaFdOOCIWgiNIBPx3RPxGPuU/xP+DHZQwNa7sGS48Ve5x/oO7YIqj/5iKyny38Ljb4It3kKPQ7/Zxnl1b2hr6ubufv5fM7EFrb4fH7GfVHO9lBBXX2g/g/ghyS84iM48z0Pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=MIOaTg7f; arc=none smtp.client-ip=209.85.160.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="MIOaTg7f" Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-4138136f02eso2229172fac.2 for ; Sat, 14 Mar 2026 07:39:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773499145; x=1774103945; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f30xM/Mb3048ZhnccFuHLAyII+0/eJw/DdO5W4q5nGM=; b=MIOaTg7fWAR5C4/7q4i1DiEjxFexoVTQ3GzXj8GT8+zCHWHGVMUPI3GOcyTjB2TG8j 6x90oQZExaRCGh1q0piZyccq6i8LhPs8qH8elO6srXUem9LVhafXxwSf3QjSzST1FpK1 l3JS5WujmUuwfDJ2ZeczclXEeNQbiaKfpZ3BAMb9D1IDZ9CqtSUEFrtf//8btdkiRJXL hLFl8t+r9VJXcMQ6bT9kgE2FlZC1bXXnoydT7YxMjD1inXLlWFtEDFI26C3cWOw4OqNs qPVLE//0zk1t4xiuR02hlbj2BzZ5LmDYYOlXftygCUAARe3SX4NlySJCSvfbH14l6OUx Nm7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773499145; x=1774103945; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f30xM/Mb3048ZhnccFuHLAyII+0/eJw/DdO5W4q5nGM=; b=QHRaM8weNjoAkHiI9mT8JMSB40qUyDi/xKDxNhcj2QaLVoyRtQXH4v90IXoJl2o39w M0ruyBZE6gYkjKJB8qWFhrttNrxOQFw/ahrCyDGoe7pFzV+x+Rv548VnZcBakDsGx79e OBY/cRa1YE5apHOUQCBncvB8er8ZUKrl3n6YiZjhg8upnHZeom0HeOdWmPof6wMEbSgO 9uu6LW8gOfFt/gtTtHaqR1x2Sfob09TdNS8k3BmU1aPZ6+cfx3KbfSh1lFDAbs2etLiW nUof9bbIXLvIfM4cYY20EJyTIsXFCJ2Nh3V0Mv/dMgoZjI/fcxUD9hiYFTq6Z0q7vCw/ wHRw== X-Forwarded-Encrypted: i=1; AJvYcCUsROyqxdMMtj/J29Fx/oZctk7y7fkq94l/AH6Ss/6EEkTwB1pGjr+YCpFzKr3iS54POd+EBefIlSxKtDA=@vger.kernel.org X-Gm-Message-State: AOJu0YxB5Ns5MW9L6OQ8DBX9AyqZFNnIvqgpkA8jDWr/tvr+RWHJoEup WBfdp9PsW+ljqCH3UBZNDhXwR0WBEydNWN23QA5hw8IVEWyGe+1CQ5ab5+uqjX2DpPE= X-Gm-Gg: ATEYQzy+uFJwE88gx2U7kjMApSBTgyTrpp9SbHkYVwV/IcF9A/HLFcnSFiNnxDQTn+V QmRE0ATxvLXNCeD6uipO9sDTKCu9QHm/AQwq9P3aex3ZbE9TP6ZO6EbFGOlet/nhDWVPOMTy3N7 lM6HkWlNxLdccFuz8WN4PqS/SV7+2fF1+IPUpgRfBCqMmfHZ7IgJelNPsLGlBeQKcY8x9bCgQDq m+eOzqywzZeiaJ1OckrtdZi93Q4twNUhxbyXmeLA0DRZWeDZyk9qlSEdoXCgb0CCFksMXKpgHd9 C3BGbY4mTpkkkiGifuIxJDqZNSfLq9pvtDpl5DUxybUgiSKQIUsPAIfW5M3DBRoJvsmT0UO+Nfg +KAyoKLnWbL+0RwQFrrP0bB84ZMOxk+zjV7Jozv6AGnwYVFRvdbBpgrsy+U9z7R84N26NFTKl5K oTYOB6HsDUITHlxgluNG0r8pRMqPEfTrsWS/xRp3qBlTxBg/AGLkrvZuHpHyQZWkuqQib2y1SFn A== X-Received: by 2002:a05:6870:8318:b0:36e:8381:db00 with SMTP id 586e51a60fabf-417b902b7eemr3936827fac.9.1773499145404; Sat, 14 Mar 2026 07:39:05 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:14a9:db6c:e65a:4287? ([2600:8803:e7e4:500:14a9:db6c:e65a:4287]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4177e6c7885sm10415806fac.17.2026.03.14.07.39.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Mar 2026 07:39:04 -0700 (PDT) Message-ID: Date: Sat, 14 Mar 2026 09:39:03 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] iio: proximity: add driver for ST VL53L1X ToF sensor To: Sirat , Andy Shevchenko Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org References: <20260311224044.21480-1-email@sirat.me> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/12/26 10:12 AM, Sirat wrote: > On Thu, Mar 12, 2026 at 8:28 PM Andy Shevchenko > wrote: >> >> On Thu, Mar 12, 2026 at 04:40:35AM +0600, Siratul Islam wrote: > ... >>> --- >>> Changes in v3: >>> - Merge DT binding into existing st,vl53l0x.yaml (per Krzysztof). >>> - Use "reset-gpios" in the binding but xshut_gpio in the driver since that's the actual pin name. >> >> But why is it "reset" in the bindings? If it's a power rail or enable pin, why >> not call it as a such in the bindings? The connection on PCB level is different story. >> > In v2, I actually used a separate st,vl53l1x.yaml binding with > `xshut-gpios` and a required `vdd-supply`. > But Krzysztof pointed out that they share the same pins so the > existing st,vl53l0x.yaml should suffice, > using reset as the xshut pin. > > I think a choice has to be made here: > 1. Either I use the st,vl53l0x.yaml binding with wrong pin name and > optional vdd-supply to not break existing code. > 2. Or use a separate binding st,vl53l1x.yaml with 1. correct pin name, > and 2. require vdd-supply We can modify the existing binding to make the supply required based on the compatible. allOf: # Technically supply is required to power device, but we keep it # optional for "st,vl53l0x" for backwards compatibility. - if: not: properties: compatible: const: "st,vl53l0x" then: required: vdd-supply And we can add a description to reset-gpios to explain that it is actually the XSHUT pin. > > Krzysztof, do you have a preference on how we should handle this? >> >>