From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 889B43FBB7D for ; Thu, 30 Jul 2026 09:36:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785404216; cv=none; b=G0C0T0JavOVmvB5YCdqQLeLFj7jjVMZY2PaqJaZoNWh/IYp8grmCFJVIS4DfaNxPgg0uOhDcSwpkTCTSzDYaAbVQ50fPX/MCv1fTsPOJlgAIyffvD8ZF7n2beZXu05oVk1bTMV7Ru+q/whtue6odWY7OdeSzVZ5uVNiUURm7vhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785404216; c=relaxed/simple; bh=3ig9HyOBwUAQGnS+nGUpC+LS7V7HWg7iPJ6suT5Ougs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mHh10XzDqCsCQboMPNyQJAoNRE5YwFl5A6XcQPqCAaNu36qdvzIaFcxq5YstBFzItZ7PTsdDwyAXS+rC07oSzkOx3+9bVk9zSqaXA14gQx+qDYoVMlhCHtHTyTLy3ZtgvtTS7wSuDzHxQf2jcf+JLeNSniKREDXaMQ5WSSxT634= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AljOxfXi; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AljOxfXi" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-495590dde14so18637305e9.0 for ; Thu, 30 Jul 2026 02:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1785404214; x=1786009014; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YenH0EkAp38hPwj0HJf+phj+YdBWGT+XzdFAusXbYyg=; b=AljOxfXi7M6djbXYt1BqJ0E+TVCRIM0p2z20b1y9Izuo0IX9Tk9T97kT9O8e7Mqelv CsCdAXnGlv5urJ4fzVkV2HhzJ/nj1tkmyT8QPU7HPmWBh9FYYEpzJ0w791TuTNx0umlb uxGCxRmsjZh/Xo/Nm79HuvB6IefQdtlWerXIeFBKKE65uizCCgjCKEpInDr3eG8zPtnI MxXikzCRgglF0n/XYT0ghwun179Wb7ngfRrmNNz94OA8aTeav5lOkD8ASM2z/XoGn35V g2s2MDM85+i3jy2t0CDx7eCoaFHfvDJHXbopQuUkywxenF9dnMQROFDHNT49q/QtSX58 uwrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785404214; x=1786009014; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YenH0EkAp38hPwj0HJf+phj+YdBWGT+XzdFAusXbYyg=; b=X5VB0wp6WFv9QfwZqqsWQjKnDfHGjW2aCoh0wXRNtHqWDw/FsC5q8CJlEMNwrdCdmO rNPZXDcOQmM9luCtGjat4KGa/jf8Hgw17g2PxPvalBijJwW4qwtAQbuwUWPkG0ugw53W Bu6Yb9yc+6TLEkCXrpEfys5hAl66cgAeOOBbTq7PyHkSOPH4ZDCKAangHG3eZAbxjVcs POAoDnS3i+sNDNnJoyEeRBAKP+vd1Jx5RsI/OX1O/al3qosFd9cQlT1NEr0tVFBoLun4 +I/cMYsSbHSlZPYbxpoKTNOACf5oQ9qnc/g54kmmua2If5tBnlZBAmZUQ+TU3JT2wH9a VT9Q== X-Forwarded-Encrypted: i=1; AHgh+Rr8G5/K+WBS9cTRdKOVEDCvCq08K19GIsSmHTwZVa+KNEtDFcRm5AW1OfeNt58Hd7jB0ZpjpN0n7paE+hw=@vger.kernel.org X-Gm-Message-State: AOJu0YxZgf4B3rIxcnFU+RRXW6qrY/HbMcbeeOZkR6peNVQzi/hW54+I HRRScu+5M6OSdEiyfWNL06AzH93+eoi5KErW0O8iUuWpBQePrb1FpOY8/GKcsChX9DY= X-Gm-Gg: AR+sD13uWpraoHkXt87/VrUfZQZGzLXD9md9eAdqKdqGcMT592oCQbT63xFy4Kl6Ppe 1udniAf/1sl8f1hBXQFYSb3+ewG1JUMf7A+xZ9wTGJeQmjyCMvaUK9P3ikuh+KyfQg4PSdHP4Gs tO3xkYq/FTTQht1A47ee7Vu3UC5uXcgW625EIOOCv2xkvAUyqfpnG9eeeNY/fjNxgr4uFD8Hgxj XFqBkwobL0gZt3DkmacJinl6nBoNlFr/5Wd2GAmQoZWwLW7Ti+I2okMPZ1Uj7MhI9w5FxGUufw4 iUQlx8OvqCSRW4TiaMxLGBdjprh71lUDjKx1tHFn3SDNDu8LTzqDmYzCLQHaToP+yhwxKfCpdBc WzbN4c4q+siSjhliGATNZSbRZ6cMgfyqiBu0ZP2G+i/9J3vVNgArwIoShvPz7Fl/a4aXt3+z4Us 6RX7nfa1NWLo2YX3anXH5L3rgxaiCPfBTdZvDkjVE85Eo+JoUzeGJ6fwbCF41cyZ9CYZSSt/nm X-Received: by 2002:a05:600c:8b2e:b0:496:c967:5f9c with SMTP id 5b1f17b1804b1-49800ec19d5mr28488325e9.33.1785404213726; Thu, 30 Jul 2026 02:36:53 -0700 (PDT) Received: from [192.168.0.101] ([109.77.38.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fc88e3d7fsm4722046f8f.9.2026.07.30.02.36.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 02:36:53 -0700 (PDT) Message-ID: Date: Thu, 30 Jul 2026 10:36:52 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] media: qcom: camss: Report hardware version via media controller To: Loic Poulain , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260730-camss-version-v3-0-74a87302dd9f@oss.qualcomm.com> <20260730-camss-version-v3-4-74a87302dd9f@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: <20260730-camss-version-v3-4-74a87302dd9f@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/07/2026 10:24, Loic Poulain wrote: > +static int camss_read_version(struct camss *camss) > +{ > + u32 hw_version; > + int ret; > + > + if (!camss->top_base || !camss->res->pm_clks[0]) > + return 0; > + > + ret = pm_runtime_resume_and_get(camss->dev); > + if (ret < 0) > + return ret; > + > + hw_version = readl_relaxed(camss->top_base + CAMSS_HW_VERSION); I'm virtually sure this fails on !PM_CLK --- bod