From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750890AbdALV6R (ORCPT ); Thu, 12 Jan 2017 16:58:17 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:26812 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbdALV6P (ORCPT ); Thu, 12 Jan 2017 16:58:15 -0500 Subject: Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc To: David Miller , eric.dumazet@gmail.com References: <131ec7b7-5b74-2545-8bf7-92812443a876@oracle.com> <20170112.161852.1469407145449781531.davem@davemloft.net> <1484256990.13165.6.camel@edumazet-glaptop3.roam.corp.google.com> <20170112.164731.720625943370044951.davem@davemloft.net> Cc: rob.gardner@oracle.com, netdev@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org From: Shannon Nelson Organization: Oracle Corporation Message-ID: Date: Thu, 12 Jan 2017 13:58:10 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170112.164731.720625943370044951.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/12/2017 1:47 PM, David Miller wrote: > From: Eric Dumazet > Date: Thu, 12 Jan 2017 13:36:30 -0800 > >> val should be an union, so that proper alignment is enforced by one >> member. > > Sure, annotating the type so that it is aligned correctly makes > sense. > ... and we should change the offending pointer assignment as well. I can use this and respin a v2 if we're happy with this solution. sln