From: baomingtong001@208suo.com
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
ave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Fwd: [PATCH] KVM: x86: remove unneeded variable
Date: Wed, 14 Jun 2023 11:30:16 +0800 [thread overview]
Message-ID: <a2510fb15553a294236646321cf1b3a4@208suo.com> (raw)
In-Reply-To: <20230614032736.13264-1-luojianhong@cdjrlc.com>
fix the following coccicheck warning:
arch/x86/kvm/emulate.c:1315:5-7: Unneeded variable: "rc".Return
"X86EMUL_CONTINUE".
arch/x86/kvm/emulate.c:4559:5-7: Unneeded variable: "rc".Return
"X86EMUL_CONTINUE".
arch/x86/kvm/emulate.c:1180:5-7: Unneeded variable: "rc".Return
"X86EMUL_CONTINUE".
Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
arch/x86/kvm/emulate.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 936a397a08cd..7a7e29e4e203 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -1177,7 +1177,6 @@ static int decode_modrm(struct x86_emulate_ctxt
*ctxt,
{
u8 sib;
int index_reg, base_reg, scale;
- int rc = X86EMUL_CONTINUE;
ulong modrm_ea = 0;
ctxt->modrm_reg = ((ctxt->rex_prefix << 1) & 8); /* REX.R */
@@ -1199,16 +1198,16 @@ static int decode_modrm(struct x86_emulate_ctxt
*ctxt,
op->bytes = 16;
op->addr.xmm = ctxt->modrm_rm;
kvm_read_sse_reg(ctxt->modrm_rm, &op->vec_val);
- return rc;
+ return X86EMUL_CONTINUE;
}
if (ctxt->d & Mmx) {
op->type = OP_MM;
op->bytes = 8;
op->addr.mm = ctxt->modrm_rm & 7;
- return rc;
+ return X86EMUL_CONTINUE;
}
fetch_register_operand(op);
- return rc;
+ return X86EMUL_CONTINUE;
}
op->type = OP_MEM;
@@ -1306,13 +1305,12 @@ static int decode_modrm(struct x86_emulate_ctxt
*ctxt,
ctxt->memop.addr.mem.ea = (u32)ctxt->memop.addr.mem.ea;
done:
- return rc;
+ return X86EMUL_CONTINUE;
}
static int decode_abs(struct x86_emulate_ctxt *ctxt,
struct operand *op)
{
- int rc = X86EMUL_CONTINUE;
op->type = OP_MEM;
switch (ctxt->ad_bytes) {
@@ -1327,7 +1325,7 @@ static int decode_abs(struct x86_emulate_ctxt
*ctxt,
break;
}
done:
- return rc;
+ return X86EMUL_CONTINUE;
}
static void fetch_bit_operand(struct x86_emulate_ctxt *ctxt)
@@ -4556,7 +4554,6 @@ static unsigned imm_size(struct x86_emulate_ctxt
*ctxt)
static int decode_imm(struct x86_emulate_ctxt *ctxt, struct operand
*op,
unsigned size, bool sign_extension)
{
- int rc = X86EMUL_CONTINUE;
op->type = OP_IMM;
op->bytes = size;
@@ -4590,7 +4587,7 @@ static int decode_imm(struct x86_emulate_ctxt
*ctxt, struct operand *op,
}
}
done:
- return rc;
+ return X86EMUL_CONTINUE;
}
static int decode_operand(struct x86_emulate_ctxt *ctxt, struct operand
*op,
next parent reply other threads:[~2023-06-14 3:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230614032736.13264-1-luojianhong@cdjrlc.com>
2023-06-14 3:30 ` baomingtong001 [this message]
2023-06-14 19:18 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2510fb15553a294236646321cf1b3a4@208suo.com \
--to=baomingtong001@208suo.com \
--cc=ave.hansen@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®