From: Andrew Lunn <andrew@lunn.ch>
To: Meghana Malladi <m-malladi@ti.com>
Cc: elfring@users.sourceforge.net, haokexin@gmail.com,
vadim.fedorenko@linux.dev, jacob.e.keller@intel.com,
pabeni@redhat.com, kuba@kernel.org, edumazet@kernel.org,
davem@davemloft.net, andrew+netdev@lunn.ch,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com,
danishanwar@ti.com
Subject: Re: [PATCH net] net: ti: icssg-prueth: Fix switch mode for offload and non-offload cases
Date: Wed, 30 Sep 2026 14:57:16 +0200 [thread overview]
Message-ID: <a2517fd1-3e22-4483-839d-4aa5d9f5f995@lunn.ch> (raw)
In-Reply-To: <20260930124356.3083743-1-m-malladi@ti.com>
On Wed, Sep 30, 2026 at 06:13:56PM +0530, Meghana Malladi wrote:
> Non-offloaded switch mode is failing to forward packets. Following fixes
> ensure smooth operation of switch mode in both offload and non-offload cases:
>
> - Fix NULL dereference in icssg_enable_fw_offload() when second emac
> slot is uninitialized during first port open
> - Set port_vlan on both emacs when bridge is formed; previously only
> the second port was set, causing TX stalls in switch offload mode
> - Track UC/MC flooding state and restore it after firmware restart in
> non-offload bridge mode; restart cleared IFF_PROMISC-driven flooding,
> breaking unicast forwarding across bridge ports
> - Defer emac_adjust_link() to after prueth_emac_start() so R30 FORWARD
> commands don't time out with PRU not running, leaving stale R30 values
> that caused prueth_emac_restart() to fail in non-offload bridge mode
A bullet point list in the commit message suggests there should be a
patch series of patches, not one patch. You want small, obviously
correct patches with good commit messages.
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2026-09-30 12:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 12:43 Meghana Malladi
2026-09-30 12:50 ` netdev-bot+sinfo
2026-09-30 12:57 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2517fd1-3e22-4483-839d-4aa5d9f5f995@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=elfring@users.sourceforge.net \
--cc=haokexin@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-malladi@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=srk@ti.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®