From: Robin Murphy <robin.murphy@arm.com>
To: Angus Chen <angus.chen@jaguarmicro.com>,
joro@8bytes.org, will@kernel.org
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux.dev
Subject: Re: [PATCH] iommu: Distinguish between sw-msi and msi
Date: Mon, 21 Oct 2024 12:58:55 +0100 [thread overview]
Message-ID: <a25451b8-b898-4354-acd3-2826a340f9fe@arm.com> (raw)
In-Reply-To: <20241021113448.1894-1-angus.chen@jaguarmicro.com>
On 2024-10-21 12:34 pm, Angus Chen wrote:
> iommu_group_resv_type_string use the same string of IOMMU_RESV_MSI
> and IOMMU_RESV_SW_MSI, Make a distinction for these.
Why? What in userspace needs to know the exact details of how the kernel
and the underlying hardware are routing MSIs?
Thanks,
Robin.
> Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> ---
> drivers/iommu/iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 83c8e617a2c5..8a2bbb5c4a91 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -84,7 +84,7 @@ static const char * const iommu_group_resv_type_string[] = {
> [IOMMU_RESV_DIRECT_RELAXABLE] = "direct-relaxable",
> [IOMMU_RESV_RESERVED] = "reserved",
> [IOMMU_RESV_MSI] = "msi",
> - [IOMMU_RESV_SW_MSI] = "msi",
> + [IOMMU_RESV_SW_MSI] = "sw-msi",
> };
>
> #define IOMMU_CMD_LINE_DMA_API BIT(0)
next prev parent reply other threads:[~2024-10-21 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 11:34 Angus Chen
2024-10-21 11:58 ` Robin Murphy [this message]
2024-10-22 12:02 ` Angus Chen
2024-10-22 12:30 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a25451b8-b898-4354-acd3-2826a340f9fe@arm.com \
--to=robin.murphy@arm.com \
--cc=angus.chen@jaguarmicro.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®