Re: kernel/sched/ext.c:3701:16: error: 'struct task_group' has no member named 'idle'

[Yu Liao <liaoyu15@huawei.com>]

Hi,

On 2024/9/22 9:02, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   88264981f2082248e892a706b2c5004650faac54
> commit: 8195136669661fdfe54e9a8923c33b31c92fc1da sched_ext: Add cgroup support
> date:   2 weeks ago
> config: sparc-randconfig-002-20240922 (https://download.01.org/0day-ci/archive/20240922/202409220859.UiCAoFOW-lkp@intel.com/config)
> compiler: sparc-linux-gcc (GCC) 14.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240922/202409220859.UiCAoFOW-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202409220859.UiCAoFOW-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from kernel/sched/build_policy.c:63:
>    kernel/sched/ext.c: In function 'scx_cgroup_warn_missing_idle':
>>> kernel/sched/ext.c:3701:16: error: 'struct task_group' has no member named 'idle'
>     3701 |         if (!tg->idle)
>          |                ^~
>    kernel/sched/ext.c: In function 'scx_ops_disable_workfn':
>    kernel/sched/ext.c:4455:17: error: implicit declaration of function 'stack_trace_print'; did you mean 'event_trace_printk'? [-Wimplicit-function-declaration]
>     4455 |                 stack_trace_print(ei->bt, ei->bt_len, 2);
>          |                 ^~~~~~~~~~~~~~~~~
>          |                 event_trace_printk
>    kernel/sched/ext.c: In function 'scx_ops_exit_kind':
>    kernel/sched/ext.c:4834:30: error: implicit declaration of function 'stack_trace_save'; did you mean 'stack_tracer_enable'? [-Wimplicit-function-declaration]
>     4834 |                 ei->bt_len = stack_trace_save(ei->bt, SCX_EXIT_BT_LEN, 1);
>          |                              ^~~~~~~~~~~~~~~~
>          |                              stack_tracer_enable
> --
>    kernel/sched/core.c: In function 'cpu_idle_read_s64':
>>> kernel/sched/core.c:9626:27: error: 'struct task_group' has no member named 'idle'
>     9626 |         return css_tg(css)->idle;
>          |                           ^~
>    kernel/sched/core.c: In function 'cpu_idle_write_s64':
>>> kernel/sched/core.c:9634:15: error: implicit declaration of function 'sched_group_set_idle'; did you mean 'scx_group_set_idle'? [-Wimplicit-function-declaration]
>     9634 |         ret = sched_group_set_idle(css_tg(css), idle);
>          |               ^~~~~~~~~~~~~~~~~~~~
>          |               scx_group_set_idle
>    kernel/sched/core.c: In function 'cpu_idle_read_s64':
>    kernel/sched/core.c:9627:1: warning: control reaches end of non-void function [-Wreturn-type]
>     9627 | }
>          | ^
> 

I post a RFC PATCH series:
https://lore.kernel.org/all/20240923135431.2440320-1-liaoyu15@huawei.com/T/#t

Best regards,
Yu
> 
> vim +3701 kernel/sched/ext.c
> 
>   3694	
>   3695	static void scx_cgroup_warn_missing_idle(struct task_group *tg)
>   3696	{
>   3697		if (scx_ops_enable_state() == SCX_OPS_DISABLED ||
>   3698		    cgroup_warned_missing_idle)
>   3699			return;
>   3700	
>> 3701		if (!tg->idle)
>   3702			return;
>   3703	
>   3704		pr_warn("sched_ext: \"%s\" does not implement cgroup cpu.idle\n",
>   3705			scx_ops.name);
>   3706		cgroup_warned_missing_idle = true;
>   3707	}
>   3708	
>