From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] timer-of: handle of_irq_get() result correctly
Date: Mon, 17 Jul 2017 20:14:04 +0300 [thread overview]
Message-ID: <a2561b39-019a-e859-499d-6d21dcd882dd@cogentembedded.com> (raw)
In-Reply-To: <20170716195609.570376795@cogentembedded.com>
Hello!
On 07/16/2017 10:55 PM, Sergei Shtylyov wrote:
> of_irq_get_byname() may return a negative error number as well as 0 on
> failure, while timer_irq_init() only checks for 0, blithely continuing with
> the call to request_[percpu_]irq() -- those functions expect *unsigned int*,
> so would probably fail anyway when a large IRQ number resulting from a
> conversion of a negative error number is passed to them... This, however,
> is incorrect behavior -- error number is not IRQ number.
>
> Fileter out the negative error numbers, complain, and return them to the
Oops, a typo. And the subject should have of_irq_get_byname(). I'll repost.
> timer_irq_init()'s callers...
>
> Fixes: dc11bae78529 ("clocksource/drivers: Add timer-of common init routine")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
[...]
MBR, Sergei
prev parent reply other threads:[~2017-07-17 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-16 19:55 Sergei Shtylyov
2017-07-17 17:14 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2561b39-019a-e859-499d-6d21dcd882dd@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®