From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA75EC7EE25 for ; Sat, 10 Jun 2023 03:11:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230243AbjFJDLV (ORCPT ); Fri, 9 Jun 2023 23:11:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbjFJDLR (ORCPT ); Fri, 9 Jun 2023 23:11:17 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3424F3A89 for ; Fri, 9 Jun 2023 20:11:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=Sb/UB5/DjsCS2B8f+KFn47kYIziWm7qZBTkSBfzgFSs=; b=i3RZaGvShmlC9poF+PWtgMvYRh CZBXULNRMjgpJhLE8Qku316RXG6YZaoV2PRdMiMg3RhXWQeDtEmnExT3l0bhzmmL+eguT+9wBKbA4 wIqmRVibzgX5Fhr/TK5aThYp74VJGJbYFQcbInJs3jqM+08WxX3EpTfvyR5QdNhjJjPlqum8Je+0u XPhI2rZRCoqmRUKzScf+pWLfZmq0M+j8A7jg5VqviUprEuHCTrAPlS8QIf9Uy5gPjiSKPZ206RxJD MzkyQt/c3XEozkux4Rv9jsmOl7p1+lPPXzOnvqT59VbaN64aocH0GeE0j74rjDlXlEgxSQWjJ9ImS ygl3xEqA==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q7p0W-00F3SV-1y; Sat, 10 Jun 2023 03:11:16 +0000 Message-ID: Date: Fri, 9 Jun 2023 20:11:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: linux-kernel@vger.kernel.org, Kumar Gala , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org References: <20230516152854.22465-1-rdunlap@infradead.org> <20230516185400.urjy6y3kh4grbagt@pali> From: Randy Dunlap In-Reply-To: <20230516185400.urjy6y3kh4grbagt@pali> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi-- On 5/16/23 11:54, Pali Rohár wrote: > On Tuesday 16 May 2023 08:28:54 Randy Dunlap wrote: >> In a randconfig with CONFIG_SERIAL_CPM=m and >> CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error: >> ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined! >> >> Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when >> SERIAL_CPM=y. >> >> Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.") >> Signed-off-by: Randy Dunlap >> Cc: Scott Wood >> Cc: Kumar Gala >> Cc: "Pali Rohár" >> Cc: Michael Ellerman >> Cc: Nicholas Piggin >> Cc: Christophe Leroy >> Cc: linuxppc-dev@lists.ozlabs.org > > Looks good, > > Reviewed-by: Pali Rohár I'm still seeing this build error in linux-next even with other (PPC) CPM patches applied. > >> --- >> arch/powerpc/Kconfig.debug | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug >> --- a/arch/powerpc/Kconfig.debug >> +++ b/arch/powerpc/Kconfig.debug >> @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x >> >> config PPC_EARLY_DEBUG_CPM >> bool "Early serial debugging for Freescale CPM-based serial ports" >> - depends on SERIAL_CPM >> + depends on SERIAL_CPM=y >> help >> Select this to enable early debugging for Freescale chips >> using a CPM-based serial port. This assumes that the bootwrapper -- ~Randy