From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 645B4C282DD for ; Wed, 8 Jan 2020 21:28:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D419206DA for ; Wed, 8 Jan 2020 21:28:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bSxTH+eF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726902AbgAHV2H (ORCPT ); Wed, 8 Jan 2020 16:28:07 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:44254 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725446AbgAHV2G (ORCPT ); Wed, 8 Jan 2020 16:28:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578518885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PDndyIMuf+SGBEdpoWnLHWGwmjrUEAzXRO3SpvATPL0=; b=bSxTH+eFoXprbPqFqggbi3I4IHLHPvJ/HThc1pxORpL+QTax/OEk8KABLdPDkll9d7oklU 1OB1G8siIiLjzrkTUu/joW4WGg8J37ZQW5xW/n96+qWAuV/D9x2L70sz/zSQouwBI9TNnP bomAG5cGzjobRRSWMslf5R306g+CamM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-dStVFU0HPOeWpx54NiZpYw-1; Wed, 08 Jan 2020 16:28:02 -0500 X-MC-Unique: dStVFU0HPOeWpx54NiZpYw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 32852800D48; Wed, 8 Jan 2020 21:28:00 +0000 (UTC) Received: from emilne (unknown [10.18.25.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F3607C3AD; Wed, 8 Jan 2020 21:27:56 +0000 (UTC) Message-ID: Subject: Re: [resend v1 5/5] drivers/scsi/sd.c: Convert to use disk_set_capacity From: "Ewan D. Milne" To: "Martin K. Petersen" Cc: James Bottomley , axboe@kernel.dk, Chaitanya.Kulkarni@wdc.com, mst@redhat.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, ssomesh@amazon.com, Balbir Singh , hch@lst.de Date: Wed, 08 Jan 2020 16:27:55 -0500 In-Reply-To: References: <20200102075315.22652-1-sblbir@amazon.com> <20200102075315.22652-6-sblbir@amazon.com> <1578369479.3251.31.camel@linux.ibm.com> <1eb9d796f81fffbb0bfe90bff8460bcda34cb04d.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-01-07 at 21:59 -0500, Martin K. Petersen wrote: > Ewan, > > > Yes, there are some storage arrays that refuse a READ CAPACITY > > command in certain ALUA states so you can't get the new capacity > > anyway. > > Yep. And some devices will temporarily return a capacity of > 0xFFFFFFFF... If we were to trigger a filesystem resize, the results > would be disastrous. > > > It might be nice to improve this, though, there are some cases now > > where we set the capacity to zero when we revalidate and can't get the > > value. > > If you have a test case, let's fix it. > This happens with NVMe fabric devices, I thought. I'll check.