From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750995AbdGYH50 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Jul 2017 03:57:26 -0400
Received: from mail1.bemta5.messagelabs.com ([195.245.231.140]:51758 "EHLO
        mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1750872AbdGYH5V (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Jul 2017 03:57:21 -0400
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLKsWRWlGSWpSXmKPExsVyeL7SP917P8s
  iDZ4uEbM4f/cQs8WTA+2MFnPOt7BY/Hp3hN1i1dSdLBYL25awWFzeNYfN4tgCMYtZR/YzOXB6
  bFl5k8lj56y77B47d3xm8ljcN5nVo/+vgceVjXOZPD5vkgtgj2LNzEvKr0hgzXjftYm54C5Lx
  Yt1Z9kaGF8ydzFycQgJrGWUeH7rEROEs4RR4unR6yxdjJwcwgKBEi3XjjGCJEQEGpgkPux6ww
  aSEBKokPh28iYziM0mYCyxa/pmJhCbV8BO4sPHY2BxFgFViXUnN7CD2KIC4RL7v19jhqgRlDg
  58wnYAk4BW4krr6+A9TILWEjMnH+eEcIWl7j1ZD5UXF5i+9s5zBB7NST2dnYB9XJwSADFzx0o
  AglLCMRJbFr7gnkCo+AsJBtmIZk6C8nUWUimLmBkWcWoXpxaVJZapGukl1SUmZ5RkpuYmaNra
  GCql5taXJyYnpqTmFSsl5yfu4kRGFUMQLCD8fsfp0OMkhxMSqK86bvKIoX4kvJTKjMSizPii0
  pzUosPMcpwcChJ8DIBo1RIsCg1PbUiLTMHGN8waQkOHiURXlmQNG9xQWJucWY6ROoUoy5H04c
  tX5iEWPLy81KlxHlzfwAVCYAUZZTmwY2ApZpLjLJSwryMQEcJ8RSkFuVmlqDKv2IU52BUEuZd
  BzKFJzOvBG7TK6AjmICOmDOjFOSIkkSElFQDY2YTU+Sce1a5Zzat2tlurjwzlvd4r4ys7heuE
  u3lFrK7ki0nrtikGRnW7BeepXQ7dulbL64avWSWiIq6RN3/d8/qnwqc+3sTf9mPzKy5sxXP3L
  HW+bWBjf/2uTajpbMKZ51NbJz9Pi7rhfIPW+Gz5utyL6cwXllwyq3Mem6E24V0c5cm1h/7lVi
  KMxINtZiLihMBJ8cRMTADAAA=
X-Env-Sender: Egil.Hjelmeland@zenitel.com
X-Msg-Ref: server-2.tower-180.messagelabs.com!1500969438!103195538!1
X-Originating-IP: [195.159.34.254]
X-StarScan-Received: 
X-StarScan-Version: 9.4.25; banners=zenitel.com,-,-
X-VirusChecked: Checked
Subject: Re: [PATCH 13/13] net: dsa: lan9303: lan9303_port_mdb_del remove port
 0
To: Florian Fainelli <f.fainelli@gmail.com>, <corbet@lwn.net>,
        <andrew@lunn.ch>, <vivien.didelot@savoirfairelinux.com>,
        <davem@davemloft.net>, <kernel@pengutronix.de>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>
References: <3bf6b19359cc40939b2e075635ed55d2@nooslMX1.zenitelcss.com>
 <42090826-7498-4d90-f265-a7cf65a9e236@gmail.com>
From: Egil Hjelmeland <egil.hjelmeland@zenitel.com>
Message-ID: <a267bd6d-a9c8-2ce0-ea1c-393f6e9e2df1@zenitel.com>
Date: Tue, 25 Jul 2017 09:57:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <42090826-7498-4d90-f265-a7cf65a9e236@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.5.202.90]
X-ClientProxiedBy: nooslMX1.zenitelcss.com (10.5.2.91) To
 nooslMX1.zenitelcss.com (10.5.2.91)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24. juli 2017 18:57, Florian Fainelli wrote:
> On 07/20/2017 06:57 AM, Egil Hjelmeland wrote:
>> Workaround for dsa_switch_mdb_add adding CPU port to group,
>> but forgetting to remove it:
>>
> Should not we move this logic one layer above into DSA then such that
> insertions and removals are strictly symmetrical in which and how many
> ports are targeted?
> 

Agree. I included the patch more as a bug report. I will remove it in
patch v2. I don't really feel competent to fix the issue in DSA. It is
probably better if you DSA people look at it. I do suspect DSA need
to do more bookkeeping?

Egil

DISCLAIMER:
This e-mail may contain confidential and privileged material for the sole use of the intended recipient. Any review, use, distribution or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive for the recipient), please contact the sender by reply e-mail and delete all copies of this message.