From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from iad-out-005.esa.us-east-1.outbound.mail-perimeter.amazon.com (iad-out-005.esa.us-east-1.outbound.mail-perimeter.amazon.com [3.211.80.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EE413DA5B1; Fri, 10 Apr 2026 15:27:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=3.211.80.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775834849; cv=none; b=DPH4baxWBUmGYgDQxV4E4xh6BdMVpArpXKISJqQ88cEM2IYgQM0LOU7k9ZGYz7s28dxKUuqipAZGpOqQbeS4+WzMlFqUk2AYQk9Wey+BSmkxWlrjWVX+yZDFxtSru3iTCAYAmnxphNQKc97YN2ShqI5BPU0vELrHcKJG9lel2uI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775834849; c=relaxed/simple; bh=VD6hSMKAlWaNvMymuZsjqsKTSi8tjdTg4KxPRjZC4Qc=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=fF+9hUzTNTcB3uZjpwuSqn1DfdL3NTk3xeKULZ9qJA+gywW2042stxnb1YPliQ9l07mRco/601Vb0HnekzHNJ6LJS5jB3X2+N80ckpL5RayCn53IMssVRlbWasQROKluCUtwajcj8fYQauPrlVwCOTEgeaHTe86dyFsHE8vVu+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.uk; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=My+gKh/W; arc=none smtp.client-ip=3.211.80.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="My+gKh/W" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1775834847; x=1807370847; h=message-id:date:mime-version:reply-to:subject:to:cc: references:from:in-reply-to:content-transfer-encoding; bh=rovGhSsMqDjdKRria4qsooPUUeVYimq/a+x4dfkE5PU=; b=My+gKh/W9vydsRad2QU1Hm+zad3YSwMn1KMiAmuVgaeNHOMTobjhLFjY rzeZkcNE+OxkUlGbJBOiKHeiv1iDdjkvxIeLEixvAyHDVCbYKDWfqwV3N yCkRqhv0DtK2IFHfbe4UTQid/SDi2lVj99ppKHW3IMj3A6q+EztgwQCZS +GUocFZkL5Rm1Y/S0lSI0CtxpW9DiavEqM/Uyq2qJCTqwsEqBKQtnsxZv htWJwvyQ5NjXo/+1nkReqSpKiPd+d5lgJTvsKj1miH0ZlsTco79g4BTOW Mj7inLu9C1r9OJh+W4RkzWZZ4OFNLK269W36/lTe7blnpjbeK5/L90mRH w==; X-CSE-ConnectionGUID: 2g/AnlwpR3uYQPrfjosQTg== X-CSE-MsgGUID: Qj5tzU7pQg+kFw9g6MP9xA== X-IronPort-AV: E=Sophos;i="6.23,171,1770595200"; d="scan'208";a="15966566" Received: from ip-10-4-22-235.ec2.internal (HELO smtpout.naws.us-east-1.prod.farcaster.email.amazon.dev) ([10.4.22.235]) by internal-iad-out-005.esa.us-east-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2026 15:27:23 +0000 Received: from EX19MTAUEA001.ant.amazon.com [72.21.196.67:10936] by smtpin.naws.us-east-1.prod.farcaster.email.amazon.dev [10.0.46.155:2525] with esmtp (Farcaster) id 0adabb76-9e17-4c0c-bcfb-c40d0e8bf47b; Fri, 10 Apr 2026 15:27:22 +0000 (UTC) X-Farcaster-Flow-ID: 0adabb76-9e17-4c0c-bcfb-c40d0e8bf47b Received: from EX19D027UEC003.ant.amazon.com (10.252.137.250) by EX19MTAUEA001.ant.amazon.com (10.252.134.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 10 Apr 2026 15:27:22 +0000 Received: from [192.168.12.97] (10.106.82.30) by EX19D027UEC003.ant.amazon.com (10.252.137.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 10 Apr 2026 15:27:09 +0000 Message-ID: Date: Fri, 10 Apr 2026 16:27:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Subject: Re: [PATCH v11 04/16] mm/gup: drop secretmem optimization from gup_fast_folio_allowed To: "David Hildenbrand (Arm)" , "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kernel@xen0n.name" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-pm@vger.kernel.org" CC: "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@kernel.org" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "lorenzo.stoakes@oracle.com" , "vbabka@kernel.org" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "skhan@linuxfoundation.org" , "riel@surriel.com" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "ackerleytng@google.com" , "yosry@kernel.org" , "ajones@ventanamicro.com" , "maobibo@loongson.cn" , "tabba@google.com" , "prsampat@amd.com" , "wu.fei9@sanechips.com.cn" , "mlevitsk@redhat.com" , "jmattson@google.com" , "jthoughton@google.com" , "agordeev@linux.ibm.com" , "alex@ghiti.fr" , "aou@eecs.berkeley.edu" , "borntraeger@linux.ibm.com" , "chenhuacai@kernel.org" , "dev.jain@arm.com" , "gor@linux.ibm.com" , "hca@linux.ibm.com" , "palmer@dabbelt.com" , "pjw@kernel.org" , "shijie@os.amperecomputing.com" , "svens@linux.ibm.com" , "thuth@redhat.com" , "wyihan@google.com" , "yang@os.amperecomputing.com" , "Jonathan.Cameron@huawei.com" , "Liam.Howlett@oracle.com" , "urezki@gmail.com" , "zhengqi.arch@bytedance.com" , "gerald.schaefer@linux.ibm.com" , "jiayuan.chen@shopee.com" , "lenb@kernel.org" , "osalvador@suse.de" , "pavel@kernel.org" , "rafael@kernel.org" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" , Vlastimil Babka , Dan Williams , Alistair Popple References: <20260317141031.514-1-kalyazin@amazon.com> <20260317141031.514-5-kalyazin@amazon.com> <76f14d3e-c8fb-4380-9d12-2375f199b53f@kernel.org> Content-Language: en-US From: Nikita Kalyazin Autocrypt: addr=kalyazin@amazon.com; keydata= xjMEY+ZIvRYJKwYBBAHaRw8BAQdA9FwYskD/5BFmiiTgktstviS9svHeszG2JfIkUqjxf+/N JU5pa2l0YSBLYWx5YXppbiA8a2FseWF6aW5AYW1hem9uLmNvbT7CjwQTFggANxYhBGhhGDEy BjLQwD9FsK+SyiCpmmTzBQJp2NfjBQkGQlIzAhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQr5LK IKmaZPPNDAEAvsw8vEWj8ArWQ1QJNufjrvobU/cE8MLKdBxbSE8CyZQA/0BldKxNAtAwG4qw wCLxsZ5vBL3Zkh/PdvtFCj/VGscGzjgEY+ZIvRIKKwYBBAGXVQEFAQEHQCqd7/nb2tb36vZt ubg1iBLCSDctMlKHsQTp7wCnEc4RAwEIB8J+BBgWCAAmFiEEaGEYMTIGMtDAP0Wwr5LKIKma ZPMFAmnY1+MFCQZCUjMCGwwACgkQr5LKIKmaZPPQKgD/f3FtERbJ+LYHLSG/ZbLNAOLngUlQ qo5VfIyJOzeLzC0BAP2PIUFIHo7vmia/PXEmT+ve4c5rx+EkH/Dx1GRpjWoI In-Reply-To: <76f14d3e-c8fb-4380-9d12-2375f199b53f@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EX19D006EUA001.ant.amazon.com (10.252.50.148) To EX19D027UEC003.ant.amazon.com (10.252.137.250) On 23/03/2026 18:31, David Hildenbrand (Arm) wrote: > On 3/17/26 15:11, Kalyazin, Nikita wrote: >> From: Patrick Roy >> >> This drops an optimization in gup_fast_folio_allowed() where >> secretmem_mapping() was only called if CONFIG_SECRETMEM=y. secretmem is >> enabled by default since commit b758fe6df50d ("mm/secretmem: make it on >> by default"), so the secretmem check did not actually end up elided in >> most cases anymore anyway. >> >> This is in preparation of the generalization of handling mappings where >> direct map entries of folios are set to not present. Currently, >> mappings that match this description are secretmem mappings >> (memfd_secret()). Later, some guest_memfd configurations will also fall >> into this category. >> >> Signed-off-by: Patrick Roy >> Acked-by: Vlastimil Babka >> Acked-by: David Hildenbrand (Red Hat) >> Signed-off-by: Nikita Kalyazin >> --- >> mm/gup.c | 11 +---------- >> 1 file changed, 1 insertion(+), 10 deletions(-) >> >> diff --git a/mm/gup.c b/mm/gup.c >> index 8e7dc2c6ee73..5856d35be385 100644 >> --- a/mm/gup.c >> +++ b/mm/gup.c >> @@ -2739,7 +2739,6 @@ static bool gup_fast_folio_allowed(struct folio *folio, unsigned int flags) >> { >> bool reject_file_backed = false; >> struct address_space *mapping; >> - bool check_secretmem = false; >> unsigned long mapping_flags; >> >> /* >> @@ -2751,14 +2750,6 @@ static bool gup_fast_folio_allowed(struct folio *folio, unsigned int flags) >> reject_file_backed = true; >> >> /* We hold a folio reference, so we can safely access folio fields. */ >> - >> - /* secretmem folios are always order-0 folios. */ >> - if (IS_ENABLED(CONFIG_SECRETMEM) && !folio_test_large(folio)) >> - check_secretmem = true; >> - >> - if (!reject_file_backed && !check_secretmem) >> - return true; >> - > > The AI review says that this will force all small folios through the > mapping check (which we obviously need later :) ). > > It brings up two cases where page->mapping is not set up: > > 1) ZONE_DEVICE pages (like Device DAX and PCI P2PDMA) > > 2) large shmem folios in the swap cache > > > 2) doesn't make sense, because the folio cannot be mapped in user space > when that happens. > > I am also skeptical about 1), especially as large folios are also > supported for device dax and would be problematic here. > __dev_dax_pte_fault() clearly sets folio->mapping through dax_set_mapping(). > > > If 1) is ever a case we could allow them by checking for > folio_is_zone_device(). But I am not sure if that is really required. > Sounds weird. I went ahead and added a check for folio_is_zone_device(). > > > -- > Cheers, > > David