From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754251AbdA0IFN (ORCPT <rfc822;w@1wt.eu>);
        Fri, 27 Jan 2017 03:05:13 -0500
Received: from mx2.suse.de ([195.135.220.15]:42657 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754178AbdA0IFM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Jan 2017 03:05:12 -0500
Subject: Re: [Xen-devel] [PATCH v2] xen, input: try to read screen resolution
 for xen-kbdfront
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
        linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
        xen-devel@lists.xenproject.org
References: <20170127071239.913-1-jgross@suse.com>
 <5cbb25fa-2dee-f82f-e656-bc733c67c398@gmail.com>
Cc: dmitry.torokhov@gmail.com
From: Juergen Gross <jgross@suse.com>
Message-ID: <a27287e1-463e-c91b-5a0f-512baf08ef95@suse.com>
Date: Fri, 27 Jan 2017 08:46:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <5cbb25fa-2dee-f82f-e656-bc733c67c398@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 27/01/17 08:21, Oleksandr Andrushchenko wrote:
> On 01/27/2017 09:12 AM, Juergen Gross wrote:
>> Instead of using the default resolution of 800*600 for the pointing
>> device of xen-kbdfront try to read the resolution of the (virtual)
>> framebuffer device. Use the default as fallback only.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> V2: get framebuffer resolution only if CONFIG_FB (Dmitry Torokhov)
>> ---
>>   drivers/input/misc/xen-kbdfront.c | 15 ++++++++++++---
>>   1 file changed, 12 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/input/misc/xen-kbdfront.c
>> b/drivers/input/misc/xen-kbdfront.c
>> index 3900875..3aae9b4 100644
>> --- a/drivers/input/misc/xen-kbdfront.c
>> +++ b/drivers/input/misc/xen-kbdfront.c
>> @@ -16,6 +16,7 @@
>>   #include <linux/kernel.h>
>>   #include <linux/errno.h>
>>   #include <linux/module.h>
>> +#include <linux/fb.h>
>>   #include <linux/input.h>
>>   #include <linux/slab.h>
>>   @@ -108,7 +109,7 @@ static irqreturn_t input_handler(int rq, void
>> *dev_id)
>>   static int xenkbd_probe(struct xenbus_device *dev,
>>                     const struct xenbus_device_id *id)
>>   {
>> -    int ret, i;
>> +    int ret, i, width, height;
>>       unsigned int abs;
>>       struct xenkbd_info *info;
>>       struct input_dev *kbd, *ptr;
>> @@ -173,9 +174,17 @@ static int xenkbd_probe(struct xenbus_device *dev,
>>       ptr->id.product = 0xfffe;
>>         if (abs) {
>> +        width = XENFB_WIDTH;
>> +        height = XENFB_HEIGHT;
>> +#ifdef CONFIG_FB
>> +        if (registered_fb[0]) {
> This still will not help if FB gets registered after kbd+ptr

Hmm, so you think I should add a call to fb_register_client() to get
events for new registered framebuffer devices?

This would probably work. I'll have a try.


Thanks,

Juergen