mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xiaofan Chen <xiaofanc@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: usbutils 0.82 release
Date: Fri, 8 May 2009 14:40:45 +0800	[thread overview]
Message-ID: <a276da400905072340j6130615bu3ef524be5bd48143@mail.gmail.com> (raw)
In-Reply-To: <20090508040101.GC31689@kroah.com>

On Fri, May 8, 2009 at 12:01 PM, Greg KH <greg@kroah.com> wrote:
> On Thu, May 07, 2009 at 07:51:23PM +0800, Xiaofan Chen wrote:
>> Not sure if this is a real problem or not. There is a compiler warning
>> for gcc 4.4.0.
>>
>> gcc -DHAVE_CONFIG_H -I.   -DDATADIR=\"/usr/share\"   -g -O2 -MT
>> lsusb-names.o -MD -MP -MF .deps/lsusb-names.Tpo -c -o lsusb-names.o
>> `test -f 'names.c' || echo './'`names.c
>> names.c: In function ‘names_init’:
>> names.c:803: warning: assignment makes pointer from integer without a cast
>
> Care to provide a patch for this?

To be honest, I do not know the reason of the warning. It looks fine to me
but I am not a real programmer.

In fact, I tried version 0.73 and there is no warning there and the file name.c
is the same between 0.73 and 0.81/0.82.

For 0.73:
[mcuee@myhost usbutils-0.73]$ make
make  all-am
make[1]: Entering directory `/home/mcuee/Desktop/build/usbutils/usbutils-0.73'
if gcc -DHAVE_CONFIG_H -I. -I. -I.  -DUSBIDS_DIR='"/usr/local/share"'
-Wall -W -Wunused -g -O2 -MT lsusb.o -MD -MP -MF ".deps/lsusb.Tpo" -c
-o lsusb.o lsusb.c; \
	then mv -f ".deps/lsusb.Tpo" ".deps/lsusb.Po"; else rm -f
".deps/lsusb.Tpo"; exit 1; fi
lsusb.c: In function ‘do_wireless’:
lsusb.c:2648: warning: unused parameter ‘fd’
if gcc -DHAVE_CONFIG_H -I. -I. -I.  -DUSBIDS_DIR='"/usr/local/share"'
-Wall -W -Wunused -g -O2 -MT names.o -MD -MP -MF ".deps/names.Tpo" -c
-o names.o names.c; \
	then mv -f ".deps/names.Tpo" ".deps/names.Po"; else rm -f
".deps/names.Tpo"; exit 1; fi
if gcc -DHAVE_CONFIG_H -I. -I. -I.  -DUSBIDS_DIR='"/usr/local/share"'
-Wall -W -Wunused -g -O2 -MT devtree.o -MD -MP -MF ".deps/devtree.Tpo"
-c -o devtree.o devtree.c; \
	then mv -f ".deps/devtree.Tpo" ".deps/devtree.Po"; else rm -f
".deps/devtree.Tpo"; exit 1; fi
if gcc -DHAVE_CONFIG_H -I. -I. -I.  -DUSBIDS_DIR='"/usr/local/share"'
-Wall -W -Wunused -g -O2 -MT usbmisc.o -MD -MP -MF ".deps/usbmisc.Tpo"
-c -o usbmisc.o usbmisc.c; \
	then mv -f ".deps/usbmisc.Tpo" ".deps/usbmisc.Po"; else rm -f
".deps/usbmisc.Tpo"; exit 1; fi
gcc -Wall -W -Wunused -g -O2   -o lsusb  lsusb.o names.o devtree.o
usbmisc.o  -lz -lusb
make[1]: Leaving directory `/home/mcuee/Desktop/build/usbutils/usbutils-0.73'


-- 
Xiaofan http://mcuee.blogspot.com

  reply	other threads:[~2009-05-08  6:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06 22:24 Greg KH
2009-05-07 11:51 ` Xiaofan Chen
2009-05-08  4:01   ` Greg KH
2009-05-08  6:40     ` Xiaofan Chen [this message]
2009-05-08 12:24       ` Xiaofan Chen
2009-05-08 12:59         ` Xiaofan Chen
2009-05-08 15:22 ` Xiaofan Chen
2009-05-09  4:55   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a276da400905072340j6130615bu3ef524be5bd48143@mail.gmail.com \
    --to=xiaofanc@gmail.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®