From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AAC43033FA for ; Tue, 20 Jan 2026 10:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768903539; cv=none; b=bAIQdrBnK6Rwktjq8DChTIv4vJY1FtImWMw87O7TmlwnxB2AYSjEA5UeEjRduK86fEdEjAQfBKy4LLp2yybEN0ec4KVeELozrZqOnXa24iEMETCcv68eMYp4pcz82LvbkcrDVbKZP0Km9XaIay/V9QK6bVGjkCp/k+Qy2RydUjU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768903539; c=relaxed/simple; bh=s9Db6hnd+tq7fewLpdNWptLw0uJIGOyxuVnvykQWJAs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=N1PhkqtVAUMjWUyxcU0cU8kesV2PoXXmZ1uOTMnEulOefIE6LYSpKOpCvI/rU+2Po/tTSGw7mUeOenbaeBlZVvUKjjGGqJcMayMTFgEtH6/ta0v0kItjf4X7O1uIo/HlvlKmUHbtfHAxyG3P5Wvb8G26r7EfnG6K0xAaPbAnkT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=M8+xN+Bk; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=t1tvz+5p; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M8+xN+Bk"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="t1tvz+5p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768903536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=s9Db6hnd+tq7fewLpdNWptLw0uJIGOyxuVnvykQWJAs=; b=M8+xN+Bkc/G4LTHq1VNL6/Hex0GykjKmeZg9luu2MSbZrIYe4qSaoayOdGuRF5TOZJpAXP 8CvnIVBZvQi0NH4X4c0Jqffp1wlOvl6IPTU9QrT7P3/jf5kFg/7WXbsx/a/5ozq7gNAeQY kLBShfCf/kW+jag2abX5ZoWxNsEHivI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-oNjCdc6mPiu4rHkeS1Tr0g-1; Tue, 20 Jan 2026 05:05:35 -0500 X-MC-Unique: oNjCdc6mPiu4rHkeS1Tr0g-1 X-Mimecast-MFC-AGG-ID: oNjCdc6mPiu4rHkeS1Tr0g_1768903534 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-434302283dcso3889717f8f.0 for ; Tue, 20 Jan 2026 02:05:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768903534; x=1769508334; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=s9Db6hnd+tq7fewLpdNWptLw0uJIGOyxuVnvykQWJAs=; b=t1tvz+5pv9wXorRZkwdYWRb31417h3vTbKr00J6aQMEKJaoaBDeWaKe4/evh6a5Wn2 OewIHv7utt9rRDDpa47Vgi98ddb2KPw6MpYXCUfW2DwXTufn4DBUtDJfqcz8H2XYmKvW AgAiUbGng0wErd86VDTZD4uq1KWPotuJnQlQh6mccLstCxCS5otwMWnrQzKhyaemD7a/ GWntDW4VsLNgxu5TZRPoPS0MpXywaG+qqREFujPgw1NJj7xCLxsVzrM1zw1Aa044nY8K jbO/TL78hUBNGTyCCRxXlXwa1cC6kOLvz2AvbUNCgajMfLcfMVffdUTWSovaPUibQK9H 4xvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768903534; x=1769508334; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s9Db6hnd+tq7fewLpdNWptLw0uJIGOyxuVnvykQWJAs=; b=qn4gEsTu6HyQWYJs+5iHn5MoCyv/4sybZBTL92ZKQXmJSLaq/if8dCxxZSlfrp3JjP yYlTaJHS/vTII98+8mUZzmarShucQgn+R/sVETI53BtsCJXhw42m4Mh9vhhAVSGKZ6CO A8QkKvQDZeHL8Gy5q1sy7qJcZU5F31yfzxWrwHhpJboSshNnqkKsbti8stauIf0tvGt/ N5TGUGs2uxV73cVIEe2WmsaSePHkVqTsFBQORqgH4XH1Y3CQC7Ho9c3Y7P1VBIvbt6by RxSxHP28eY8RhHf4Sj4+jVPqjWIieMcTy/S4F2qPXCE78nNvG+4JjIksCuE2NPx8c9NW t0lQ== X-Forwarded-Encrypted: i=1; AJvYcCUJh0L1sWVwv7s3nFOqnXgvRRyCSY23Li18K8u3aHCecCEVb9tepXda8OauYtAHw5jT6Mimr/pmSuXvcII=@vger.kernel.org X-Gm-Message-State: AOJu0Yyke7OtHFPRHGxWwrMsDa0XW2B792MWSMV/spD8Gn0BF0RMiUKp eYQZlffvSd6sa7g7I2AKhjKfW1KQ4m4QvW3aBm+d3jzXKCqnqe3lFOhRq38C8Klvri47U5JHTJR VMg7wMWfFyho5lAbQiBCAqQ+XeG850PaRSIaFrkZZ9D16+uN3XdjsJCd2Up/SrdAinw== X-Gm-Gg: AZuq6aLt8CRKJp7A7gzHTarewxI07NAbKoTgQnS07fLuaTDFpREsmeuIewF2RmSEU/D AEAF7HP9zbC/mw0i2RO3gZ7xmnVttvRWwqdJ8B6lPLBD1Hr5R6ojpLUPXFULj/KJLcAh7WAesmM 2gnrg5KFMH9jG8pbC20m8deKMClZ+Se+6wPa9zyF/9W8s8qwlAjxEygQX3wFeI3j/YB7U3NUdnJ mJ+f0k/+UvS7Ciu5bgUQ0SahdJW+uSlpq8AESp8r14ksOARD3HqHrfdJgxovvuNI5jV042POAV9 HccrhFPCqOBK93dUp84VlDdrvwlm6Kn2z0o25rVfwJG2T1VhBwr2xMD3JheMU6ka9Wd6E0DoY9H PQtHki7jffvMxO8CTNY0bYvBl2/GxHn1YerwWdihtHxmRKmMrf2vqqO7G7g0sr697qsSDReOqx3 3FSkz56fro X-Received: by 2002:a05:6000:40cc:b0:432:8651:4070 with SMTP id ffacd0b85a97d-4358fed143dmr1830438f8f.10.1768903533858; Tue, 20 Jan 2026 02:05:33 -0800 (PST) X-Received: by 2002:a05:6000:40cc:b0:432:8651:4070 with SMTP id ffacd0b85a97d-4358fed143dmr1830398f8f.10.1768903533296; Tue, 20 Jan 2026 02:05:33 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356997ed8bsm28863121f8f.36.2026.01.20.02.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 02:05:33 -0800 (PST) Message-ID: Subject: Re: [PATCH 02/26] rv/rvgen: remove bare except clauses in generator From: Gabriele Monaco To: Wander Lairson Costa Cc: Steven Rostedt , Nam Cao , open list , "open list:RUNTIME VERIFICATION (RV)" Date: Tue, 20 Jan 2026 11:05:31 +0100 In-Reply-To: <20260119205601.105821-3-wander@redhat.com> References: <20260119205601.105821-1-wander@redhat.com> <20260119205601.105821-3-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote: > Remove bare except clauses from the generator module that were > catching all exceptions including KeyboardInterrupt and SystemExit. > This follows the same exception handling improvements made in the > previous AutomataError commit and addresses PEP 8 violations. >=20 > The bare except clause in __create_directory was silently catching > and ignoring all errors after printing a message, which could mask > serious issues. For __write_file, the bare except created a critical > bug where the file variable could remain undefined if open() failed, > causing a NameError when attempting to write to or close the file. >=20 > These methods now let OSError propagate naturally, allowing callers > to handle file system errors appropriately. This provides clearer > error reporting and allows Python's exception handling to show > complete stack traces with proper error types and locations. >=20 > Signed-off-by: Wander Lairson Costa Looks good to me, thanks! Reviewed-by: Gabriele Monaco > --- > =C2=A0tools/verification/rvgen/rvgen/generator.py | 9 +-------- > =C2=A01 file changed, 1 insertion(+), 8 deletions(-) >=20 > diff --git a/tools/verification/rvgen/rvgen/generator.py > b/tools/verification/rvgen/rvgen/generator.py > index a7bee6b1ea70c..af1662e2c20a7 100644 > --- a/tools/verification/rvgen/rvgen/generator.py > +++ b/tools/verification/rvgen/rvgen/generator.py > @@ -198,17 +198,10 @@ obj-$(CONFIG_RV_MON_%s) +=3D monitors/%s/%s.o > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = os.mkdir(path) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 except FileExistsError: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = return > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 except: > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 print= ("Fail creating the output dir: %s" % self.name) > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 def __write_file(self, file_name, content): > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 try: > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 file = =3D open(file_name, 'w') > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 except: > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 print= ("Fail writing to file: %s" % file_name) > - > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 file =3D open(file_name, 'w') > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 file.write(content) > - > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 file.close() > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 def _create_file(self, file_name, content):