From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A225377A9F for ; Mon, 24 Aug 2026 05:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787548300; cv=none; b=ZlJ5LFktJz+ya4xmDUa6ipCmIYPyIGv4n8glqMe1r+xtnhbr2MeCW6xMofoQRI7PVmkK3Uz/IZffp8rjfBmEShAN6UV+n14E35pj/XSZwJyvv0qy8yA12O4uZ+2vqxpc1Bi/K+iIvOlXlbiaLGKtuLWvu+8CrMewBa+6z75pMO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787548300; c=relaxed/simple; bh=4+VlY2D06jTHF5E2ToUSpDtRWNDTChr5h+Bq0QmCch8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tb44ZgAsihUvZqt9KMaI6NGmShZz23W59P7oxqXywr1vBHeWQw3bAszyX6oUbzn4nif3NEc73/oRXR1hEGRDm6celFi9X1qZsDHia9DGvXTEVij2Sgy9jAe2OzXOVlPYP7NxRNofnqUWCOqZvTAUvaO1pZafoi7x38cr3bEbNTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=C752QwXk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=es1yIvyO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="C752QwXk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="es1yIvyO" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67O0lcuH417806 for ; Mon, 24 Aug 2026 05:11:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4+VlY2D06jTHF5E2ToUSpDtRWNDTChr5h+Bq0QmCch8=; b=C752QwXkN5e9Jl0g oMZCfLm7ekaP237CqxsFn4SHeEKMqrw1iybu504nplBNW6AdHzhYKtpQzm+KoCex xlq6SDWG14eeYwXaYZbiwKDk4AWN10KCBzHt5/wicQ7cL+AyQlPC6iXtJW7uPyU6 jmrEtbOsYWYz+K+HSzteBX6yp6XE5eNSRGX2B+ku9r8CeZxN97ovc1plDzfNIc14 UN3XQnJIjn3f48HS3rainwTdWdqMWwJzhOiG4BScPvDUM02Oat8eaHDorfjRO1O1 OOCQjkLDriruU7zOt7XiaHsiBB0KyWDqhZH744ThHWsaTXHDLCsWbrZ0jlLEd/Dt +DpsSA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g74xhd8s4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 05:11:38 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ccb6823efcso24717555ad.0 for ; Sun, 23 Aug 2026 22:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787548298; x=1788153098; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=4+VlY2D06jTHF5E2ToUSpDtRWNDTChr5h+Bq0QmCch8=; b=es1yIvyOGpij6NoH2xF/0upD3RQBMJeEUPk+00wAk/I/e7NyLDdg96R+51qmVyG/oS uhnR18Hh+zu5khcjpmaJ4MvA0PkEpJ6BSfkg88/Yy+A+ynN6IYJgYCHPXaGW+u/OzMfC VZ0lEa1BRoboxB9VgCZW+8NAzqDv62sLHsomXiYFRW6l59Kngr3OSkPiRTuulym7XWiM gViUPgeHckK3MN2pe5PvcMVXm6/w6L0KyuzdDXTkm5KACH8DaIIbKe6BKlPQBU8P9Y/3 U7mwvcFdA3nhv2b7JnMLmIq8L8YXJQT8TPfqsAu9p6YAeihKsSFd3J0qEB7ylp6iqrsk mD+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787548298; x=1788153098; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4+VlY2D06jTHF5E2ToUSpDtRWNDTChr5h+Bq0QmCch8=; b=BB6wjceGgjpS3u1qmFS/o2niIh2kqIMqzB0gc0MvSfJ/Oqo6hARat4BDxQpFY6i4Ot c+VOuLOkkzo4xTO4e2Kdjw7AAavv6cVI6gYeGD27u/7yFkVQIwWPScv4LSmC9FKRU10V rI+rGsUDNfi49L34d6icchz3PGPMZteDU+ObvNbbmQlNcDYHYFPRGYIphhDvcyAJDxOa SSP0QpMz7xgmrVc0sciyqbOslRLd/Jfzl7MrTQH5R1RxrRktyI9Xb1yoOOfjtZZWOx9a 87p7JUf5Cu7tuA41T8aqD2mOQce9nqf0pBgfOO0tm/6JYbNgSNfWOb1WNRU+F4OSzssh eyjw== X-Forwarded-Encrypted: i=1; AHgh+RrrjB975Q5yeQPSiKtJVkQ8fO4Jv/02/6cZw13ECxmm2WRnOb/3gQ67IiXdxNgCJZMijSoU6czHvsVI77A=@vger.kernel.org X-Gm-Message-State: AFuF++m+Fd4x7KJ2ZdAmWTkEN6ZfmDjvE0JVGdd751oTus7DSId22iva g1AkZfvXApF7933+MzqMbe1lbK+e+7yugb7LPPv2VzUWl1S5Agm6aMeLuxeABAf1l/W4SZmTSA/ nWGt2pptZ+XKmlbfCOau54toYzkHEV0UWdCy9rqvtV1bSAsz4sCVvKwAYgicoMoRv3qw= X-Gm-Gg: AR+sD12NOJO/+VnhY9cqGodnEq+b3Bg0TFp26gf1QG9HO6tuXztFxUL4iwcb0tiyOT0 OaqBRiDk0oDbleo+eFwmIL+P7nNeaC/KvuJAy0XAjDFl4C6eLW6Kx4XjXpJYozwbE24c2jwAyWC A9VZn6vj8MXz1rjjsIHqiFqBnR/0ba3dms7MPBkXMFsY+V8j40AhF88ZG99x0/Tw/DgxmNaQRaX PC7d3HnvWCbyQU5WjErFpqVQh5q0Ie584jwJwP6HJGzIj3N/j2lN6l+fMWCQoKH25lJuoxRhhY+ t5r1MbU1mLAeJPc/x1cXptigB+Leg7cGCWobw6kqhwG2AP4gipGY4ALYqoilcrvyFHkkkplb0jJ 3Zm3Cb6hQ+pZptF04/YzC61NjIRijRDRD X-Received: by 2002:a17:90b:3fc5:b0:38d:eaec:4396 with SMTP id 98e67ed59e1d1-395df5ec7a7mr27572439a91.11.1787548297496; Sun, 23 Aug 2026 22:11:37 -0700 (PDT) X-Received: by 2002:a17:90b:3fc5:b0:38d:eaec:4396 with SMTP id 98e67ed59e1d1-395df5ec7a7mr27572358a91.11.1787548297002; Sun, 23 Aug 2026 22:11:37 -0700 (PDT) Received: from [10.206.101.140] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141860ec7f7sm22225790c88.6.2026.08.23.22.11.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Aug 2026 22:11:36 -0700 (PDT) Message-ID: Date: Mon, 24 Aug 2026 10:41:27 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 5/5] media: iris: Fix frame interval enumeration for non-divisor framerates Content-Language: en-US To: Krzysztof Kozlowski Cc: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Bjorn Andersson , Konrad Dybcio , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Mansur Alisha Shaik , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Bryan O'Donoghue References: <20260818-iris-fixes-dma-pseq-fint-v2-0-8dc8c4b3880e@oss.qualcomm.com> <20260818-iris-fixes-dma-pseq-fint-v2-5-8dc8c4b3880e@oss.qualcomm.com> <20260819-fat-shrew-of-agility-16bb0b@quoll> From: Vishnu Reddy In-Reply-To: <20260819-fat-shrew-of-agility-16bb0b@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: WqEdvGdDpzfyOsPV75Ch98twPiBB0YbM X-Authority-Analysis: v=2.4 cv=GdQnWwXL c=1 sm=1 tr=0 ts=6a8bd28a cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=_6ABqccX2T2vhF0wR04A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDA0MyBTYWx0ZWRfXyqO5TIfE9pRt sfWlYAmdEul96ndynF/rAu0R13+a+cQiB6QrSWBIO0yP1FMN/hWgBL2iJAPlM8kaLUl7HG8td4A WnxLqARFdpvpSQeC6PbRR5qF9PrwyHQrO1NrvPzJl9UXDxBwKD4JDKDIY0o5nAos9QgYHJGYq16 ie3t3YZ6PovnJFFPJPY+iYbIiL1lIcvBWXLKDGv7b3B2RFJSzgFGHGtwPMFN4KNQx3byaI0lpk4 7ye1tmRi2vs2cSFGI+meP1kod2HFwwthwwE6veRMH1zMMnbnsKFfXY0wOO7k7jTP6TNCpS+VNiq kHsBkzIN0/SPFBkEhSXMHNRbyJO9QRiRsfZgqza4pRNZYvE1Lxnjg5I1/upS41Ze4zelIOreS5p 6p4FGwSMlJ6jCJDrqaZBo/ycHE2rj/HGZNhrxJj1oTBgpJuDoqMFg2/Ar3a4Fw6gwECZE79FOJS dahzVz9J1JflCGccOxQ== X-Proofpoint-GUID: WqEdvGdDpzfyOsPV75Ch98twPiBB0YbM X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDA0MyBTYWx0ZWRfX6DxVP6qfIm9K fg9u8gGuTBIyi3SGtwYCP52BS6wM551GuwiXLm+owG8liVzK5RdoXdiwrJhnldd/PM2qBG1Oy/V u7wQxI5nfYKakDxNl5r6R2R+FpaDD9g= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_01,2026-08-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 lowpriorityscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240043 On 8/19/2026 12:47 PM, Krzysztof Kozlowski wrote: > On Tue, Aug 18, 2026 at 09:24:18PM +0530, Vishnu Reddy wrote: >> iris_enum_frameintervals() advertised frame intervals using >> V4L2_FRMIVAL_TYPE_STEPWISE with step=1/MAXIMUM_FPS where MAXIMUM_FPS >> is 480. This caused client to enumerate only framerates of the form >> MAXIMUM_FPS/n (where n is a positive integer), restricting support to >> exact divisors of MAXIMUM_FPS (e.g., 480, 240, 160, 120, 96, 80, 60, >> 30, 24, 1). >> >> Framerates that are not exact divisors of MAXIMUM_FPS, such as 29 fps, >> 25 fps, were excluded from the enumerated list. There is no hardware >> restriction to framerates that are exact divisors of MAXIMUM_FPS. This >> caused GStreamer caps negotiation to fail with an "internal data >> stream error" when encoding content at such framerates. >> >> Fix this by using V4L2_FRMIVAL_TYPE_CONTINUOUS. With CONTINUOUS type, >> GStreamer creates a continuous framerate range [1, max_fps], allowing >> any integer framerate within the range to pass caps negotiation. The >> step field is set to 1/1 as required by the V4L2 specification for >> continuous frame intervals. >> >> Fixes: a6882431a138 ("media: iris: Add support for ENUM_FRAMESIZES/FRAMEINTERVALS for encoder") >> Cc: stable@vger.kernel.org > Why is driver patch AFTER the dts? What is the dependency? No dependency, posted together as a series. > > Dependency on DTS is in general a no go. I looked at cover letter and > could not find explanation - where is it? No dependency, this series addresses three independent issues in the iris video and I mentioned this point this cover letter. > > Please read both submitting patches documents. > > Best regards, > Krzysztof > >