mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Naik, Avadhut" <avadnaik@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Avadhut Naik <avadhut.naik@amd.com>,
	linux-edac@vger.kernel.org, john.allen@amd.com,
	linux-kernel@vger.kernel.org,
	Yazen Ghannam <yazen.ghannam@amd.com>
Subject: [PATCH v3 0/2] Incorporate DRAM address in EDAC messages
Date: Tue, 14 Oct 2025 14:15:40 -0500	[thread overview]
Message-ID: <a285c8f8-3276-4628-88b1-a0bc18da5049@amd.com> (raw)
In-Reply-To: <20251014175238.GIaO6N5sWpG7EReE5P@fat_crate.local>



On 10/14/2025 12:52, Borislav Petkov wrote:
> On Tue, Oct 14, 2025 at 12:13:36PM -0500, Naik, Avadhut wrote:
>>> The "DRAM address" helps memory vendors analyze failures. System
>>> builders want to collect this data and pass it along to the memory
>>> vendors.
> 
> How real is such a use case? It sounds to me like wishful thinking and that no
> one is going to use it in the end and we'll end up warming up the universe
> with electrons needlessly...
> 
>>> The DRAM address is not contained in architectural data like
>>> MCA info, and getting the address from MCA requires using additional
>>> system-specific hardware info. It's much more reliable to get the DRAM
>>> address from the system with the error rather than try to post-process
>>> it later.
> 
> Ok, a bit better.
> 
> Now, why isn't that address part of the tracepoint so that system builders can
> consume structured data instead of parsing scnprintf()-ed strings and trying
> to guess what's there?
> 
> Also, some of the fields of TRACE_EVENT(mce_record already contain the fields
> this set is adding - CS or so, for example. So there's redundancy already.
> 

Currently, it is being exported through the RAS tracepoint along with the physical
address. Example snippet below:

     kworker/4:1-3950    [004] ..... 84373.064068: mc_event: 1 Corrected error: on mc#0csrow#0channel#9 (mc:0 location:0:9:-1 address:0x9ffff000 grain:64 syndrome:0x00000001 Cs: 0x0 Bank Grp: 0x0 Bank Addr: 0x1f Row: 0x27f Column: 0x7e0 RankMul: 0x0 SubChannel: 0x0)

Would you rather have it exported through the mce_record tracepoint?

>> If yes, will add this information to commit messages and resend.
> 
> When that happens, remove all text gunk which talks about what a patch does
> - that should be visible from the diff.
> 
> And this is not the first time I'm saying this: folks, please stop explaining
> the code.
> 
Will do.
> Thx.
> 

-- 
Thanks,
Avadhut Naik


      reply	other threads:[~2025-10-14 19:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13 19:34 Avadhut Naik
2025-10-13 19:34 ` [PATCH v3 1/2] RAS/AMD/ATL: Translate UMC normalized address to DRAM address using PRM Avadhut Naik
2025-10-13 19:34 ` [PATCH v3 2/2] EDAC/amd64: Incorporate DRAM Address in EDAC message Avadhut Naik
2025-10-13 22:00 ` [PATCH v3 0/2] Incorporate DRAM address in EDAC messages Borislav Petkov
2025-10-14 13:52   ` Yazen Ghannam
2025-10-14 17:13     ` Naik, Avadhut
2025-10-14 17:52       ` Borislav Petkov
2025-10-14 19:15         ` Naik, Avadhut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a285c8f8-3276-4628-88b1-a0bc18da5049@amd.com \
    --to=avadnaik@amd.com \
    --cc=avadhut.naik@amd.com \
    --cc=bp@alien8.de \
    --cc=john.allen@amd.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®