From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84211C169C4 for ; Wed, 6 Feb 2019 13:40:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51FF120B1F for ; Wed, 6 Feb 2019 13:40:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FXQKlIGv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730490AbfBFNkz (ORCPT ); Wed, 6 Feb 2019 08:40:55 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:45623 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727262AbfBFNkz (ORCPT ); Wed, 6 Feb 2019 08:40:55 -0500 Received: by mail-lj1-f196.google.com with SMTP id s5-v6so6029449ljd.12; Wed, 06 Feb 2019 05:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EVRz7WAXvo478K6JZUYfxHwZmR4rGMDfjmUQEqU9Ay4=; b=FXQKlIGvk0KSzXWL91mU+Xhv8dYg0eql7b2KdYOSegjWvdq2D3jo302zIqf4TgB4DA v4+HUuNbsIVNcStRgwM3FoRSkM6J05MRwWF9ekVU/n1xqoha29jvIYzjgUkzcooXzKHJ aCRGvHf1ONSBQiP1zzd4i5sxpFLngvPwdDYrL3AbjL2zBbroitQWzVxAqdpaevLBOkVm r3RJvxURhYCWdfTIdiJFQPv4dpzeLbxtNSE9L9HOIuxShMV77sKCGhUAH4m66S0HUgGE Kkb3PqkO2MCRk0JaCxTAHLfXIUlkUFNG+55I/2ViN0aZw9/7MwvjbF6y3xb1iIpHPMl0 hsCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EVRz7WAXvo478K6JZUYfxHwZmR4rGMDfjmUQEqU9Ay4=; b=nTPm18aYgLaChE7d1eafNt5JNoo0wPGuMaGpCSQurGhR7AZ9nXdiTuuNILr2SYBxvQ 2sztDeKXR8Kiz5d9rI96RZQH9NLibhNYMOCgUPo9yKkTn63PK7Ni1hHFC7nu6Hfnv1eX S7qfGioWK+Ah4Q1l2gZTcr4EHVukwWWjM2IcpWw4kBfa4EH0ItYE74txUeqRp0IJUoqE 0NRdTCCjUT6YSKt3qwVGgPRN867AKKgHX4yRCK85B8nyR8xOlSV1sBNoQLbrXmc1TyVV ym8zFT0CY0mv2okTIagNhqrDTPdWtiOLOUOWd6uaWnqFz/8BFwH96iiapgNTEUQ36WGS ZbFg== X-Gm-Message-State: AHQUAuaAtEH9sUc8TUXkoCJISsw4Eq/Hieghou7Tv53FpVXgliQ18bNK +YDjHQLI0TA629JBm4py8cjJn4y+ X-Google-Smtp-Source: AHgI3IbIegBZTag/kN6MqBhPKA7fbSTXNtjYushyXWzjYKPvGSO8GJf8I6tF1aUolaWaNtq3PVrqrA== X-Received: by 2002:a2e:914b:: with SMTP id q11-v6mr6555517ljg.164.1549460451779; Wed, 06 Feb 2019 05:40:51 -0800 (PST) Received: from [192.168.2.145] (ppp91-79-175-49.pppoe.mtu-net.ru. [91.79.175.49]) by smtp.googlemail.com with ESMTPSA id l17sm4280831lfk.40.2019.02.06.05.40.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 05:40:51 -0800 (PST) Subject: Re: [PATCH V12 3/5] i2c: tegra: Add DMA support From: Dmitry Osipenko To: Sowjanya Komatineni , "thierry.reding@gmail.com" , Jonathan Hunter , Mantravadi Karthik , Shardar Mohammed , Timo Alho Cc: "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" References: <1549406769-27544-1-git-send-email-skomatineni@nvidia.com> <1549406769-27544-3-git-send-email-skomatineni@nvidia.com> <85b77477-3175-0501-8753-f39d3b60538e@gmail.com> <304c1916-e836-fa95-5cec-887fef8f3eb2@gmail.com> <82f38909-94f1-7984-2b0f-df6231aee58f@gmail.com> <0cec3f47-6c47-b31d-74b5-696bd1f48596@gmail.com> Message-ID: Date: Wed, 6 Feb 2019 16:40:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <0cec3f47-6c47-b31d-74b5-696bd1f48596@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 06.02.2019 16:34, Dmitry Osipenko пишет: > 06.02.2019 16:30, Sowjanya Komatineni пишет: >> >> >>>> >>>>>>> BTW, I'm seeing "atmel_mxt_ts 0-004c: Warning: Info CRC error - device=0xF436DC file=0x000000" whithout making any modifications to the original patch as well and it shall not happen, hence there is bug somewhere. Probably FIFO triggers are still not set up correctly... ? >>>>>>> >>>>>>> >>>>>> In snippet you sent, I see you are forcing dma_burst to 1 always which is what set for fifo trigger levels as well and also you are forcing dma all the time. >>>>>> So always it will be 1 word dma burst and 1 word trigger level and that should not be an issue. >>>>>> >>>>> >>>>> I reverted that snippet, this log is collected with the yours original patch. >>>>> >>>> From atmel driver, looks like this warning is from maxt_update_cfg >>>> and due to CRC mismatch and above values shows read data CRC is 0Xf436dc which is compared against info_crc of all 0's Info_crc is based on raw config file and somehow its all 0's. this is not based on data read thru i2c. >>>> data->info_crc computed on data read is 0Xf436dc >>>> >>>> This warning is not related to I2C transfer >>>> >>> >>> It doesn't happen with the I2C PIO mode. Seems it means that the I2C reads out the 0xF436DC value instead of 0x000000.. if I'm not missing anything. >>> >> Log that you shared this warning, doesn’t show any i2c failures with atmel and CRC based on i2c read data is 0Xf436dc. >> During this log, there are not DMA timeouts associated during this warning timeframe. So i2c read data is thru DMA which is non-zero. >> >> Do you see DMA timeouts associated with this warning? I meant any DMA or I2C timeout during that time frame of warning? >> > > Actually you're right, my bad. That atmel error and atmel I2C timeout (due to I2C_ERR_NO_ACK) happens in the PIO mode too, hence that part is fine. > > PIO log: > > [ 1.028889] atmel_mxt_ts 0-004c: Warning: Info CRC error - device=0xF436DC file=0x000000 > [ 1.078907] atmel_mxt_ts 0-004c: Resetting device > [ 1.128646] usb 1-1: new full-speed USB device number 2 using tegra-ehci > [ 1.198708] atmel_mxt_ts 0-004c: __mxt_read_reg: i2c transfer failed (-121) > [ 1.198732] atmel_mxt_ts 0-004c: Failed to read 28 messages (-121) > Oh gosh.. there is no I2C timeout, but instant NO_ACK. I'll make some coffee...