From: Joe Perches <joe@perches.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [Proposal] end of file checks by checkpatch.pl
Date: Mon, 13 May 2019 08:51:18 -0700 [thread overview]
Message-ID: <a28b0616aca51aed38fd99fb85632628e6fd8d60.camel@perches.com> (raw)
In-Reply-To: <CAK7LNAQxsUheo2dHn5E=4ACafcYL9zNubgiVkJkANuZkx2RgpA@mail.gmail.com>
On Mon, 2019-05-13 at 19:11 +0900, Masahiro Yamada wrote:
> Hi Joe,
Hello again.
> On Fri, May 10, 2019 at 2:20 AM Joe Perches <joe@perches.com> wrote:
> > On Fri, 2019-05-10 at 00:27 +0900, Masahiro Yamada wrote:
> > > Does it make sense to check the following
> > > by checkpatch.pl ?
> > > [1] blank line at end of file
> > > [2] no new line at end of file
> >
> > I'm pretty sure checkpatch does one this already.
[]
> Looks like the report depends on the file type.
>
> scripts/checkpatch.pl -f arch/sparc/lib/NG4clear_page.S
> scripts/checkpatch.pl -f tools/power/cpupower/bench/cpufreq-bench_plot.sh
>
> reported it, but
>
> scripts/checkpatch.pl -f drivers/media/dvb-frontends/cxd2880/Kconfig
> scripts/checkpatch.pl -f drivers/parport/Makefile
>
> did not.
Yes, this check is after a test for filename extension.
Currently the only file types it reports as missing an EOF
newline are done on files with the following extensions:
.h
.c
.s
.S
.sh
.dtsi
.dts
So the existing test is not done on many file types.
The same file types are used for the proposed patch.
It's possible to have the existing missing newline at EOF
test and the proposed test for a blank line at EOF to be
done on all file types.
Is this reasonable or could it cause some other issue
for any other file types? Should _any_ file extension
be excluded?
I believe not, but perhaps it's best to ask.
next prev parent reply other threads:[~2019-05-13 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 15:27 Masahiro Yamada
2019-05-09 17:19 ` Joe Perches
2019-05-13 10:11 ` Masahiro Yamada
2019-05-13 15:51 ` Joe Perches [this message]
2019-05-13 23:46 ` Masahiro Yamada
2019-05-13 23:58 ` Joe Perches
2019-05-14 0:54 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a28b0616aca51aed38fd99fb85632628e6fd8d60.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®