mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Boris Burkov <boris@bur.io>
Cc: Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
	 linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@fb.com
Subject: Re: [PATCH 3/4] btrfs: handle ENOMEM from btrfs_insert_dir_item() without aborting
Date: Tue, 21 Jul 2026 08:59:52 -0400	[thread overview]
Message-ID: <a28f3b3f3a8cf5437c148cbf2646b03f0b966a8f.camel@kernel.org> (raw)
In-Reply-To: <20260718001309.GA420230@zen.localdomain>

On Fri, 2026-07-17 at 17:13 -0700, Boris Burkov wrote:
> 
> > 
> > One thought: It looks like the main allocation in that codepath is
> > btrfs_alloc_path()? We could consider preallocating that too -- maybe
> > stash it in a new pointer in btrfs_trans_handle?
> > 
> > Thanks! This is good food for thought.
> 
> Take a peek at https://lore.kernel.org/linux-btrfs/cover.1782249000.git.boris@bur.io/
> 
> which I need to RESEND :)

I think basing this series on top of yours would make the most sense.
That should take care of your main concern with the later failure mode
since your series should fix most of those cases. I'll plan to rebase
this on top of that series once you resend it.

Thanks!
-- 
Jeff Layton <jlayton@kernel.org>

  parent reply	other threads:[~2026-07-21 12:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 16:52 [PATCH 0/4] btrfs: handle -ENOMEM errors in some synchronous dirops " Jeff Layton
2026-07-17 16:52 ` [PATCH 1/4] btrfs: split btrfs_insert_delayed_dir_index() into prealloc and commit phases Jeff Layton
2026-07-17 16:52 ` [PATCH 2/4] btrfs: pre-allocate delayed dir index before btree modification Jeff Layton
2026-07-17 16:52 ` [PATCH 3/4] btrfs: handle ENOMEM from btrfs_insert_dir_item() without aborting Jeff Layton
2026-07-17 20:18   ` Boris Burkov
2026-07-17 22:40     ` Jeff Layton
2026-07-17 23:04       ` Boris Burkov
2026-07-17 23:55         ` Jeff Layton
2026-07-18  0:13           ` Boris Burkov
2026-07-18 13:27             ` Jeff Layton
2026-07-21 12:59             ` Jeff Layton [this message]
2026-07-18  0:19           ` Qu Wenruo
2026-07-18 13:24             ` Jeff Layton
2026-07-17 16:52 ` [PATCH 4/4] btrfs: pre-allocate delayed dir index for non-overwrite rename Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a28f3b3f3a8cf5437c148cbf2646b03f0b966a8f.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=boris@bur.io \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®