From: Jiri Slaby <jirislaby@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
lianzhi chang <changlianzhi@uniontech.com>
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
gregkh@linuxfoundation.org, linux-input@vger.kernel.org,
282827961@qq.com
Subject: Re: [PATCH] input&tty: Fix the keyboard led light display problem
Date: Thu, 14 Oct 2021 16:55:20 +0200 [thread overview]
Message-ID: <a2964246-f90f-f205-ce99-707cc1a114cc@kernel.org> (raw)
In-Reply-To: <YWhI/DzNjivU6jQ6@smile.fi.intel.com>
On 14. 10. 21, 17:13, Andy Shevchenko wrote:
> On Thu, Oct 14, 2021 at 03:16:27PM +0800, lianzhi chang wrote:
>> Switching from the desktop environment to the tty environment,
>> the state of the keyboard led lights and the state of the keyboard
>> lock are inconsistent. This is because the attribute kb->kbdmode
>> of the tty bound in the desktop environment (xorg) is set to
>> VC_OFF, which causes the ledstate and kb->ledflagstate
>> values of the bound tty to always be 0, which causes the switch
>> from the desktop When to the tty environment, the LED light
>> status is inconsistent with the keyboard lock status.
>
> ...
>
>> +void update_value_ledstate(unsigned int flag, unsigned int value)
>> +{
>> + unsigned int bit;
>
> unsigned long bit;
>
> (see below why)
You'd need ledstate to be ulong, not bit. Or am I missing something?
--
js
next prev parent reply other threads:[~2021-10-14 14:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211014071627.23256-1-changlianzhi@uniontech.com>
2021-10-14 7:34 ` Greg KH
2021-10-14 15:13 ` Andy Shevchenko
2021-10-14 14:55 ` Jiri Slaby [this message]
2021-10-14 18:20 ` Dmitry Torokhov
[not found] <35696980-2a55-c5c1-3fa9-eadf251dcdde@uniontech.com>
2021-10-15 13:06 ` Andy Shevchenko
[not found] <20211015083613.7429-1-changlianzhi@uniontech.com>
2021-10-15 8:41 ` Greg KH
[not found] ` <616942b2.1c69fb81.dfbff.25afSMTPIN_ADDED_BROKEN@mx.google.com>
2021-10-15 10:16 ` Greg KH
2021-10-15 8:37 lianzhi chang
[not found] <61693925.1c69fb81.a058.27f2SMTPIN_ADDED_BROKEN@mx.google.com>
2021-10-15 8:25 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2021-10-15 6:45 lianzhi chang
2021-10-15 6:52 ` Greg KH
[not found] ` <616934f3.1c69fb81.59ff6.49d9SMTPIN_ADDED_BROKEN@mx.google.com>
2021-10-15 8:04 ` Greg KH
2021-10-15 1:20 lianzhi chang
2021-10-14 8:53 lianzhi chang
[not found] ` <616827d8.1c69fb81.75aa0.eea0SMTPIN_ADDED_BROKEN@mx.google.com>
2021-10-14 13:21 ` gregkh
2021-10-14 7:20 lianzhi chang
[not found] <20211014040508.8367-1-changlianzhi@uniontech.com>
2021-10-14 4:12 ` Jiri Slaby
[not found] <20211014030836.30612-1-changlianzhi@uniontech.com>
2021-10-14 4:12 ` Jiri Slaby
2021-10-14 4:06 lianzhi chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2964246-f90f-f205-ce99-707cc1a114cc@kernel.org \
--to=jirislaby@kernel.org \
--cc=282827961@qq.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=changlianzhi@uniontech.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®