From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 611D13C3C0E for ; Tue, 26 May 2026 07:52:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779781961; cv=none; b=uPROv0PB1hB74wuF3rPgsO9+pB33n0eChOTHraQ6AB4elSQdzAmZdfzmhYJXsih44Rm2FrUgoXV/jEnG3nRT7x51l/3qi5yc/MrrbUEacNak/fA+QC76/4KrcJuhdCjcnkapy/c28ASiZ9jbR2RnGKoKiaegDeHvtv2I4yhF7DM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779781961; c=relaxed/simple; bh=3tYqvS5uJQW+pyqxt93wruCxavof6l5sg9/0bjlc3nw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i0xGEjepkO9UKa2Gr3/9klWM1sCLaQw6dPeHqeHkGpa9elgtywbwcNWNze4HTSBGY9swXaSlI5wtFUiSbYzKVfz17QhpNsRw7Gls70Jh+4zFbDPOzV4fYbYaqJgA5MhSkJcmHlq7dZWykBPF3R+yZxYce7ovfGw5G7PWH8/LKR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ZqQcM5NY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=QFnny52e; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=qzKF1+8Q; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=+vnexHyI; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ZqQcM5NY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="QFnny52e"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="qzKF1+8Q"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+vnexHyI" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7473065480; Tue, 26 May 2026 07:52:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779781958; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eNS7znOQpZhduWDFOY7a8ExDWPJniNi885JpXrGZlDA=; b=ZqQcM5NYle4o9pyCAPisySGNttfMmdwnYL3IJ9qngTGiy8fI/8fq/nkNyw+D5fYY3ZgpZu PN7r9w9ohWAmKWIqWG+f8CXgW6ZgX7itQ0TsjsLVcNb82Mqi9dJMi1W4hoOWDI6/yZR4BO sV++iW3QSIIwXedEE6B0GJHf0kMWXIY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779781958; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eNS7znOQpZhduWDFOY7a8ExDWPJniNi885JpXrGZlDA=; b=QFnny52eO4pkl1aMQqxjgyUKr2ivS4Fkh9CLvEcn15kTKf3UrMvG4lVL/rIoZLjOmt01+7 nAG39lsAD8fXkEBA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=qzKF1+8Q; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=+vnexHyI DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779781957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eNS7znOQpZhduWDFOY7a8ExDWPJniNi885JpXrGZlDA=; b=qzKF1+8QRgC64y9UVabB7PTm+TlT1MDPWFH65+iwKNeKmhmBRFOIrW0e+4+mZPUuw23rB9 341inYgwIPv17pWQwcopRVM+ax6O0iPw0esVckUpRLAVNxL1IPfZOQJJVFozlVLY7fNyUs LT4pTQIFUfCk0DlruX+LzOSCeRCcJlE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779781957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eNS7znOQpZhduWDFOY7a8ExDWPJniNi885JpXrGZlDA=; b=+vnexHyIIxkDL6xKOg0aOcpSE9COf7/HQVTArOmPrs5qLz1BrXAqjFfl4p9Z2OVeYcbHly XX26MPoN/dFEY1Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2CDBF5A0CA; Tue, 26 May 2026 07:52:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id phmGCUVRFWq8HwAAD6G6ig (envelope-from ); Tue, 26 May 2026 07:52:37 +0000 Message-ID: Date: Tue, 26 May 2026 09:52:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH drm-misc-next] drm: verisilicon: fix build failure of cursor plane code To: Icenowy Zheng , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Dmitry Baryshkov , Mark Brown Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Icenowy Zheng References: <20260525153618.1336239-1-zhengxingda@iscas.ac.cn> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260525153618.1336239-1-zhengxingda@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -4.51 X-Spam-Level: X-Rspamd-Queue-Id: 7473065480 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[iscas.ac.cn,linux.intel.com,kernel.org,gmail.com,ffwll.ch,oss.qualcomm.com]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; internal_greylist_whitelist(0.00)[2a07:de40:b281:104:10:150:64:97]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[10]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,iscas.ac.cn:email,suse.de:email,suse.de:mid,suse.de:dkim,suse.com:url] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO Am 25.05.26 um 17:36 schrieb Icenowy Zheng: > The cursor plane patch was stalled for a too long time that the > struct drm_atomic_state parameter of atomic modeset hooks has been > changed to struct drm_atomic_commit. > > Fix this by replacing the parameter's type. All helpers that retrieve > information from this struct are also changed so simply replacing the > type works. > > Fixes: 8c4ae2189125 ("drm: verisilicon: add support for cursor planes") > Signed-off-by: Icenowy Zheng Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/verisilicon/vs_cursor_plane.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/verisilicon/vs_cursor_plane.c b/drivers/gpu/drm/verisilicon/vs_cursor_plane.c > index acb9854fa67ed..fa4f601dd0c87 100644 > --- a/drivers/gpu/drm/verisilicon/vs_cursor_plane.c > +++ b/drivers/gpu/drm/verisilicon/vs_cursor_plane.c > @@ -40,7 +40,7 @@ static bool vs_cursor_plane_check_coord(int32_t coord) > } > > static int vs_cursor_plane_atomic_check(struct drm_plane *plane, > - struct drm_atomic_state *state) > + struct drm_atomic_commit *state) > { > struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state, > plane); > @@ -98,7 +98,7 @@ static void vs_cursor_plane_commit(struct vs_dc *dc, unsigned int output) > } > > static void vs_cursor_plane_atomic_enable(struct drm_plane *plane, > - struct drm_atomic_state *atomic_state) > + struct drm_atomic_commit *atomic_state) > { > struct drm_plane_state *state = drm_atomic_get_new_plane_state(atomic_state, > plane); > @@ -115,7 +115,7 @@ static void vs_cursor_plane_atomic_enable(struct drm_plane *plane, > } > > static void vs_cursor_plane_atomic_disable(struct drm_plane *plane, > - struct drm_atomic_state *atomic_state) > + struct drm_atomic_commit *atomic_state) > { > struct drm_plane_state *state = drm_atomic_get_old_plane_state(atomic_state, > plane); > @@ -132,7 +132,7 @@ static void vs_cursor_plane_atomic_disable(struct drm_plane *plane, > } > > static void vs_cursor_plane_atomic_update(struct drm_plane *plane, > - struct drm_atomic_state *atomic_state) > + struct drm_atomic_commit *atomic_state) > { > struct drm_plane_state *state = drm_atomic_get_new_plane_state(atomic_state, > plane); -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)