From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 983C7CE79B0 for ; Wed, 20 Sep 2023 10:44:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234318AbjITKof (ORCPT ); Wed, 20 Sep 2023 06:44:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234054AbjITKo0 (ORCPT ); Wed, 20 Sep 2023 06:44:26 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6215CA for ; Wed, 20 Sep 2023 03:44:19 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9aa2c6f0806so874894766b.3 for ; Wed, 20 Sep 2023 03:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20230601.gappssmtp.com; s=20230601; t=1695206658; x=1695811458; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7O7mWyhJga1IYEYoLQcrmnzYFbmyVRQyHT7Q+TKsjdE=; b=E2hk2cM20Acvnfd3/3r7bxco2Xyc0iWlKaxvEDn66gMvg4j+yLaCjLxSS/1XLzeztT 0GcjIrAB0g+8dMRdvSv7aWe5QgdE6XIrv2MCva65kYwn7SKMr2RiOOM325asIkrK3rNW mHnSubkPq1b1fmG0LeLgvEeUvm4V26zsB5rCSkGRAY8nId+FCUl13RTZasWpJkx3AfWR v3+IQz9WtWFjdzvBYZ5k0Epw1IqS3o13qrHRlXsvSKBJ94uhop8fRmAeKiW38UrvmI+9 leITM0vDHseACWXK2MYiHb5qOYCOFS9m/0hrG+umiugsv3ZtC1xmAtm7JaGW85q2k907 14og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695206658; x=1695811458; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7O7mWyhJga1IYEYoLQcrmnzYFbmyVRQyHT7Q+TKsjdE=; b=jCDSFDl+y9g7a27vpJH/Inb9+o1U4h4+FaGyd/C/+n/4C64yeOv4AQGQ+KKc5XErDj lfkpU0+eNHK0CJ7qu5PZrQsCVVEHoC29FVfhALRRYN/gy+28Tc0W4e0Fhbn6gLjvyp96 95QhiGjcAAZQOjhGazXQbnKj0C5HPzvee9kt03C0jFRAkLVWt7/9aua+7ItPBtTEeeJN Yw37Xk/+uH4EPr6T1FSiI7RGqKW54YBRlcCHvwMCF+NJkyYcTzGqbv5qNqViD6Yn1vC2 0c/iTDYwGc1R9h76D/bnBBu82TYpH9r/1pQHeaqLmV1LHKfYz0O69sq2zh563cKzPlKn 4vsA== X-Gm-Message-State: AOJu0Yxq5HkNaKauuBSgLoh9ddWV9M9Pdg+IF2RDZJv4N+B7YG5sm8No Ejur/Df6VLiOvdXA8evOnxOnGg== X-Google-Smtp-Source: AGHT+IGO3lncIOMxzIVaRUoIoQXNjIcQ22mCx46sIDTt+vAiLFg+skIRbs2SUmaSDzWxxnF2blZYPA== X-Received: by 2002:a17:907:75c2:b0:9aa:25f5:8d95 with SMTP id jl2-20020a17090775c200b009aa25f58d95mr1711323ejc.59.1695206658146; Wed, 20 Sep 2023 03:44:18 -0700 (PDT) Received: from [192.168.0.105] (haunt.prize.volia.net. [93.72.109.136]) by smtp.gmail.com with ESMTPSA id i13-20020a170906114d00b00992afee724bsm8979517eja.76.2023.09.20.03.44.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 03:44:17 -0700 (PDT) Message-ID: Date: Wed, 20 Sep 2023 13:44:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH net-next v4 1/6] net: bridge: Set BR_FDB_ADDED_BY_USER early in fdb_add_entry Content-Language: en-US To: Johannes Nixdorf , "David S. Miller" , Andrew Lunn , David Ahern , Eric Dumazet , Florian Fainelli , Ido Schimmel , Jakub Kicinski , Oleksij Rempel , Paolo Abeni , Roopa Prabhu , Shuah Khan , Vladimir Oltean Cc: bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20230919-fdb_limit-v4-0-39f0293807b8@avm.de> <20230919-fdb_limit-v4-1-39f0293807b8@avm.de> From: Nikolay Aleksandrov In-Reply-To: <20230919-fdb_limit-v4-1-39f0293807b8@avm.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/19/23 11:12, Johannes Nixdorf wrote: > In preparation of the following fdb limit for dynamically learned entries, > allow fdb_create to detect that the entry was added by the user. This > way it can skip applying the limit in this case. > > Signed-off-by: Johannes Nixdorf > --- > net/bridge/br_fdb.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c > index e69a872bfc1d..f517ea92132c 100644 > --- a/net/bridge/br_fdb.c > +++ b/net/bridge/br_fdb.c > @@ -1056,7 +1056,8 @@ static int fdb_add_entry(struct net_bridge *br, struct net_bridge_port *source, > if (!(flags & NLM_F_CREATE)) > return -ENOENT; > > - fdb = fdb_create(br, source, addr, vid, 0); > + fdb = fdb_create(br, source, addr, vid, > + BIT(BR_FDB_ADDED_BY_USER)); > if (!fdb) > return -ENOMEM; > > @@ -1069,6 +1070,8 @@ static int fdb_add_entry(struct net_bridge *br, struct net_bridge_port *source, > WRITE_ONCE(fdb->dst, source); > modified = true; > } > + > + set_bit(BR_FDB_ADDED_BY_USER, &fdb->flags); > } > > if (fdb_to_nud(br, fdb) != state) { > @@ -1100,8 +1103,6 @@ static int fdb_add_entry(struct net_bridge *br, struct net_bridge_port *source, > if (fdb_handle_notify(fdb, notify)) > modified = true; > > - set_bit(BR_FDB_ADDED_BY_USER, &fdb->flags); > - > fdb->used = jiffies; > if (modified) { > if (refresh) > Acked-by: Nikolay Aleksandrov