From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yangtao Li <frank.li@vivo.com>,
Jisheng Zhang <jszhang@kernel.org>, Wei Fu <wefu@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Cc: Icenowy Zheng <uwu@icenowy.me>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] riscv: dts: add initial T-HEAD light SoC device tree
Date: Thu, 11 May 2023 11:05:59 +0200 [thread overview]
Message-ID: <a2ac9485-23ee-cd6c-4290-eb5e6e2ac826@linaro.org> (raw)
In-Reply-To: <20230510204456.57202-2-frank.li@vivo.com>
On 10/05/2023 22:44, Yangtao Li wrote:
> From: Jisheng Zhang <jszhang@kernel.org>
>
> Add initial device tree for the TH1520 RISC-V SoC by
> T-HEAD.
>
> Cc: Icenowy Zheng <uwu@icenowy.me>
> Cc: Wei Fu <wefu@redhat.com>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> v2:
> -remove reset-sample
> -convert to use thead,c900-plic
> -add pvt node
> -add thermal-zones
> arch/riscv/boot/dts/thead/th1520.dtsi | 491 ++++++++++++++++++++++++++
> 1 file changed, 491 insertions(+)
> create mode 100644 arch/riscv/boot/dts/thead/th1520.dtsi
>
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> new file mode 100644
> index 000000000000..d1d94098b6bf
> --- /dev/null
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -0,0 +1,491 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2021 Alibaba Group Holding Limited.
> + * Copyright (C) 2023 Jisheng Zhang <jszhang@kernel.org>
> + * Copyright (C) 2023 Yangtao Li <frank.li@vivo.com>
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +/ {
> + compatible = "thead,th1520";
Again - missing bindings. You already got such comments, right? And
still there is only one patch here - 2/5 - without anything else.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-11 9:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 20:44 [PATCH v2 1/5] riscv: Add the T-HEAD SoC family Kconfig option Yangtao Li
2023-05-10 20:44 ` [PATCH v2 2/5] riscv: dts: add initial T-HEAD light SoC device tree Yangtao Li
2023-05-11 0:35 ` Yixun Lan
2023-05-11 0:39 ` Jisheng Zhang
2023-05-11 9:05 ` Krzysztof Kozlowski [this message]
2023-05-10 20:44 ` [PATCH v2 3/5] riscv: dts: thead: add sipeed Lichee Pi 4A board " Yangtao Li
2023-05-11 0:42 ` Yixun Lan
2023-05-11 9:12 ` Krzysztof Kozlowski
2023-05-10 20:44 ` [PATCH v2 4/5] riscv: defconfig: Enable the T-HEAD SoC Yangtao Li
2023-05-10 20:44 ` [PATCH v2 5/5] MAINTAINERS: add entry for T-HEAD RISC-V SoC Yangtao Li
2023-05-10 20:52 ` Conor Dooley
2023-05-11 0:54 ` Yixun Lan
2023-05-11 5:20 ` Conor Dooley
2023-05-10 23:49 ` [PATCH v2 1/5] riscv: Add the T-HEAD SoC family Kconfig option Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ac9485-23ee-cd6c-4290-eb5e6e2ac826@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank.li@vivo.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=uwu@icenowy.me \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®