From: Paolo Abeni <pabeni@redhat.com>
To: netdev-bot+sashiko@kernel.org, ansuelsmth@gmail.com
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3 2/4] net: phy: as21xxx: fix read_status speed handling
Date: Tue, 3 Nov 2026 09:56:25 +0100 [thread overview]
Message-ID: <a2ad86f8-1e4c-48e6-8cd3-4c43d73dea3b@redhat.com> (raw)
In-Reply-To: <179335632134.3134.7804602022043442736@kernel.org>
On 10/30/26 11:32, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 6 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 5 · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] With AUTONEG_DISABLE, as21xxx_read_status() no longer takes
> speed/duplex from the PHY.
> - [Medium] In autoneg mode, as21xxx_read_status() now reads
> VEND1_SPEED_STATUS on every link-up, which is the PHY's own report of…
> - [Medium] The new early `if (!phydev->link) return 0;` in
> as21xxx_read_status() (drivers/net/phy/as21xxx.c:732-733) makes the…
> - [Medium] In forced mode (AUTONEG_DISABLE), phydev->speed/duplex hold
> the user's configuration.
> - [Medium] net: phy: as21xxx: missed pause and <=1G speed in
> as21xxx_read_status()
The above ones looks legit to me.
/P
next prev parent reply other threads:[~2026-11-03 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 7:30 [PATCH net v3 0/4] net: phy: as21xxx: simple series for trivial fixes Christian Marangi
2026-10-28 7:30 ` [PATCH net v3 1/4] net: phy: as21xxx: handle stale link status during autoneg Christian Marangi
2026-10-30 10:32 ` netdev-bot+sashiko
2026-10-28 7:30 ` [PATCH net v3 2/4] net: phy: as21xxx: fix read_status speed handling Christian Marangi
2026-10-30 10:32 ` netdev-bot+sashiko
2026-11-03 8:56 ` Paolo Abeni [this message]
2026-10-28 7:30 ` [PATCH net v3 3/4] net: phy: as21xxx: force C45 OPs for AUTONEG Christian Marangi
2026-10-30 10:32 ` netdev-bot+sashiko
2026-10-28 7:30 ` [PATCH net v3 4/4] net: phy: as21xxx: handle odd firmware on loading Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ad86f8-1e4c-48e6-8cd3-4c43d73dea3b@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®