From: "André Almeida" <andrealmeid@collabora.com>
To: Jangwoong Kim <6812skiii@gmail.com>
Cc: peterz@infradead.org, dvhart@infradead.org, mingo@redhat.com,
tglx@linutronix.de, dave@stgolabs.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] futex: Fix a faulty comment.
Date: Wed, 8 Dec 2021 13:21:34 -0300 [thread overview]
Message-ID: <a2ae8ff5-b81b-398e-cb5b-7eb1279f0f5d@collabora.com> (raw)
In-Reply-To: <CAF=mnpiEGXemtEEo_fbJ1pkfwZaaZNo9HPGKG5EZ1voaPqRaWA@mail.gmail.com>
Hi Jangwoong,
Thank you for your new version.
No full stop at the end of commit message. I would write as follow:
"futex: Clarify comment at futex_wait_multiple_setup()"
Às 04:03 de 07/12/21, Jangwoong Kim escreveu:
> From: Jangwoong Kim <6812skiii@gmail.com>
>
> Clarify that "woken" saves the last index of futex awoken.
>
> v2 patch had a typo (awaken -> awoken).
The changelog is usually place bellow the `---`, so it won't made in the
git history, given that this is only relevant for reviewers.
>
> Signed-off-by: Jangwoong Kim <6812skiii@gmail.com>
> ---
[Place changelog here]
> kernel/futex/waitwake.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/futex/waitwake.c b/kernel/futex/waitwake.c
> index 4ce0923f1ce3..45d634dacfcb 100644
> --- a/kernel/futex/waitwake.c
> +++ b/kernel/futex/waitwake.c
> @@ -454,9 +454,9 @@ static int futex_wait_multiple_setup(struct
> futex_vector *vs, int count, int *wo
> __set_current_state(TASK_RUNNING);
>
> /*
> - * Even if something went wrong, if we find out that a futex
> - * was woken, we don't return error and return this index to
> - * userspace
> + * Even if something went wrong, if we find out that any futex
> + * was woken, we don't return error and return the last index
> + * of futex awoken to userspace
I think it's the "index of the last futex awoken", no?
> */
> *woken = unqueue_multiple(vs, i);
> if (*woken >= 0)
> --
> 2.25.1
>
prev parent reply other threads:[~2021-12-08 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 7:03 Jangwoong Kim
2021-12-08 16:21 ` André Almeida [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ae8ff5-b81b-398e-cb5b-7eb1279f0f5d@collabora.com \
--to=andrealmeid@collabora.com \
--cc=6812skiii@gmail.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®