From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>,
faisal.latif@intel.com, shiraz.saleem@intel.com,
dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_add_mqh_4
Date: Wed, 11 Apr 2018 10:53:13 -0400 [thread overview]
Message-ID: <a2af56ae-075f-bd13-3308-6c6ebbca7694@intel.com> (raw)
In-Reply-To: <1523431945-3508-1-git-send-email-baijiaju1990@gmail.com>
On 4/11/2018 3:32 AM, Jia-Ju Bai wrote:
> i40iw_add_mqh_4() is never called in atomic context, because it
> calls rtnl_lock() that can sleep.
>
> Despite never getting called from atomic context,
> i40iw_add_mqh_4() calls kzalloc() with GFP_ATOMIC,
> which does not sleep for allocation.
> GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
> which can sleep and improve the possibility of sucessful allocation.
Just a general comment. I don't know that this is the greatest idea. I
can imagine instances where sleeping is OK as far as how the code is
written, but for performance reasons you would rather fail than sleep.
As to whether that is the case here I'll let the i40iw folks comment.
> This is found by a static analysis tool named DCNS written by myself.
> And I also manually check it.
You should probably post a pointer to your tool.
-Denny
next prev parent reply other threads:[~2018-04-11 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 7:32 Jia-Ju Bai
2018-04-11 14:53 ` Dennis Dalessandro [this message]
2018-04-14 1:15 ` Shiraz Saleem
2018-04-14 1:10 ` Shiraz Saleem
2018-04-18 1:58 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2af56ae-075f-bd13-3308-6c6ebbca7694@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=baijiaju1990@gmail.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome