mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Babu Moger <babu.moger@amd.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
	"Moger, Babu" <bmoger@amd.com>,
	tony.luck@intel.com, bp@alien8.de
Cc: x86@kernel.org, Dave.Martin@arm.com, james.morse@arm.com,
	corbet@lwn.net, skhan@linuxfoundation.org, tglx@kernel.org,
	mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	eranian@google.com, peternewman@google.com
Subject: Re: [PATCH v2 1/3] x86/resctrl: Fix ABMC counter programming for extended counter ranges
Date: Wed, 16 Sep 2026 11:13:25 -0500	[thread overview]
Message-ID: <a2af93a8-3803-48d3-9ed5-71a0a50a1b01@amd.com> (raw)
In-Reply-To: <f1c98e95-5df5-4c8a-be67-df8ecba0c28a@intel.com>

Hi Reinette,

On 9/16/26 09:58, Reinette Chatre wrote:
> Hi Babu,
> 
> On 9/14/26 5:18 PM, Moger, Babu wrote:
>>
>> The original issue arose when programming a Counter ID wider than 5 bits. To address that issue, the Counter ID width needs to be increased to 12 bits.
>>
>> Currently, the RMID width is 12 bits, and there is no hardware that supports a width greater than 12 bits.
>>
>> How about we address the Counter ID issue for now and revisit the RMID width when the specification changes?
>>
>> Would that work?
> 
> Neither change seems to be reflected in any public spec. The comment in this patch
> seems to be that the upcoming spec change will cover both?
> 
> 	The AMD64 Architecture Programmer's Manual [1] available at [2] will be
> 	updated accordingly in a future revision to document the expanded cntr_id
> 	and bw_src field definitions.
> 
> If you thus plan to change RMID width when the specification changes then it is not clear
> to me how the timing is different from the counter ID width change.
> 
> In the end it is up to you though since the impact is on AMD hardware that you
> are best to judge.
> 
Thanks. The immediate priority is to fix the counter programming issue.

Thanks,
Babu

  reply	other threads:[~2026-09-16 16:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 18:06 [PATCH v2 0/3] x86/resctrl: Keep default MBM mode at boot and fix ABMC Babu Moger
2026-09-04 18:06 ` [PATCH v2 1/3] x86/resctrl: Fix ABMC counter programming for extended counter ranges Babu Moger
2026-09-11 22:03   ` Reinette Chatre
2026-09-14 17:17     ` Babu Moger
2026-09-14 21:30       ` Reinette Chatre
2026-09-14 21:50         ` Reinette Chatre
2026-09-15  0:18           ` Moger, Babu
2026-09-16 14:58             ` Reinette Chatre
2026-09-16 16:13               ` Babu Moger [this message]
2026-09-15  0:20         ` Moger, Babu
2026-09-04 18:06 ` [PATCH v2 2/3] fs/resctrl: Assign counters to existing groups when enabling mbm_event Babu Moger
2026-09-11 22:12   ` Reinette Chatre
2026-09-14 18:54     ` Babu Moger
2026-09-04 18:06 ` [PATCH v2 3/3] x86/resctrl: Keep mbm_assign_mode in default mode at boot Babu Moger
2026-09-11 22:25   ` Reinette Chatre
2026-09-14 20:45     ` Babu Moger
2026-09-14 21:31       ` Reinette Chatre
2026-09-15  1:11         ` Moger, Babu
2026-09-15 19:59           ` Babu Moger
2026-09-16 14:42             ` Reinette Chatre
2026-09-16 16:09               ` Babu Moger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2af93a8-3803-48d3-9ed5-71a0a50a1b01@amd.com \
    --to=babu.moger@amd.com \
    --cc=Dave.Martin@arm.com \
    --cc=bmoger@amd.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peternewman@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=skhan@linuxfoundation.org \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®