From: Joe Perches <joe@perches.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Vivien Didelot <vivien.didelot@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vim: linux-kernel: Increase columns highlighting to 100+
Date: Fri, 31 Jul 2020 10:17:01 -0700 [thread overview]
Message-ID: <a2b0b4a44901674d46de9f949227f35afd21062b.camel@perches.com> (raw)
In-Reply-To: <20200731170755.GB1726@embeddedor>
On Fri, 2020-07-31 at 12:07 -0500, Gustavo A. R. Silva wrote:
> On Fri, Jul 31, 2020 at 09:35:42AM -0700, Joe Perches wrote:
> > On Fri, 2020-07-31 at 11:33 -0500, Gustavo A. R. Silva wrote:
> > > Increase columns highlighting to 100+ once the 80-column warning has
> > > been deprecated in the Linux kernel[1].
> > >
> > > [1] commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
> > >
> > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > > ---
> > > plugin/linuxsty.vim | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/plugin/linuxsty.vim b/plugin/linuxsty.vim
> > > index 6f7e331..c42ce72 100644
> > > --- a/plugin/linuxsty.vim
> > > +++ b/plugin/linuxsty.vim
> > > @@ -62,7 +62,7 @@ function s:LinuxFormatting()
> > > setlocal tabstop=8
> > > setlocal shiftwidth=8
> > > setlocal softtabstop=8
> > > - setlocal textwidth=80
> > > + setlocal textwidth=100
> >
> > This is not a good change.
> > 80 columns is still _preferred_.
> >
>
> Now that you mention that, I have mixed feelings about this.
> Let's see if we can get more opinions...
I am not a vim user, but maybe remove this line
altogether and add something like
setlocal colorcolumn=80,100
and let people make their own wrapping decisions.
next prev parent reply other threads:[~2020-07-31 17:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 16:33 Gustavo A. R. Silva
2020-07-31 16:35 ` Joe Perches
2020-07-31 17:07 ` Gustavo A. R. Silva
2020-07-31 17:17 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-31 16:30 Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2b0b4a44901674d46de9f949227f35afd21062b.camel@perches.com \
--to=joe@perches.com \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®