From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755778AbdESOhM (ORCPT ); Fri, 19 May 2017 10:37:12 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:33311 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbdESOhK (ORCPT ); Fri, 19 May 2017 10:37:10 -0400 Subject: Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when safe To: Paolo Valente , Tejun Heo Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, broonie@kernel.org References: <20170519083908.2588-1-paolo.valente@linaro.org> From: Jens Axboe Message-ID: Date: Fri, 19 May 2017 08:37:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170519083908.2588-1-paolo.valente@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19/2017 02:39 AM, Paolo Valente wrote: > @@ -692,8 +725,7 @@ void bfq_pd_offline(struct blkg_policy_data *pd) > /* > * The idle tree may still contain bfq_queues belonging > * to exited task because they never migrated to a different > - * cgroup from the one being destroyed now. No one else > - * can access them so it's safe to act without any lock. > ++ * cgroup from the one being destroyed now. > */ > bfq_flush_idle_tree(st); > Looks like an extra '+' snuck into that hunk. -- Jens Axboe