From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFC8E344DAD for ; Tue, 17 Feb 2026 12:34:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771331692; cv=none; b=oGgEAR1GAUnCtWSSbGSWRqSISQEwkVIkgCq49YabBolii8VuLSAevDc8pAGH4lx1bGd+AMWy9GAXNspJK4eup5uZZGhqrmRL40wrfnGDgiAdnQYIiKFTW9VvajEKwrZ1gXU/X07ibr1XEIeMbeZyS3XFdkrrITTxBwKvPltf/Dc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771331692; c=relaxed/simple; bh=k0PDVg58bXEO9ATpH3R8UPaGClW81v0PAOINPuiAK2c=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=m0CyjqkAbOw/6eEttrtPb62f+1nXoofqmuWIiEsZPkxalUKzZeBofsG/wgccFzO1EO4JtXkm56OBNxQz1I3334zQcjbyixaGXURPoyvAwHkRZHGqLkDR/18YaBQQr1HE/lnkOeE5j/9vyJ2w4F1slY0S8kj+vq92x0qPX02zyDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LiAIaRXs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IjzHII7E; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LiAIaRXs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IjzHII7E" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61HB404E1943469 for ; Tue, 17 Feb 2026 12:34:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RvEfrZDrpuXSo+8UNBbEgYFKbls9A5JiTcAP/1CGaK4=; b=LiAIaRXs6HrgIe0+ 27FH4f1ZJkA90Rn3x5DuZnLxWfb7ctBdh1/h9y3Y6nFB1n7y4u2xewOr1l4VMCLI U+QdDR0jpa1truWImPQNSjcRzZT7En5fDGHU0T6Km88oJSt0MBsOWytfUC4a6XN0 GODy77SLMl/95YPqBphumuirnDZjftkrFL454+ih7VITZXTbMXOlk0Y45NN/lt/2 7Ek5yD8H/OfQs3mAfkLamPiTQM725CLBc5DeV1Xyu/l6eLO0CUCNoAf3+pmAK1AV GjTggxvXufhDb01ph8JhDoM/RtfCP44zkHThjOh8fULjF5M1zKIakjtDetK+GJEJ nll9VA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ccq4g09yf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 12:34:50 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb706313beso9531885a.3 for ; Tue, 17 Feb 2026 04:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771331690; x=1771936490; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=RvEfrZDrpuXSo+8UNBbEgYFKbls9A5JiTcAP/1CGaK4=; b=IjzHII7EObO/TNAnVtNn4YMF0QsywkD5tQko/bGCBvOqNVuvjfQqAo5cL2T6ovVgIZ MSKkjlcWtdF8RBKvMw5lzxLZ0PTvWTb6ZqxufgDsv5kr0T7008cYjcDH/lGD3gy5XUVW 6Yod4jnJzPp093h0LpyjQvHUaaedBv/8RMy0uqgDEwTxx+QeOkv+9+P+LGZbXjTAmAX5 qR/uRbaAPM515xsiYvd0vbsoLoUfSJsJRb3UCc2gCMoFruKS5ipCz9STYXm0jvWaqq6k LYRmVsDIe0v3+14GPBtcjaHPUstnWfNH7ABpJ0p2NRkNgit5WVE8zqQYPxewTV4CUlLn kM1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771331690; x=1771936490; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RvEfrZDrpuXSo+8UNBbEgYFKbls9A5JiTcAP/1CGaK4=; b=LxLBwcKBsz+AEKzc1WqdP4wLbyq3Neruas6kyo0OzAWy7AsouAx4PKgRYbZxqPjS0I 9OkpqOX5AZlOG6DdL8hdxajy1qHycI6ZHvdMhz7CO+B1YXQhJm0ZRBrbq+Rct5bBHa8a ge4jI9jHc8wXuw9myk5wWyHWwF1c10ypD3T3YwjD9TN7oVndGn+WmaTCqq3EVwZGvNoa T+cr/G5VhbiLeAVLYhGDscS5G1jB6xbFT6Aw7bZt+VjmpJkcEYEQTsdpx8cYyGfNm7Xb XBaJBlpwTY8wPEwqYg3VDQx1Q7Gs6I51EYRJjnM7arviChuHJbBVzGWc24zyBExxP7KR HDaw== X-Forwarded-Encrypted: i=1; AJvYcCWSDOVCkNaoLwzugMCJwvwyqTsXkOLIGyLUxlhbbFuMrvmfHK0y/7fsWaAKKFbVyrwlz0HAUz2XT5AFtQs=@vger.kernel.org X-Gm-Message-State: AOJu0YxGnLpQKuBMz6S/oyNXi/flb+zTA2XKjPhr+3ruYlxKQ9lgQ9PF LApo7JLnTJ2PRI8ma6QWMW5g4vVts1fDFrwzndGJqjFs0B56TL721DHVy1aO/UrSa/x1DyJb8a5 gAdJ4y2ruJwKlWx8AxwVzPVgR7NrdXVSSNCv8BtS+2XFs5QVeAGl7WvX/vfhhWjNs0+yTzfIYdN 4= X-Gm-Gg: AZuq6aLL9FgIYFMBDyDrBicue37y2PoU5WdUO1NL3ND8vA9bYTzFZjrRFToenLlTIAw Zh/YQXV+rwb9rsFm2iRC/ve75HJEirBgM2WwBUKWoRUC2boG5I4hIzycS2/M8iVsD4oHkaLVbDm B1pL0v0rJVBQM4TUkfpfPfVO0tUYhwVryBz4Z73NYbObr/jCrN65+5pctij/ySLcK1wFY6KifBG aAwupKzI0D/izwv08mT6sNjZ9TAhJ/MYOrPbG6XSlId6dAHGMmLVLUgf9/1reVZCNZey4st0nMy +mN7BHNYQgRF8VTOZrfIEgvvnKntV5nMDMbC5H3nrOSk8ELcEZEWrhKvJ3v//88sOjj7pgo4IpP mamBWoQ+tGijWUhuK+PN4a+4ctFzKA4oCuBB7c5lOVjP0ProGIw== X-Received: by 2002:a05:620a:1927:b0:892:7dd2:9f0f with SMTP id af79cd13be357-8cb4228d6d6mr1362114385a.19.1771331689730; Tue, 17 Feb 2026 04:34:49 -0800 (PST) X-Received: by 2002:a05:620a:1927:b0:892:7dd2:9f0f with SMTP id af79cd13be357-8cb4228d6d6mr1362112085a.19.1771331689224; Tue, 17 Feb 2026 04:34:49 -0800 (PST) Received: from [192.168.1.29] ([178.197.223.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ac9d77sm31558282f8f.33.2026.02.17.04.34.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 04:34:48 -0800 (PST) Message-ID: Date: Tue, 17 Feb 2026 13:34:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] efi: stmm: Constify struct efivar_operations From: Krzysztof Kozlowski To: Ard Biesheuvel , Ilias Apalodimas Cc: Maxime Coquelin , Alexandre Torgue , linux-efi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260215110628.34293-2-krzysztof.kozlowski@oss.qualcomm.com> <25d66619-23a2-4566-bbc3-83be8eae9d46@oss.qualcomm.com> <5823f778-d422-4190-99bf-d66ffa437f6c@oss.qualcomm.com> <93de9e85-faf1-4394-a374-f9207bd823c7@app.fastmail.com> <3ae05b60-0428-40ec-a6a8-e60395a8dccd@oss.qualcomm.com> Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: <3ae05b60-0428-40ec-a6a8-e60395a8dccd@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDEwNCBTYWx0ZWRfX6cgy88OkAFCr WM55jw34eiD8Qtr4pRg6fyz4FujifmcOI6Ds/R/HREcKHUpdgOaOesNDx3rejpBuhLALQK/eHb7 Lu7YcoyoOchTwa0V+jfbvTEyRKWi6SWapa8NxlJgE46whxnJOGmeRCWySQ1zScLJjh4CsKgVTL/ UWkcDD9qLmlODoH6NOCpINTlG2S6naxiVxu3gVLCgV7z1XDsE/KGtiQ3WF2C3E2KPR8uVCGBQCZ tFR9JC1hf0ij8unrrpTQRR841ilrdp+B6XvlYDTJqVl6bvDhyLZu7zJXIetBvFNIePT/d3DFZ96 47Tj3MqNKhF+A+QnB+TdY3W7WY+gZB4dpz3eGKvlNLV6Y0e0WnDpxT5rtnGo66Y6AqE5jf9f6tt ohcCfM/sairg2OreZXKlvWBXZM6hBMjJwEtpav25XZGV0jzabB8lmYBP6/EIHPEisgMGndZl39d uZmRF16cm9l/CQyOgPQ== X-Proofpoint-ORIG-GUID: wSYvAknqzVbkq2k_b9eU059UR5J20nuf X-Proofpoint-GUID: wSYvAknqzVbkq2k_b9eU059UR5J20nuf X-Authority-Analysis: v=2.4 cv=YdiwJgRf c=1 sm=1 tr=0 ts=6994606a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=6nO30s3o7FuWeffXwhKHTA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=NT1zQuG-P9saifzZ494A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170104 On 17/02/2026 13:25, Krzysztof Kozlowski wrote: > On 17/02/2026 12:30, Ard Biesheuvel wrote: >> >> >> On Mon, 16 Feb 2026, at 12:07, Krzysztof Kozlowski wrote: >>> On 16/02/2026 11:43, Ilias Apalodimas wrote: >>>> On Mon, 16 Feb 2026 at 12:33, Krzysztof Kozlowski >>>> wrote: >>>>> >>>>> On 16/02/2026 10:49, Ilias Apalodimas wrote: >>>>>> Hi Krzysztof, >>>>>> >>>>>> On Sun, 15 Feb 2026 at 13:06, Krzysztof Kozlowski >>>>>> wrote: >>>>>>> >>>>>>> The 'struct efivar_operations' is not modified by the driver after >>>>>>> initialization, so it should follow typical practice of being static >>>>>>> const for increased code safety and readability. >>>>>> >>>>>> get_maintainers doesn't include me in the cc list? >>>>> >>>>> I use only get_maintainers and as you can see no. You might want to add >>>>> yourself as maintainer of this driver if that's your part. Or have >>>>> korgalore/lei filters. >>>> >>>> Hrrm, that's weird. Running it locally returns a more extended list >>>> which includes me and Sumit Garg. >>> >>> You might be using git fallback, but this is not a maintainer. It shows >>> random people either involved or not involved (like cc-ing me on half of >>> kernel drivers), thus it is not recommended for daily use and all tools >>> (e.g b4 or personal scripts) do not use fallbacks. >>> >> >> The code you are touching came in via a different tree in the current merge window, and so this patch doesn't even apply to the EFI tree. Those 'random Heh, and that's not even true. The code I touched came via YOUR tree with your SoB: c44b6be62e8dd4ee0a308c36a70620613e6fc55f and not in the current merge window. I don't what commit you are lecturing me, but I see: "Commit: Ard Biesheuvel > It can wait till the merge window finishes and then it should apply > cleanly to your rc1 rebased tree, no? > >> people' are the ones you should have sent this to, if you had taken the time to look at the history of the code you are modifying. So please don't lecture other people on how to use the tools. > > We are all using the tools. If Ilias is/wants to be the maintainer > (which I support), please add to the MAINTAINERS file, so the tools will > get it right, instead of relying on manual process of finding who > touched something. Contributors should not figure out how the code ended > up in the kernel because it does not really matter. What matters is who > should take it, who is the maintainer. > > This is not a fix, so original author won't be pointed out by > get_maintainer poking at Fixes tag. > >> >> I've queued this up now - I'll send it to Linus by the end of the week. Thanks. Best regards, Krzysztof