From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B8A5223DDD for ; Mon, 6 Oct 2025 10:15:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759745703; cv=none; b=RLGW0WuMweDfnra6einSgneMZ2nhuo7/+hQ3Xbtkkmkhsm/gLMd3YnVrBfMs5JwCAPgIeC7AAPFNXYho3cvMgtuT3J09jh22lxncJdvX1ztcYa5wB8QZbBeEjWx2zN5YzwQSH1TNKac9SI+tYJqsYt5mbNaEYpLWpMhsoDCZQRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759745703; c=relaxed/simple; bh=+lCoSswREYBVYg7PAwHQiojcdE4ZRJ/ZZspRoClzGlA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z4oJ0YgdUQIQKZitpqDmKYiSGdsr2qecutOkzrNII3lMnOOAWBYvcJnd0xCPCv+LqenzCGtbQfwGfsy3qQQ3dNf9fds1dQGegoBL9+ZB8dqMQMPIZt99Kj6P+ENHRnQpYZ6mLxl6X8Yxn9/0dlGKUY2Z7wD7IZQIo6NTJaqVqrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TS8QOqeg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TS8QOqeg" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5960ei3j021746 for ; Mon, 6 Oct 2025 10:15:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aIDY01NnRK3ZSR2DKX1nbVIhaDa8uzVxxaZaHb2mwZs=; b=TS8QOqeguDZh9Glg J+LrqbpRc7WdvzTGHd2wDv3yc0JIh33yU1K6pDcMUhgBdIwB91FQFcRtzlwjMUoj TZtRT0+MPqkwGVvmNAGEWayNV7Ajibq7K+BqxMpIkpKElDvqu18gwLdUf8c9QxMN M0hMBCGtcltvUsiAe01UKg7TSxl+HOAy/qESqIcgUs1gIRyNsL1wIYauPl6LuOrx gOq/8Yh7Avk+/JrRqHTXcQ6ylj9/66sVEekNWYZKJxF2pC6InubI6XUXfcasUrkL /qLeG73Dq1uI117JWtR20D3njYckp2OI2lQFqJIeoQ9WNkxic8lCH/KKoaPw81JO lQHnPg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49juy6ug30-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 06 Oct 2025 10:15:00 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4e0f9bedf1aso15228191cf.0 for ; Mon, 06 Oct 2025 03:15:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759745700; x=1760350500; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aIDY01NnRK3ZSR2DKX1nbVIhaDa8uzVxxaZaHb2mwZs=; b=wbiMfqIl0r8gnK5vZYTCwSKJ59P4C5OXQroI00vuPDFdKxBT3TNBT+uGElhZ9SLL70 X5jSewnOhf/q7t9nBaXyzhOaPT+cUHyM3eZ9wA7fA6Ab/lmZfkKTdUtN6FwvahuPEmEk lZZUru5cWrtKm3eZ5d2dfDeNVH9t2UM+tpdn6VGIYuZXWTzMsSK7LpD31OMhLqPqf5hS s8wHgOyPS7qI86nuO1ZyAQqkR+NrGLo643eQ58z42Icgqpt1DrgLzjWk0QDRLE1XZ3fd IqR/F3TUc0yhjOzw6lrFaAwUveey9IKKUgXR2PAp2yF+o5NyLmDqpGGqBvpbcu5ydz/I Zl7w== X-Forwarded-Encrypted: i=1; AJvYcCX2vN6vGxOx95ECZ88hnJYsxddg3rVWNVMheuDAvKFgEBWEAiKIv2F+RDEse3qzQXQAYgcJPYLSuZul+Lg=@vger.kernel.org X-Gm-Message-State: AOJu0YwSf816hyBLnLnbsNMHnZ3/8FY4D1DEp29yVudfbemockTWzYLg C4FeP5GHWP/pJkpQVwckYKCKEeJfGaoAzwRchFe/hQkpLyIF73Cdyn4NpbEzlOdMOUwpx/R4zsa RU9z0hH+M01Xf863Zt+9IcZ/C60EVaUFeDG+B9qkXUQMdjGM62u8wgaHTmh0jIZZPMRU= X-Gm-Gg: ASbGncsvWugiJPucX2ZZXLCorw6obyTLf9viBeM5DAAyUzHXAPBE9rUYAS/fVHv+4xG YvvE6b30ntceve2u81j7JPhifk87+JjN7GZL10X9A2EbCnFMzxaQY693IcZvh1BedfybSFThhBp 6zCxVGn62H9JNBbaMCTBAF9lNrAlVw0AzTrCluVz6Vmgwrt5XCQdHIHGzRNINfyqE0TQjpc4WZi AealXmsOiGUn8SZMA7DzXJfC9wsxxlFnORG8D3/C7Xp62wl6/giaESfaCGkL67mQ64rd9uWyDui oL+se8WCoX8xG3KC4nPGxGDpEeR8sE0aXZa7h7GRuq6trTiaKXu1jTtjdLNqIVrxSBMOcmV8L79 g/a+iy4Fuuh0UZYDuCYH62cUcWa0= X-Received: by 2002:ac8:7f55:0:b0:4b5:e9b6:c96 with SMTP id d75a77b69052e-4e576a6332amr88117911cf.7.1759745700015; Mon, 06 Oct 2025 03:15:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGBeef8DRHG2bi/HP7Cc1oF7kqYny/jUEdyQyquytu8JqFxYlckOVY1l/33cLCYd16NUFWYmw== X-Received: by 2002:ac8:7f55:0:b0:4b5:e9b6:c96 with SMTP id d75a77b69052e-4e576a6332amr88117651cf.7.1759745699533; Mon, 06 Oct 2025 03:14:59 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b486a177c62sm1096835866b.91.2025.10.06.03.14.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Oct 2025 03:14:59 -0700 (PDT) Message-ID: Date: Mon, 6 Oct 2025 12:14:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] soc: qcom: ice: enable ICE clock scaling API To: Abhinaba Rakshit , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org References: <20251001-enable-ufs-ice-clock-scaling-v1-0-ec956160b696@oss.qualcomm.com> <20251001-enable-ufs-ice-clock-scaling-v1-1-ec956160b696@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251001-enable-ufs-ice-clock-scaling-v1-1-ec956160b696@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=IrITsb/g c=1 sm=1 tr=0 ts=68e396a4 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=EUspDBNiAAAA:8 a=7E7N79Lt4lT18EohOwQA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: zMer-CjayxDKnNIxrHH6SAh6dY7-cy4G X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDA0MDAyOSBTYWx0ZWRfX2Nk6g9RR4+T7 kKyTo3240XaZToDSF69NLF1E3VJ/HPTNwR/PfLRbqeASeTOqE70fEkN7zJTc/0NRrTk02zQJNzQ ECsG2oJ0zeyJ8gEM1Ede9BaUa6e/S6I/PBwjI7k1KVtiy0ANd7wL+6sKls38YwhT0ZNErGdgc4C +OvNLe5cpsOXUsAL7NFfAo0up4hdWe4h7HcY45f6sPMtmQvf83mdGqmx6w5nVN2gJNKCs12bL3X KHLOk/CDeZoLplTp705iYr4W/Svg3CHn6syo1cH7/oSpZHgHalCJB+HUwlLr9G3btCX0kdNOZDD O9jJt9QP9W3tJ21q5IPe9MR7i5ekeo1UT6UCLmoAfNXnlKy5Z8vz8dV+j4r8Bpu+Bpm3y6yUv1A tI6Gu0UkNd4DsTNVbk4gKanqMGC9XQ== X-Proofpoint-ORIG-GUID: zMer-CjayxDKnNIxrHH6SAh6dY7-cy4G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-06_03,2025-10-02_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2510040029 On 10/1/25 1:38 PM, Abhinaba Rakshit wrote: > Add ICE clock scaling API based on the parsed clk supported > frequencies from dt entry. > > Signed-off-by: Abhinaba Rakshit > --- [...] > + prop = of_get_property(dev->of_node, "freq-table-hz", &len); > + if (!prop || len < 2 * sizeof(uint32_t)) { > + dev_err(dev, "Freq-hz property not found or invalid length\n"); > + } else { > + engine->min_freq = be32_to_cpu(prop[0]); > + engine->max_freq = be32_to_cpu(prop[1]); > + } As I suggested in , you should really use an OPP table if you want to do any sort of clock scaling here. There are then nice APIs associated with that construct that won't make you pull your hair out.. Konrad