From: "Arnd Bergmann" <arnd@arndb.de>
To: "Amirreza Zarrabi" <amirreza.zarrabi@oss.qualcomm.com>,
"Julian Braha" <julianbraha@gmail.com>,
jenswi@kernel.org
Cc: "Sumit Garg" <sumit.garg@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
amirreza.zarrabi@oss.qualcomm.org,
op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org,
"Elliot Berman" <quic_eberman@quicinc.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Harshal Dev" <harshal.dev@oss.qualcomm.com>
Subject: Re: [PATCH v2] tee: remove TZMEM_MODE_GENERIC
Date: Tue, 04 Aug 2026 09:40:28 +0200 [thread overview]
Message-ID: <a2c4c420-d7df-4fad-a952-e77192e1822b@app.fastmail.com> (raw)
In-Reply-To: <63cfff1e-359b-4db9-97a8-43d97abb0369@oss.qualcomm.com>
On Tue, Aug 4, 2026, at 06:29, Amirreza Zarrabi wrote:
> Hi Julian,
>
> With this change, is QCOM_TZMEM_MODE_SHMBRIDGE still needed?
>
> I think QCOM_TZMEM_MODE_SHMBRIDGE can therefore be removed entirely,
> along with the conditional declarations and stubs in qcom_tzmem.h and
> the corresponding select in the qcomtee Kconfig.
Looking at it again, I see that the patch does not actually do
what I had expected. As you say the option no longer has any
effect at all, when I thought the tzmem driver would just default
back to generic mode without shmbridge being enabled.
What we probably want here is to change it to
#ifndef CONFIG_QCOM_TZMEM_MODE_SHMBRIDGE
...
#else
...
#endif
to keep the behavior unchanged and just fix the Kconfig logic.
Arnd
prev parent reply other threads:[~2026-08-04 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 20:38 Julian Braha
2026-07-29 20:44 ` Arnd Bergmann
2026-08-04 4:29 ` Amirreza Zarrabi
2026-08-04 7:40 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2c4c420-d7df-4fad-a952-e77192e1822b@app.fastmail.com \
--to=arnd@arndb.de \
--cc=amirreza.zarrabi@oss.qualcomm.com \
--cc=amirreza.zarrabi@oss.qualcomm.org \
--cc=andersson@kernel.org \
--cc=brgl@kernel.org \
--cc=geert+renesas@glider.be \
--cc=harshal.dev@oss.qualcomm.com \
--cc=jenswi@kernel.org \
--cc=julianbraha@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=quic_eberman@quicinc.com \
--cc=sumit.garg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®