From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C60733AFAEC for ; Tue, 12 May 2026 14:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778595467; cv=none; b=DfKt+nk7G3e+mq6BXVnUXIdmYofZv/atG4zTf+yho8u22vOM0lDFDXYKalDtRKkZ2PBQ4syTSX8RkCr607ScOm4NwDLmTxh+QWka46LP9K6MZ8aIesjJWNlZBSwxGHazPC7fC8K1/VJXeuV+nVk/Lz1ybUEvwdZze9eoDA4qIAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778595467; c=relaxed/simple; bh=NVggfJLPOArhx8otVfCM2tXZ5uP0At3kls0Rgg9Ls2o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PfZaPo27aWldiXxjC8dzQISjOS2cwssxRnyX5CNRkMfPZWKw0bxVmM1jIdGsvtUlbbMCYVjz7Uztt+SuKyuDJUzg41nGc6ccsBl57NifsMH1dGj61l7jYr/gu1f4zRovvLJmqtgEc5Zz+VudociUgr/CCRx0e63RQj59+NeLMrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=IKKoP8MZ; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="IKKoP8MZ" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488a14c31eeso38866885e9.0 for ; Tue, 12 May 2026 07:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1778595461; x=1779200261; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=ir04jsaDaoE/Fgj2pkJq5xz4Zo9Hfr5WjmH+ZtcvAI4=; b=IKKoP8MZhvVVK7sCrTAljPeObZPRzoHEvHEm4lrHtAwmVbNF74UqWRmWLjGjbErxBE +Asn6dUOLn9163uNanfMkX/YZQllKRMzaiPlLyiRoOEb3dfWwdEfDifV/uugQgKHhngY h+oBX4GkTwo9bypSAIv2HUrng7Y0rk7R7JTd+9p1dN+PXs7LhmW8HfuKyZWdriKdwtRV iuTkszaf8jsT0n+sFBaat0ahyxTN0X+8BSA5ArUf9rkyplaJnYItETXYfeCAes+d9swB pijRPBvvEM3828YtkeM0iW46CzJ/36id1uKO/ITus4XkP/K3zI5CPSBp3bFSxgUJigmX 8E7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778595461; x=1779200261; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ir04jsaDaoE/Fgj2pkJq5xz4Zo9Hfr5WjmH+ZtcvAI4=; b=qDroVKudpYqNSdU9/a+C7lNGD9zq5zfVzyZNL1+CZmHoGy1crkbZdeIKBlH8Z+UD7o Lw3yXwrJDeWelj7ylBY3OqjajSbHNjP/GX2GC3OE9/8LnaIpqrljPDnGauv7cw51kGOu zNRYhLm+kyp4pzvM1qhIhC+fNOeIXMAKwRY5ftSXcFFo+pUF/l9vyjsUdNwRrOwKXMip VwVPBppIH5fmzswBFfpErwtt2i7rxjEYO+/EfaH04ez7h6TUmpjLQ69K954ZNENC2JLP 2n/HZpH/hqoMfVXVTfY+S2yNBr0U18N3iylxHe5rocazEHW55jr5X1qEngE3wpHL5I5F pX7Q== X-Forwarded-Encrypted: i=1; AFNElJ9XCV7+/oAmY+xFLzV72gICl8Vxg2rtq1xytJCn77chY2Y/npeJ7VlTHCkuHPyT82j4DEV1KEpdv2Rr1lQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyTyDIFVR9xqsG29n792LmHX8s5atpi72mKUwngwe6SfOBk/vbx OJAOmLOMCj2wqGfTv70pLRK4V43nRmlnoXS9KkD/B8dTtBAADWd9vdqCZO2ySgjNTKWVgrDT1qY E4L6WKYOD1VnSjB0s02GElmVlgTCDbAzrHBXTckoKvESJ9i8JiYvmiUBTDZ0= X-Gm-Gg: Acq92OH220FRn9UkqY4jvwqPAsyKPBIrbOoqn3hLqwBa+UHAY6Z9aciF/30ibufYx/4 kIpl8B74zEztRfnaRrdgSifGh1KtfBQg9JXDwlou/0HlyEDLnlsIytyW1DkARRTO9O/WjJ+xHJ+ zAYe77YYs9hVeyEbx3XL7vQafCKfhZmItUmGf/K9rOjtHoJl47qNsvC0vETWYsCXaL16UIglv86 hVW8IHKjBxsuH7G/zhr2jBDD4XPm77edsTWVL0LmiSjb3ZZyOv5/zs+6yVSJ7/HkVIOT1oIMbMv Y1EiZJsmk7tV4j3y5JSjm7jCGXT7bQDcMWQ2NfADazgxUg2LCmaB66RFZ1uRizD1X73KzmEwvS1 7MGUxS2wCE9m96r0EZwvr1qSYFIlYSQLcbb+4BK6KcN2uKRQ6h/1xdFmIDU1SOh2KmiOxN8ocga z0McMZDLpX29ghYlGxMd1fRT3l0+ksql5aswqxop7EaT8dZVfDM92d9il5R5SURoXlwrV0i3Zk X-Received: by 2002:a05:600c:524e:b0:489:1d74:56d with SMTP id 5b1f17b1804b1-48e676c14b9mr297461955e9.29.1778595460908; Tue, 12 May 2026 07:17:40 -0700 (PDT) Received: from ?IPV6:2001:67c:2fbc:1:7245:d44f:b95f:a2c6? ([2001:67c:2fbc:1:7245:d44f:b95f:a2c6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e8f3cf0cdsm34893875e9.2.2026.05.12.07.17.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 07:17:40 -0700 (PDT) Message-ID: Date: Tue, 12 May 2026 16:17:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 1/2] ovpn: tcp - use cached peer pointer in ovpn_tcp_close() To: Sabrina Dubroca Cc: David CARLIER , Eric Dumazet , netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org References: <20260512042036.19870-1-devnexen@gmail.com> <20260512042036.19870-2-devnexen@gmail.com> <4ff6590a-6695-4c6c-b677-a7891b249165@openvpn.net> Content-Language: en-US From: Antonio Quartulli Autocrypt: addr=antonio@openvpn.net; keydata= xsFNBFN3k+ABEADEvXdJZVUfqxGOKByfkExNpKzFzAwHYjhOb3MTlzSLlVKLRIHxe/Etj13I X6tcViNYiIiJxmeHAH7FUj/yAISW56lynAEt7OdkGpZf3HGXRQz1Xi0PWuUINa4QW+ipaKmv voR4b1wZQ9cZ787KLmu10VF1duHW/IewDx9GUQIzChqQVI3lSHRCo90Z/NQ75ZL/rbR3UHB+ EWLIh8Lz1cdE47VaVyX6f0yr3Itx0ZuyIWPrctlHwV5bUdA4JnyY3QvJh4yJPYh9I69HZWsj qplU2WxEfM6+OlaM9iKOUhVxjpkFXheD57EGdVkuG0YhizVF4p9MKGB42D70pfS3EiYdTaKf WzbiFUunOHLJ4hyAi75d4ugxU02DsUjw/0t0kfHtj2V0x1169Hp/NTW1jkqgPWtIsjn+dkde dG9mXk5QrvbpihgpcmNbtloSdkRZ02lsxkUzpG8U64X8WK6LuRz7BZ7p5t/WzaR/hCdOiQCG RNup2UTNDrZpWxpwadXMnJsyJcVX4BAKaWGsm5IQyXXBUdguHVa7To/JIBlhjlKackKWoBnI Ojl8VQhVLcD551iJ61w4aQH6bHxdTjz65MT2OrW/mFZbtIwWSeif6axrYpVCyERIDEKrX5AV rOmGEaUGsCd16FueoaM2Hf96BH3SI3/q2w+g058RedLOZVZtyQARAQABzSdBbnRvbmlvIFF1 YXJ0dWxsaSA8YW50b25pb0BvcGVudnBuLm5ldD7Cwa0EEwEIAFcCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AYGGhrcHM6Ly9rZXlzLm9wZW5wZ3Aub3JnFiEEyr2hKCAXwmchmIXHSPDM to9Z0UwFAmj3PEoFCShLq0sACgkQSPDMto9Z0Uw7/BAAtMIP/wzpiYn+Di0TWwNAEqDUcGnv JQ0CrFu8WzdtNo1TvEh5oqSLyO0xWaiGeDcC5bQOAAumN+0Aa8NPqhCH5O0eKslzP69cz247 4Yfx/lpNejqDaeu0Gh3kybbT84M+yFJWwbjeT9zPwfSDyoyDfBHbSb46FGoTqXR+YBp9t/CV MuXryL/vn+RmH/R8+s1T/wF2cXpQr3uXuV3e0ccKw33CugxQJsS4pqbaCmYKilLmwNBSHNrD 77BnGkml15Hd6XFFvbmxIAJVnH9ZceLln1DpjVvg5pg4BRPeWiZwf5/7UwOw+tksSIoNllUH 4z/VgsIcRw/5QyjVpUQLPY5kdr57ywieSh0agJ160fP8s/okUqqn6UQV5fE8/HBIloIbf7yW LDE5mYqmcxDzTUqdstKZzIi91QRVLgXgoi7WOeLF2WjITCWd1YcrmX/SEPnOWkK0oNr5ykb0 4XuLLzK9l9MzFkwTOwOWiQNFcxXZ9CdW2sC7G+uxhQ+x8AQW+WoLkKJF2vbREMjLqctPU1A4 557A9xZBI2xg0xWVaaOWr4eyd4vpfKY3VFlxLT7zMy/IKtsm6N01ekXwui1Zb9oWtsP3OaRx gZ5bmW8qwhk5XnNgbSfjehOO7EphsyCBgKkQZtjFyQqQZaDdQ+GTo1t6xnfBB6/TwS7pNpf2 ZvLulFbOOARoRsrsEgorBgEEAZdVAQUBAQdAyD3gsxqcxX256G9lLJ+NFhi7BQpchUat6mSA Pb+1yCQDAQgHwsF8BBgBCAAmFiEEyr2hKCAXwmchmIXHSPDMto9Z0UwFAmhGyuwCGwwFCQHh M4AACgkQSPDMto9Z0UwymQ//Z1tIZaaJM7CH8npDlnbzrI938cE0Ry5acrw2EWd0aGGUaW+L +lu6N1kTOVZiU6rnkjib+9FXwW1LhAUiLYYn2OlVpVT1kBSniR00L3oE62UpFgZbD3hr5S/i o4+ZB8fffAfD6llKxbRWNED9UrfiVh02EgYYS2Jmy+V4BT8+KJGyxNFv0LFSJjwb8zQZ5vVZ 5FPYsSQ5JQdAzYNmA99cbLlNpyHbzbHr2bXr4t8b/ri04Swn+Kzpo+811W/rkq/mI1v+yM/6 o7+0586l1MQ9m0LMj6vLXrBDN0ioGa1/97GhP8LtLE4Hlh+S8jPSDn+8BkSB4+4IpijQKtrA qVTaiP4v3Y6faqJArPch5FHKgu+rn7bMqoipKjVzKGUXroGoUHwjzeaOnnnwYMvkDIwHiAW6 XgzE5ZREn2ffEsSnVPzA4QkjP+QX/5RZoH1983gb7eOXbP/KQhiH6SO1UBAmgPKSKQGRAYYt cJX1bHWYQHTtefBGoKrbkzksL5ZvTdNRcC44/Z5u4yhNmAsq4K6wDQu0JbADv69J56jPaCM+ gg9NWuSR3XNVOui/0JRVx4qd3SnsnwsuF5xy+fD0ocYBLuksVmHa4FsJq9113Or2fM+10t1m yBIZwIDEBLu9zxGUYLenla/gHde+UnSs+mycN0sya9ahOBTG/57k7w/aQLc= Organization: OpenVPN Inc. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/05/2026 16:11, Sabrina Dubroca wrote: > 2026-05-12, 15:55:39 +0200, Antonio Quartulli wrote: >> Hi, >> >> On 12/05/2026 06:56, David CARLIER wrote: >>> Same multi-read pattern shows up in ovpn_tcp_recvmsg(), >>> ovpn_tcp_sendmsg(), ovpn_tcp_data_ready() and ovpn_tcp_write_space() >>> - happy to roll those into v2 as well, or punt to a follow-up, >>> whichever you'd prefer. >> >> @Eric, if you have no objection, I'd pick this patch up in my tree and let >> David follow with a new patch for net-next. > > But this patch is not fixing any problem either, right? Mh, because the sock outlives the peer, so there is no risk in accessing sock->peer in this case, right? > Then just wait until David sends the whole change at once? Yap. > > And since the "rcu_dereference_sk_user_data + !sock || !sock->peer || > !ovpn_peer_hold(sock->peer)" pattern is used multiple times, it would > be better to turn it into a helper (ovpn_tcp_get_peer()?). That way > the caller can't be tempted to play with sock->peer. > > (also, please wait at least the usual 24 hours before applying) ACK Cheers, -- Antonio Quartulli OpenVPN Inc.