From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from irl.hu (irl.hu [95.85.9.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 927EE21505C for ; Thu, 24 Apr 2025 09:11:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.85.9.111 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745485907; cv=none; b=PsoC3KD9s4o8CPcYbiya4oGQrwbu76tyNFy09CpVih8ob8EVwAfqsDyYWVcoE4witwkZ2/nNnBjAWNx9cb5YqdR/sjAp7y8NzSYT6OVpuMWgdGXLM7LMbY2vCeHwzq4UE+HaI3ehtf95dkafJxPgWq2ezL0hiLUxgv2UXFHZW9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745485907; c=relaxed/simple; bh=GktCEw93LWx29fKSfCeGp2sL+s4pz8Hwysuvj+LEd4I=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=OfW079Fg2KaNLLZn+6jQkGYNVOYsjP/nOyfQCCX9ftY6+Jq6B30gnYaFxJ/hcCQ8Ma3FdNyVdIpVe627B2JdK9og9y4WUiJChWSRAVK3OHWYMKXEvuQ3VCrdgCp6kko+7i+4yL7rFN5NxmCjmASFpqFS4Mv/CRAj3PoTSqNVhoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu; spf=pass smtp.mailfrom=irl.hu; arc=none smtp.client-ip=95.85.9.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=irl.hu Received: from [192.168.2.19] (51b69338.dsl.pool.telekom.hu [::ffff:81.182.147.56]) (AUTH: CRAM-MD5 soyer@irl.hu, ) by irl.hu with ESMTPSA id 0000000000084239.000000006809FF1B.000C6449; Thu, 24 Apr 2025 11:06:34 +0200 Message-ID: Subject: Re: amdgpu_dm_connector_mode_valid regression From: Gergo Koteles To: Marek =?ISO-8859-1?Q?Marczykowski-G=F3recki?= Cc: Dmitry Baryshkov , Dmitry Baryshkov , regressions@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Hans de Goede , Alex Deucher , Mario Limonciello , Alex Hung , Harry Wentland Date: Thu, 24 Apr 2025 11:06:34 +0200 In-Reply-To: References: <8963a409dd575e040e5f07e4ad5e9c1d26b421f2.camel@irl.hu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Marek, On Thu, 2025-04-24 at 10:48 +0200, Marek Marczykowski-G=C3=B3recki wrote: > On Fri, Apr 11, 2025 at 12:01:28PM +0200, Marek Marczykowski-G=C3=B3recki= wrote: > >=20 > > Hi, > >=20 > > On Wed, Apr 02, 2025 at 04:35:05PM +0200, Gergo Koteles wrote: > > > Hi Dmitry, > > >=20 > > > But the code would start to become quite untraceable. > > > duplicate mode in amdgpu_dm_connector_mode_valid() > > > call drm_mode_set_crtcinfo() in amdgpu_dm_connector_mode_valid() > > > duplicate mode in create_stream_for_sink() > > > overwrite ctrc in decide_crtc_timing_for_drm_display_mode() > > > if crtc_clock =3D=3D 0 call drm_mode_set_crtcinfo() again in > > > create_stream_for_sink()=20 > >=20 > > FWIW I'm affected by the same issue (on HP ProBook 445 G7, with AMD > > Ryzen 5 4500U). And the patch quoted below fixes it for me too. >=20 > I've re-tested it with 6.15-rc3 and the issue is still there. Is there > something I can do to help fixing it before final 6.15 is out? >=20 This patch has been accepted into the the amd drm-fixes-6.15 branch, so hopefully it will be fixed in 6.15-rc4. https://lore.kernel.org/dri-devel/24439c13a014e1cd200785db6f3dcf08f4773eb3.= 1743612701.git.soyer@irl.hu/ https://gitlab.freedesktop.org/agd5f/linux/-/commits/drm-fixes-6.15 Gergo