From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 963683A9DA1 for ; Tue, 7 Apr 2026 11:09:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775560191; cv=none; b=YCfI/C3+hzmrknggjgysxS1TV5/FbekOpXhRcYglaCoNRpwcH/wLOEYkfnGribiqf5gN0HsRW5Id4SqqUkA1y3DsbBmK5j8M8Uyada8EUSS6K24+8Oa1VP0YMdbppQgJ0uL/4QOCjRLTR8HEykLNQf/jvBplYu6FtsImTiIQ/Y8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775560191; c=relaxed/simple; bh=6GAyjq/gQbQzlatX5AvAy9PCMUY6k/966rJsfggjNd4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nCeapdlzXqNusIvOovk5ct6EqmGMVarKkgp0kT0iv+NVjZ3ns8ZIq+LDSCfrynusWcHHfbjJ7SPpK+KqLQubMod01AlHrsSgQjXnfwr9px0TBT+9Why5CrO29c9pKQmrlYeqtc8rGO0g/kvrMXyOoymuI5YQtTjtDNHuikBOqp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PSbQ8xt6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ikROfZgX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PSbQ8xt6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ikROfZgX" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6376d5ht1584282 for ; Tue, 7 Apr 2026 11:09:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6eiccQO/e38UrZ6Zd4wBRS4N1jpEVerQAlu0qR352HE=; b=PSbQ8xt6vfHjLk/T 6rE4KjXDYII7BcW9mZcFNICoDGuszI0WijhVva48m2jWbtSAITuaLcr4q7EEd2bX 9hNg//XueEHZPkejgpSBq4ecniR6QN2zAlwYWwmlhj5/zQH0+OItHPEb2AvnXqv5 LeSaDPm7fXCu6o60sT8CjQYiL3vbaFJgzIyDHTPmz9Lxfrg+mRBnFxrL7QRVMand QdkZHGniJywuTInzYB6WNU5vF0icdwNGLLo5maIdeYRFaCrjwJQTrSy5MhQH+Qod JMwNswtNd6ivgrHP3WtEDDKlwjAHKq+3AoPzCcFF7c3sZVAOYO+ReX9ZzQfDAcWi 3l9t1A== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmr9te8q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 11:09:48 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b0c96f5d9aso59434225ad.3 for ; Tue, 07 Apr 2026 04:09:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775560188; x=1776164988; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6eiccQO/e38UrZ6Zd4wBRS4N1jpEVerQAlu0qR352HE=; b=ikROfZgXPHc/cHbiXvhFlJJypWYTXxFW7vTZpSE/Ol7ohUKei7N37HJ867zBeZDUje sD0pshXPbRSvOXiRMMuEs6HF7xvGxT0dCUD8hziutRsK8Q0xu0vfR28rn59HntzR4zWI w1h/TYCS5TP7wXIitv0veCyKpo/r5XHW09iBOV5sA1IJkCVlbsPXGOKPFMc2Q35Y4vET XCgFDYzC6urHSDHWHTrDXEOi8ASX7vh4NaZtfuGOBtR3+LB3Ouj09YJ8H310GLUeUWqr fgmNSN2p4zWrWRQR52Xa93fnVrWRbxg+uvE7bPAnvT7gTZoM6cfUNSatkJ9B4HLbXX+N vpkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775560188; x=1776164988; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6eiccQO/e38UrZ6Zd4wBRS4N1jpEVerQAlu0qR352HE=; b=s0eB34oo8VwBr4kKyUvQYoHS5qaqLMlbdE12/dAuPEu4yWT1UuQTTbfkWb7T4+Pllq fyX/SJzSjCu89lSjAXMnhqOpHxPtTuVWPZ7AoDFt9CqevhMMl1+JQtlUFGl7MYkdO08J 6ATdggzM25Btx1L80hauBx3kWVl6sMCD9V3Qj0/Ly+gwKKyK/JumVovOHEy6S5vyOkkv BlwBuEGsNTQUGV303eT/9r2fnjlt0ftZPZ9P1Vkkek1vZtVOVSonhW1Z+BbaiBlSkRwn bwI9svcU7sZWf9WCGqyIYQkoCvQB2Th2dgMvkRmY59t7sUzMTMpS9Od3mHPOjMC4FmZV AT9w== X-Forwarded-Encrypted: i=1; AJvYcCVe+pqbuMxWL5lk/DGzgUJ6bWwmWOHM4WFWA1FBUaPxd7n3RM6WmERK4LVbBzcO/mU7xJN5c128crDIoyE=@vger.kernel.org X-Gm-Message-State: AOJu0YxIIGgCkPwCr6qk84bYcLazRhsw9TpWa+I+bXmktCbaY7tX3Om7 Q7fdW7m9M2QkwpqBSKK/E27Vt+y96O9adJxEM0WPzJ6U8izlBZrFNaVeBmtehMR2ECSAaC8AMtP XAmaKaTdG4AL0JEY2Dy+OyxYz9rc0o8/aXRlu7Ld/4QTd+FbF/OH4JBt5ghLuJ7L4smQ= X-Gm-Gg: AeBDieuzWlZOzQyom4OGOH1dtAIExahGis3tKkQcZA1kuU8S73RMweCW/j5Qs2V9nAX d2WuaVu8UHJM7IZUyqAlb1VCuvfPpbBcoDJV54J/vPRuiIMUe368VgPtPyGotlfuP9viCJO/oOq d+0JXXcTcVDO3up50bzhiYz3BePfmO1g4KvxelQqk0qnk/D9lIipGbDsQ83fki/1Wcq43yIbDbc OVCdKDyYvd5nf8Z4Kf1zcgDeOgbIKi6+ZOmfZvH5uFYFUzYAEZAU7yTVYNzLqyMS8LI8WyQuRAv jZPEgupDutWFXEBBLDVp0eE4JN1JQIA0kXQwcwNnrf2W5d5zPkAx6Zpxz0+u0poHA0PoyIuSYZ4 00XSq9bwpTwizgnv2DnK/1WGNaZXPPW+b7IVl9CUxIDOC5Z6/Wg4Z X-Received: by 2002:a17:903:b45:b0:2b2:54c1:2067 with SMTP id d9443c01a7336-2b2816f3dd3mr166178265ad.21.1775560188289; Tue, 07 Apr 2026 04:09:48 -0700 (PDT) X-Received: by 2002:a17:903:b45:b0:2b2:54c1:2067 with SMTP id d9443c01a7336-2b2816f3dd3mr166177925ad.21.1775560187819; Tue, 07 Apr 2026 04:09:47 -0700 (PDT) Received: from [10.217.223.92] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76c65a3f08sm15510846a12.31.2026.04.07.04.09.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 04:09:47 -0700 (PDT) Message-ID: Date: Tue, 7 Apr 2026 16:39:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: kodiak: Add iface clock for ice sdhc To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260406-ice_emmc_clock_addition-v1-0-e7b237bf7a69@oss.qualcomm.com> <20260406-ice_emmc_clock_addition-v1-1-e7b237bf7a69@oss.qualcomm.com> <8ea92c00-56ca-47cd-95aa-dbf49ecf4118@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <8ea92c00-56ca-47cd-95aa-dbf49ecf4118@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=SMdykuvH c=1 sm=1 tr=0 ts=69d4e5fd cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=yChZgWpjsVOoaIn_3ooA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDEwNCBTYWx0ZWRfX1TJwNr4PP9Xa 4rky54DxcqcjxDJlxndyT+69S16B5gq4IHpuXJATojHD7CWT57kGKA5PRuTC7lM/Dw7iJiVyE3E erXrvLEdFDaWYXatJ+5vGzTTdxxrvRcZoLo7IQRviMoRMgLT1MlccgUE2NHy9g93mqHTkQ4ZmV3 nCatSFt6/52oy3oElY5wJXKcSxRuSkAqdy2Svicuehwv+zCiN8eM72srbNVZbsY5tF8Xd/UPHD1 jq6mO9E1AGiCRK86N9fxWQIv22JqK8Cj055Qvnw9LOGJpgw770oqZ2Rusgp/RDdm9KaM5puL5/u w51AuFMZtYI1bwHgLGGwSZ9s+gWuiP7Y1pt1Iy7T8JSTDQfGPRiS+xmt3rawW7iTF+p0P1TViSG 255Ue+poD22BzFfxpasWP2X4/zWJZQb6lnE+bEPfOf4NbMPXQbatZ5uxU1o8hNswnjzK4Mcrpeo 6CceigAe5BH+RyMl3Kg== X-Proofpoint-GUID: XzqQuheaUivHs4KIBb_tZxIrRvCQdL8x X-Proofpoint-ORIG-GUID: XzqQuheaUivHs4KIBb_tZxIrRvCQdL8x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070104 >> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi >> index dda4697a61b7..5e6b659e8719 100644 >> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi >> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi >> @@ -1082,7 +1082,8 @@ sdhc_ice: crypto@7c8000 { >> compatible = "qcom,sc7280-inline-crypto-engine", >> "qcom,inline-crypto-engine"; >> reg = <0x0 0x007c8000 0x0 0x18000>; >> - clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>; >> + clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; >> + clock-names = "core", "iface"; > > nit: one a line would be preferred, please fix that up as you seemingly > need a v2 anyway Hi Konrad, Didn't get your comment completely. Do I need to send v2 to just fix clock entries in 2 lines? Or some other comment to address and send v2 for that? I don't see any other comment on patchset to address. Kindly clarify. -- Regards Kuldeep