From: "Dong Feng" <middle.fengdong@gmail.com>
To: "Andi Kleen" <ak@suse.de>,
"Nick Piggin" <nickpiggin@yahoo.com.au>,
"Arjan van de Ven" <arjan@infradead.org>,
"Dong Feng" <middle.fengdong@gmail.com>,
"Paul Mackerras" <paulus@samba.org>,
"Christoph Lameter" <clameter@sgi.com>,
"David Howells" <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: How is Code in do_sys_settimeofday() safe in case of SMP and Nest Kernel Path?
Date: Fri, 29 Sep 2006 22:33:54 +0800 [thread overview]
Message-ID: <a2ebde260609290733m207780f0t8601e04fcf64f0a6@mail.gmail.com> (raw)
Hi, all,
I got a question, that is, I am confused by the following code in
do_sys_settimeofday().
if (tz) {
/* SMP safe, global irq locking makes it work. */
sys_tz = *tz;
if (firsttime) {
firsttime = 0;
if (!tv)
warp_clock();
}
}
For my understanding, an assignment between structs should be a
bit-wise copy. Such operation is not atomic, so it can not be supposed
SMP-safe. And the subsequent test-and-assign operation on firsttime is
not atomic, either.
If the comments mean the subsequent code is SMP-safe and can prevent
nest-kernel-path, how does it achieves that?
Thank you in advance.
Feng,Dong
next reply other threads:[~2006-09-29 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 14:33 Dong Feng [this message]
2006-09-29 16:05 ` Christoph Lameter
2006-09-29 16:16 ` Dong Feng
2006-09-30 14:37 ` Nick Piggin
2006-09-30 15:03 ` Andi Kleen
2006-09-30 17:13 ` Christoph Lameter
2006-10-02 10:08 ` Samuel Tardieu
2006-10-03 8:03 ` Pavel Machek
2006-10-03 10:03 ` Andi Kleen
2006-09-30 16:09 ` Dong Feng
2006-09-30 17:26 ` Christoph Lameter
2006-10-01 3:48 ` Nick Piggin
2006-10-01 12:22 ` Dong Feng
2006-10-02 10:12 ` Samuel Tardieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ebde260609290733m207780f0t8601e04fcf64f0a6@mail.gmail.com \
--to=middle.fengdong@gmail.com \
--cc=ak@suse.de \
--cc=arjan@infradead.org \
--cc=clameter@sgi.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®