From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-32.mta1.migadu.com [95.215.58.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DFF526FD97 for ; Mon, 17 Aug 2026 03:08:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786936083; cv=none; b=Zf+Q3fGk2L59q4im5vCNbflL984Yb2Ob0ev6AEcKkVseDZNITKdHyy/d5Wh6rDSS/Rut1+Y+rrX8Z33qT//4f+f2fKnLYrAEHxf6Vw6cb+jPW4gszJOQBOdxKhZGPFdIPUq9LU5/sbAoKjPm1DijX5pOm3xPEFV1hctzTMi7NGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786936083; c=relaxed/simple; bh=BxW4UAvk2xb0ecZRGZbpgODOejmvGyOqgKfMelcZ780=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZgmozHvQ74mofPotw6DdWG9bTYknfklKmv/RZonvNwPP8uTFwfG6mV19ghbV9n8EUMo4B2EwmdcJXKxAoJoEoWgw2Pqf2ZEhcJ+pNaXGfDoh1C0PIupYhyL9oNYWRwRbOhebD4vvtdpgdY9uKz1mf666NSJ24gBipbIIWJHMAsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=vYDg/dDJ; arc=none smtp.client-ip=95.215.58.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="vYDg/dDJ" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=BxW4UAvk2xb0ecZRGZbpgODOejmvGyOqgKfMelcZ780=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1786936079; v=1; x=1787540879; b=vYDg/dDJziUeP8QkyWYwysiyoKIJ0KXZtEl+RlDhvx61EcwjuJwlfxmKoMYSX5DnxmBIU1Ee AfuU+xhqB0XtC/EdAki5buYqJzU54ZcVMxdGXpMbqfwXSE8S4BUrKalqUsWo3cwzy0XC3sspAY6 leF089eI1pWTu/4y0Xp06WfM= X-Envelope-To: linux-kernel@vger.kernel.org Received: from [10.244.244.3] (2602:fce1:44f:115e::) by smtp.migadu.com with ESMTPS id 6049414b2e7cf9f4; Mon, 17 Aug 2026 03:07:59 +0000 X-Migadu-Flow: FLOW_OUT Message-ID: Date: Mon, 17 Aug 2026 11:07:49 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/rmap: synchronize lock and unlock target in anon_vma_clone Content-Language: en-US To: Eric Kim Cc: david@kernel.org, ljs@kernel.org, riel@surriel.com, liam@infradead.org, vbabka@kernel.org, harry@kernel.org, jannh@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org References: From: Lance Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026/8/17 10:34, Eric Kim wrote: > Currently, in anon_vma_clone(), active_anon_vma is assigned from > src->anon_vma and is used when unlocking anon_vma after linking > new AVCs. However, the corresponding lock operation uses > src->anon_vma directly. > > Use active_anon_vma consistently to make the lock/unlock pair explicit. > > Signed-off-by: Eric Kim > --- > v2: > - Clarify the commit message to explain that src->anon_vma and > active_anon_vma refer to the same anon_vma. Just a heads-up... since only the commit message changed, the Reviewed-by tags from v1 still apply, so please carry them over ...